You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by th...@yahoo.com on 2011/07/19 01:27:53 UTC

Re: Review Request: Project UDF output inside a non-foreach statement fail on 0.8

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/767/#review1105
-----------------------------------------------------------

Ship it!


+1

- thejas


On 2011-05-19 22:26:01, Daniel Dai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/767/
> -----------------------------------------------------------
> 
> (Updated 2011-05-19 22:26:01)
> 
> 
> Review request for pig and thejas.
> 
> 
> Summary
> -------
> 
> See PIG-2077
> 
> 
> This addresses bug PIG-2077.
>     https://issues.apache.org/jira/browse/PIG-2077
> 
> 
> Diffs
> -----
> 
>   branches/branch-0.8/src/org/apache/pig/newplan/logical/LogicalExpPlanMigrationVistor.java 1104455 
>   branches/branch-0.8/test/org/apache/pig/test/TestEvalPipeline2.java 1104455 
> 
> Diff: https://reviews.apache.org/r/767/diff
> 
> 
> Testing
> -------
> 
> Test patch:
>      [exec] +1 overall.  
>      [exec] 
>      [exec]     +1 @author.  The patch does not contain any @author tags.
>      [exec] 
>      [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
>      [exec] 
>      [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
>      [exec] 
>      [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
>      [exec] 
>      [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
>      [exec] 
>      [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
> 
> Unit test:
>     all pass
> 
> End to end test:
>     all pass
> 
> 
> Thanks,
> 
> Daniel
> 
>