You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jsoref <gi...@git.apache.org> on 2014/08/26 23:58:40 UTC

[GitHub] cordova-blackberry pull request: CB-7409 update CORDOVA_HOME_DIR b...

GitHub user jsoref opened a pull request:

    https://github.com/apache/cordova-blackberry/pull/176

    CB-7409 update CORDOVA_HOME_DIR based on npm_cache

    CB-7411 Make version in version script easier to replace by coho

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/blackberry/cordova-blackberry cb_7409

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-blackberry/pull/176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #176
    
----
commit e547827fec1e097fa2230c67b2435f4cdc5566fd
Author: Josh Soref <js...@blackberry.com>
Date:   2014-08-26T21:40:42Z

    CB-7409 update CORDOVA_HOME_DIR based on npm_cache

commit 8d9f2e40dcfafd482368ccadd1c8fa0589edd8e9
Author: Josh Soref <js...@blackberry.com>
Date:   2014-08-26T21:40:50Z

    CB-7411 Make version in version script easier to replace by coho

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-blackberry pull request: CB-7409 update CORDOVA_HOME_DIR b...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-blackberry/pull/176


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-blackberry pull request: CB-7409 update CORDOVA_HOME_DIR b...

Posted by bryanhiggins <gi...@git.apache.org>.
Github user bryanhiggins commented on the pull request:

    https://github.com/apache/cordova-blackberry/pull/176#issuecomment-53574787
  
    Is anything actually broken?
    
    AFAIK these environment variables are only used for bundling of binaries which would never be distributed via NPM. Downstream distributions could continue to place them under ~/.cordova/lib/blackberry10.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-blackberry pull request: CB-7409 update CORDOVA_HOME_DIR b...

Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:

    https://github.com/apache/cordova-blackberry/pull/176#issuecomment-53621621
  
    npm_cache is where we want downstream distributions to put things going forward, so it makes sense to update this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---