You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/03/10 16:07:36 UTC

[GitHub] [incubator-hudi] vinothchandar opened a new pull request #1391: [HUDI-688] Paring down the NOTICE file to minimum required notices

vinothchandar opened a new pull request #1391: [HUDI-688] Paring down the NOTICE file to minimum required notices
URL: https://github.com/apache/incubator-hudi/pull/1391
 
 
    - Based on analysis, we don't need to call out anything
    - We only do source releases at this time
    - Fix typo in LICENSE
   
   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] smarthi merged pull request #1391: [HUDI-688] Paring down the NOTICE file to minimum required notices

Posted by GitBox <gi...@apache.org>.
smarthi merged pull request #1391: [HUDI-688] Paring down the NOTICE file to minimum required notices
URL: https://github.com/apache/incubator-hudi/pull/1391
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] codecov-io commented on issue #1391: [HUDI-688] Paring down the NOTICE file to minimum required notices

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1391: [HUDI-688] Paring down the NOTICE file to minimum required notices
URL: https://github.com/apache/incubator-hudi/pull/1391#issuecomment-597203280
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1391?src=pr&el=h1) Report
   > Merging [#1391](https://codecov.io/gh/apache/incubator-hudi/pull/1391?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/77d5b92d88d6583bdfc09e4c10ecfe7ddbb04806&el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1391/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1391?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1391      +/-   ##
   ============================================
   - Coverage     67.40%   67.39%   -0.01%     
     Complexity      230      230              
   ============================================
     Files           336      336              
     Lines         16366    16366              
     Branches       1672     1672              
   ============================================
   - Hits          11031    11030       -1     
     Misses         4602     4602              
   - Partials        733      734       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1391?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...n/java/org/apache/hudi/common/model/HoodieKey.java](https://codecov.io/gh/apache/incubator-hudi/pull/1391/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUtleS5qYXZh) | `88.88% <0.00%> (-5.56%)` | `0.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1391?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1391?src=pr&el=footer). Last update [77d5b92...87bb2da](https://codecov.io/gh/apache/incubator-hudi/pull/1391?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services