You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/07/31 16:03:09 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #24846: fix: Links in tooltips of dashboard chart cards
michael-s-molina opened a new pull request, #24846:
URL: https://github.com/apache/superset/pull/24846
### SUMMARY
Fixes a bug where the dataset names were being displayed as links inside the tooltips.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="353" alt="Screenshot 2023-07-31 at 11 01 22" src="https://github.com/apache/superset/assets/70410625/669a0eba-9e96-4e14-9b5d-ac05b39ce4c5">
<img width="352" alt="Screenshot 2023-07-31 at 11 28 08" src="https://github.com/apache/superset/assets/70410625/d644f1b9-a4b0-4f3f-8449-46f4fdf81b51">
### TESTING INSTRUCTIONS
Make sure the dataset names are not links in the tooltips
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #24846: fix: Links in tooltips of dashboard chart cards
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #24846:
URL: https://github.com/apache/superset/pull/24846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24846: fix: Links in tooltips of dashboard chart cards
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24846:
URL: https://github.com/apache/superset/pull/24846#issuecomment-1658773463
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24846?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24846](https://app.codecov.io/gh/apache/superset/pull/24846?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (de0fc24) into [master](https://app.codecov.io/gh/apache/superset/commit/77889b29fb0e50473ca7656be4e5bf2f1dff5421?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (77889b2) will **decrease** coverage by `0.01%`.
> Report is 1 commits behind head on master.
> The diff coverage is `100.00%`.
> :exclamation: Current head de0fc24 differs from pull request most recent head 80f9f84. Consider uploading reports for the commit 80f9f84 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24846 +/- ##
==========================================
- Coverage 68.99% 68.99% -0.01%
==========================================
Files 1903 1903
Lines 74073 74074 +1
Branches 8193 8194 +1
==========================================
Hits 51108 51108
- Misses 20844 20847 +3
+ Partials 2121 2119 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `55.83% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/superset/pull/24846?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...dashboard/components/AddSliceCard/AddSliceCard.tsx](https://app.codecov.io/gh/apache/superset/pull/24846?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC9BZGRTbGljZUNhcmQudHN4) | `68.88% <100.00%> (+5.25%)` | :arrow_up: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24846/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org