Re: [ApacheDS] Move classes of module core-mock to src/test/java of core-api

[Alex Karasulu <ak...@apache.org>]

On Fri, Jun 4, 2010 at 12:27 AM, Stefan Seelmann <se...@apache.org>wrote:

> Felix Knecht wrote:
> > On 06/03/10 23:04, Stefan Seelmann wrote:
> >> Hi dev,
> >
> >> the core-mock module includes some mock implementations of ApacheDS
> >> core-api classes (CoreSession, DirectoryService, etc.). It is only used
> >> as test dependency in ldif-partition.
> >
> >> To get rid of the core-mock module I'd like to suggest to move those
> >> classes to src/test/java in core-api. To be able to use the test classes
> >> outside of the core-api module we just need to deploy the test jar of
> >> core-api. The using module then needs to specify a dependency with
> >> classifier "tests", see [1] for details.
> >
> >> Thoughts?
> >
> > +1
> >
> > Regards
> > Felix
>
> Should we declare the deployment of test jar for the core-api module
> only or should we deploy the test jars of all modules? In the latter
> case we can declare the maven-jar-module in the project pom, similar to
> the maven-source-plugin.
>
>
I like the idea of deploying some module tests because they can actually be
made to operate on different kinds of LDAP API providers or Partition
implementations as modular tests. Unfortunately JUnit is not the best for
running these tests on multiple implementations. Regardless overall this is
something that will be worth while for us once we tame our testing approach.

So yes I like this idea of enabling deployment of test jars.

-- 
Alex Karasulu
My Blog :: http://www.jroller.com/akarasulu/
Apache Directory Server :: http://directory.apache.org
Apache MINA :: http://mina.apache.org
To set up a meeting with me: http://tungle.me/AlexKarasulu