[GitHub] [metron] nickwallen edited a comment on issue #1261: METRON-1860 new developer option for ansible in docker to deploy to vagrant

[GitBox <gi...@apache.org>]

nickwallen edited a comment on issue #1261: METRON-1860  new developer option for ansible in docker to deploy to vagrant
URL: https://github.com/apache/metron/pull/1261#issuecomment-482179183
 
 
   There are a few things holding me back here. I like the end goal, but I don't fully understand the approach.
   
   (1) Why do we need a new VM definition in `metron-deployment/development/` to achieve this?  Why do we have to maintain a parallel set of artifacts in `metron-deployment/development/centos6_docker_build/`?  
   
   (2) I don't grok the need for all the scripts like `build_and_run.sh`, `docker_run_ansible.sh`, `run_docker_only.sh`.  That's just a lot of bash that I'd prefer to not maintain.  Can we simplify to match just the functionality we have today?  Why all the special handling for Cypress?
   
   EDIT: The first place I would have gone to add this functionality is in the `metron-builder` role.  Was there no way to add this functionality via that mechanism?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services