You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "lintingbin (via GitHub)" <gi...@apache.org> on 2024/08/14 07:08:38 UTC
[PR] Fix the issue where failure to start in k8s mode cannot be stopped. [incubator-streampark]
lintingbin opened a new pull request, #3965:
URL: https://github.com/apache/incubator-streampark/pull/3965
<!--
Thank you for contributing to StreamPark! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
## Contribution Checklist
- If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
- Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
-->
## What changes were proposed in this pull request
The existing k8s mode will change the status to FAILED after startup failure, which will cause the flink job to keep restarting on k8s, and there is no button on the front end of streampark to stop the flink job. This submission is to allow the flink job to be stopped via the abort button on the front end of streampark when the startup fails.
## Brief change log
1. Remove the "K8S_INITIALIZING" state specific to k8s mode.
2. When the rest interface of the flink job is not accessible and the job's deployment exists, the job should enter the Starting state instead of the failed state.
3. Change the abort implementation of k8s mode to delete the deployment.
## Verifying this change
<!--*(Please pick either of the following options)*-->
This change is a trivial rework / code cleanup without any test coverage.
<!--*(example:)*
- *Added integration tests for end-to-end.*
- *Added *Test to verify the change.*
- *Manually verified the change by testing locally.* -->
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the issue where failure to start in k8s mode cannot be stopped. [incubator-streampark]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3965:
URL: https://github.com/apache/incubator-streampark/pull/3965#issuecomment-2288010982
## [](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=3965) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=3965&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=3965&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-streampark&pullRequest=3965&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=3965&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=3965&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=3965)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the issue where failure to start in k8s mode cannot be stopped. [incubator-streampark]
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #3965:
URL: https://github.com/apache/incubator-streampark/pull/3965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the issue where failure to start in k8s mode cannot be stopped. [streampark]
Posted by "ysn2233 (via GitHub)" <gi...@apache.org>.
ysn2233 commented on PR #3965:
URL: https://github.com/apache/streampark/pull/3965#issuecomment-3685732197
Why this pr not merged into dev branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org