You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2024/04/04 11:49:58 UTC
(commons-io) branch master updated (08b3ea4ed -> 39df9602b)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
from 08b3ea4ed Tests IO-850
new 1215693fb Add missing test
new e7bd0142f Add missing test
new 39df9602b Add missing test
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../io/file/AccumulatorPathVisitorTest.java | 20 +++++++++++++
.../commons/io/file/CleaningPathVisitorTest.java | 20 +++++++++++++
.../commons/io/file/DeletingPathVisitorTest.java | 33 ++++++++++++++++++----
3 files changed, 67 insertions(+), 6 deletions(-)
(commons-io) 02/03: Add missing test
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
commit e7bd0142f6c899b7fa2c65a83778cabc3d25d498
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Apr 4 07:37:50 2024 -0400
Add missing test
---
.../commons/io/file/CleaningPathVisitorTest.java | 20 ++++++++++++++++++++
.../commons/io/file/DeletingPathVisitorTest.java | 4 ++--
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/src/test/java/org/apache/commons/io/file/CleaningPathVisitorTest.java b/src/test/java/org/apache/commons/io/file/CleaningPathVisitorTest.java
index 569bf67af..52983f96f 100644
--- a/src/test/java/org/apache/commons/io/file/CleaningPathVisitorTest.java
+++ b/src/test/java/org/apache/commons/io/file/CleaningPathVisitorTest.java
@@ -29,6 +29,7 @@ import java.nio.file.Paths;
import org.apache.commons.io.file.Counters.PathCounters;
import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;
@@ -136,4 +137,23 @@ public class CleaningPathVisitorTest extends TestArguments {
assertEquals(visitFileTree, visitFileTree);
assertEquals(visitFileTree.hashCode(), visitFileTree.hashCode());
}
+
+ @Test
+ public void testEqualsHashCode() {
+ final CountingPathVisitor visitor0 = CleaningPathVisitor.withLongCounters();
+ final CountingPathVisitor visitor1 = CleaningPathVisitor.withLongCounters();
+ assertEquals(visitor0, visitor0);
+ assertEquals(visitor0, visitor1);
+ assertEquals(visitor1, visitor0);
+ assertEquals(visitor0.hashCode(), visitor0.hashCode());
+ assertEquals(visitor0.hashCode(), visitor1.hashCode());
+ assertEquals(visitor1.hashCode(), visitor0.hashCode());
+ visitor0.getPathCounters().getByteCounter().increment();
+ assertEquals(visitor0, visitor0);
+ assertNotEquals(visitor0, visitor1);
+ assertNotEquals(visitor1, visitor0);
+ assertEquals(visitor0.hashCode(), visitor0.hashCode());
+ assertNotEquals(visitor0.hashCode(), visitor1.hashCode());
+ assertNotEquals(visitor1.hashCode(), visitor0.hashCode());
+ }
}
diff --git a/src/test/java/org/apache/commons/io/file/DeletingPathVisitorTest.java b/src/test/java/org/apache/commons/io/file/DeletingPathVisitorTest.java
index 1660922b0..c554d3d5b 100644
--- a/src/test/java/org/apache/commons/io/file/DeletingPathVisitorTest.java
+++ b/src/test/java/org/apache/commons/io/file/DeletingPathVisitorTest.java
@@ -136,9 +136,9 @@ public class DeletingPathVisitorTest extends AbstractTempDirTest {
assertNotEquals(visitor1, visitor0);
assertEquals(visitor0.hashCode(), visitor0.hashCode());
assertNotEquals(visitor0.hashCode(), visitor1.hashCode());
- assertNotEquals(visitor1.hashCode(), visitor0.hashCode());
+ assertNotEquals(visitor1.hashCode(), visitor0.hashCode());
}
-
+
/**
* Tests https://issues.apache.org/jira/browse/IO-850
*/
(commons-io) 03/03: Add missing test
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
commit 39df9602bfe0cd609598c58e7e77762dfa337ce2
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Apr 4 07:41:15 2024 -0400
Add missing test
---
.../commons/io/file/AccumulatorPathVisitorTest.java | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/src/test/java/org/apache/commons/io/file/AccumulatorPathVisitorTest.java b/src/test/java/org/apache/commons/io/file/AccumulatorPathVisitorTest.java
index 62069b626..45b5513e9 100644
--- a/src/test/java/org/apache/commons/io/file/AccumulatorPathVisitorTest.java
+++ b/src/test/java/org/apache/commons/io/file/AccumulatorPathVisitorTest.java
@@ -19,6 +19,7 @@ package org.apache.commons.io.file;
import static org.apache.commons.io.file.CounterAssertions.assertCounts;
import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
import java.io.IOException;
@@ -111,6 +112,25 @@ public class AccumulatorPathVisitorTest {
assertEquals(accPathVisitor.hashCode(), accPathVisitor.hashCode());
}
+ @Test
+ public void testEqualsHashCode() {
+ final AccumulatorPathVisitor visitor0 = AccumulatorPathVisitor.withLongCounters();
+ final AccumulatorPathVisitor visitor1 = AccumulatorPathVisitor.withLongCounters();
+ assertEquals(visitor0, visitor0);
+ assertEquals(visitor0, visitor1);
+ assertEquals(visitor1, visitor0);
+ assertEquals(visitor0.hashCode(), visitor0.hashCode());
+ assertEquals(visitor0.hashCode(), visitor1.hashCode());
+ assertEquals(visitor1.hashCode(), visitor0.hashCode());
+ visitor0.getPathCounters().getByteCounter().increment();
+ assertEquals(visitor0, visitor0);
+ assertNotEquals(visitor0, visitor1);
+ assertNotEquals(visitor1, visitor0);
+ assertEquals(visitor0.hashCode(), visitor0.hashCode());
+ assertNotEquals(visitor0.hashCode(), visitor1.hashCode());
+ assertNotEquals(visitor1.hashCode(), visitor0.hashCode());
+ }
+
/**
* Tests a directory with one file of size 0.
*/
(commons-io) 01/03: Add missing test
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
commit 1215693fbd6bbc13e2a09a22007a536cab5467f7
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Apr 4 07:36:16 2024 -0400
Add missing test
---
.../commons/io/file/DeletingPathVisitorTest.java | 33 ++++++++++++++++++----
1 file changed, 27 insertions(+), 6 deletions(-)
diff --git a/src/test/java/org/apache/commons/io/file/DeletingPathVisitorTest.java b/src/test/java/org/apache/commons/io/file/DeletingPathVisitorTest.java
index a0e3b3f9f..1660922b0 100644
--- a/src/test/java/org/apache/commons/io/file/DeletingPathVisitorTest.java
+++ b/src/test/java/org/apache/commons/io/file/DeletingPathVisitorTest.java
@@ -18,7 +18,9 @@
package org.apache.commons.io.file;
import static org.apache.commons.io.file.CounterAssertions.assertCounts;
+import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
import java.io.IOException;
@@ -118,41 +120,60 @@ public class DeletingPathVisitorTest extends AbstractTempDirTest {
Files.deleteIfExists(tempDirPath);
}
+ @Test
+ public void testEqualsHashCode() {
+ final DeletingPathVisitor visitor0 = DeletingPathVisitor.withLongCounters();
+ final DeletingPathVisitor visitor1 = DeletingPathVisitor.withLongCounters();
+ assertEquals(visitor0, visitor0);
+ assertEquals(visitor0, visitor1);
+ assertEquals(visitor1, visitor0);
+ assertEquals(visitor0.hashCode(), visitor0.hashCode());
+ assertEquals(visitor0.hashCode(), visitor1.hashCode());
+ assertEquals(visitor1.hashCode(), visitor0.hashCode());
+ visitor0.getPathCounters().getByteCounter().increment();
+ assertEquals(visitor0, visitor0);
+ assertNotEquals(visitor0, visitor1);
+ assertNotEquals(visitor1, visitor0);
+ assertEquals(visitor0.hashCode(), visitor0.hashCode());
+ assertNotEquals(visitor0.hashCode(), visitor1.hashCode());
+ assertNotEquals(visitor1.hashCode(), visitor0.hashCode());
+ }
+
/**
* Tests https://issues.apache.org/jira/browse/IO-850
*/
@Test
- public void testIO850DirectoriesOnly() throws IOException {
+ public void testIO850DirectoriesAndFiles() throws IOException {
final Path rootDir = Files.createDirectory(managedTempDirPath.resolve("IO850"));
createTempSymlinkedRelativeDir(rootDir);
final Path targetDir = rootDir.resolve(SUB_DIR);
final Path symlinkDir = rootDir.resolve(SYMLINKED_DIR);
+ Files.write(targetDir.resolve("file0.txt"), "Hello".getBytes(StandardCharsets.UTF_8));
+ final Path subDir0 = Files.createDirectory(targetDir.resolve("subDir0"));
+ Files.write(subDir0.resolve("file1.txt"), "Hello".getBytes(StandardCharsets.UTF_8));
final DeletingPathVisitor visitor = DeletingPathVisitor.withLongCounters();
Files.walkFileTree(rootDir, visitor);
assertFalse(Files.exists(targetDir));
assertFalse(Files.exists(symlinkDir));
assertFalse(Files.exists(rootDir));
assertTrue(visitor.getPathCounters().getDirectoryCounter().get() > 0);
+ assertTrue(visitor.getPathCounters().getFileCounter().get() > 0);
}
/**
* Tests https://issues.apache.org/jira/browse/IO-850
*/
@Test
- public void testIO850DirectoriesAndFiles() throws IOException {
+ public void testIO850DirectoriesOnly() throws IOException {
final Path rootDir = Files.createDirectory(managedTempDirPath.resolve("IO850"));
createTempSymlinkedRelativeDir(rootDir);
final Path targetDir = rootDir.resolve(SUB_DIR);
final Path symlinkDir = rootDir.resolve(SYMLINKED_DIR);
- Files.write(targetDir.resolve("file0.txt"), "Hello".getBytes(StandardCharsets.UTF_8));
- final Path subDir0 = Files.createDirectory(targetDir.resolve("subDir0"));
- Files.write(subDir0.resolve("file1.txt"), "Hello".getBytes(StandardCharsets.UTF_8));
final DeletingPathVisitor visitor = DeletingPathVisitor.withLongCounters();
Files.walkFileTree(rootDir, visitor);
assertFalse(Files.exists(targetDir));
assertFalse(Files.exists(symlinkDir));
assertFalse(Files.exists(rootDir));
assertTrue(visitor.getPathCounters().getDirectoryCounter().get() > 0);
- assertTrue(visitor.getPathCounters().getFileCounter().get() > 0);
}
}