You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@joshua.apache.org by Tommaso Teofili <to...@gmail.com> on 2016/04/12 11:59:11 UTC
tests are not run using latest code
Hi all,
while having a look at [1], I have realized that current tests in Joshua do
not run against latest source code (I think), in fact the test compilation
fails (with Maven) if I just set the test directory.
I think that, besides the Ant vs Maven thing, it'd be really good if we
could use latest code when performing tests.
Or am I missing something ?
Regards,
Tommaso
[1] : https://issues.apache.org/jira/browse/JOSHUA-252
Re: tests are not run using latest code
Posted by Lewis John Mcgibbney <le...@gmail.com>.
https://issues.apache.org/jira/browse/JOSHUA-253
On Thu, Apr 14, 2016 at 6:42 AM, Matt Post <po...@cs.jhu.edu> wrote:
> "ant test" runs the regression tests under test/ (it runs
> test/run-all-tests.sh, which looks for all scripts underneath test of the
> form test.sh, and executes them).
>
> No unit tests are currently run. This is obviously broken.
>
> matt
>
>
> > On Apr 12, 2016, at 8:02 PM, Lewis John Mcgibbney <
> lewis.mcgibbney@gmail.com> wrote:
> >
> > I thought it was the unit tests that were being run!
> > If not then we need to log a Jira ticket and make sure that they are.
> > Lewis
> >
> > On Tue, Apr 12, 2016 at 7:31 AM, Tommaso Teofili <
> tommaso.teofili@gmail.com>
> > wrote:
> >
> >> Il giorno mar 12 apr 2016 alle ore 15:10 Lewis John Mcgibbney <
> >> lewis.mcgibbney@gmail.com> ha scritto:
> >>
> >>> So you are building with Macen Tommaso? The Maven build is not
> >> functional.
> >>>
> >>
> >> I have committed a couple of fixes so that by now running mvn clean
> install
> >> works (but no tests are run).
> >>
> >>
> >>> Instead if you build with Ant it does build the tests and then run
> them.
> >>>
> >>
> >> the thing is that the Ant tests execute the bash scripts which are
> >> integration tests in the end, while I was expecting the java unit tests
> to
> >> be executed (too); I think those should work with Ant too.
> >>
> >> Regards,
> >> Tommaso
> >>
> >>
> >>> Lewis
> >>>
> >>> On Tuesday, April 12, 2016, Tommaso Teofili <tommaso.teofili@gmail.com
> >
> >>> wrote:
> >>>
> >>>> Hi all,
> >>>>
> >>>> while having a look at [1], I have realized that current tests in
> >> Joshua
> >>> do
> >>>> not run against latest source code (I think), in fact the test
> >>> compilation
> >>>> fails (with Maven) if I just set the test directory.
> >>>> I think that, besides the Ant vs Maven thing, it'd be really good if
> we
> >>>> could use latest code when performing tests.
> >>>> Or am I missing something ?
> >>>>
> >>>> Regards,
> >>>> Tommaso
> >>>>
> >>>> [1] : https://issues.apache.org/jira/browse/JOSHUA-252
> >>>>
> >>>
> >>>
> >>> --
> >>> *Lewis*
> >>>
> >>
> >
> >
> >
> > --
> > *Lewis*
>
>
--
*Lewis*
Re: tests are not run using latest code
Posted by Matt Post <po...@cs.jhu.edu>.
"ant test" runs the regression tests under test/ (it runs test/run-all-tests.sh, which looks for all scripts underneath test of the form test.sh, and executes them).
No unit tests are currently run. This is obviously broken.
matt
> On Apr 12, 2016, at 8:02 PM, Lewis John Mcgibbney <le...@gmail.com> wrote:
>
> I thought it was the unit tests that were being run!
> If not then we need to log a Jira ticket and make sure that they are.
> Lewis
>
> On Tue, Apr 12, 2016 at 7:31 AM, Tommaso Teofili <to...@gmail.com>
> wrote:
>
>> Il giorno mar 12 apr 2016 alle ore 15:10 Lewis John Mcgibbney <
>> lewis.mcgibbney@gmail.com> ha scritto:
>>
>>> So you are building with Macen Tommaso? The Maven build is not
>> functional.
>>>
>>
>> I have committed a couple of fixes so that by now running mvn clean install
>> works (but no tests are run).
>>
>>
>>> Instead if you build with Ant it does build the tests and then run them.
>>>
>>
>> the thing is that the Ant tests execute the bash scripts which are
>> integration tests in the end, while I was expecting the java unit tests to
>> be executed (too); I think those should work with Ant too.
>>
>> Regards,
>> Tommaso
>>
>>
>>> Lewis
>>>
>>> On Tuesday, April 12, 2016, Tommaso Teofili <to...@gmail.com>
>>> wrote:
>>>
>>>> Hi all,
>>>>
>>>> while having a look at [1], I have realized that current tests in
>> Joshua
>>> do
>>>> not run against latest source code (I think), in fact the test
>>> compilation
>>>> fails (with Maven) if I just set the test directory.
>>>> I think that, besides the Ant vs Maven thing, it'd be really good if we
>>>> could use latest code when performing tests.
>>>> Or am I missing something ?
>>>>
>>>> Regards,
>>>> Tommaso
>>>>
>>>> [1] : https://issues.apache.org/jira/browse/JOSHUA-252
>>>>
>>>
>>>
>>> --
>>> *Lewis*
>>>
>>
>
>
>
> --
> *Lewis*
Re: tests are not run using latest code
Posted by Lewis John Mcgibbney <le...@gmail.com>.
I thought it was the unit tests that were being run!
If not then we need to log a Jira ticket and make sure that they are.
Lewis
On Tue, Apr 12, 2016 at 7:31 AM, Tommaso Teofili <to...@gmail.com>
wrote:
> Il giorno mar 12 apr 2016 alle ore 15:10 Lewis John Mcgibbney <
> lewis.mcgibbney@gmail.com> ha scritto:
>
> > So you are building with Macen Tommaso? The Maven build is not
> functional.
> >
>
> I have committed a couple of fixes so that by now running mvn clean install
> works (but no tests are run).
>
>
> > Instead if you build with Ant it does build the tests and then run them.
> >
>
> the thing is that the Ant tests execute the bash scripts which are
> integration tests in the end, while I was expecting the java unit tests to
> be executed (too); I think those should work with Ant too.
>
> Regards,
> Tommaso
>
>
> > Lewis
> >
> > On Tuesday, April 12, 2016, Tommaso Teofili <to...@gmail.com>
> > wrote:
> >
> > > Hi all,
> > >
> > > while having a look at [1], I have realized that current tests in
> Joshua
> > do
> > > not run against latest source code (I think), in fact the test
> > compilation
> > > fails (with Maven) if I just set the test directory.
> > > I think that, besides the Ant vs Maven thing, it'd be really good if we
> > > could use latest code when performing tests.
> > > Or am I missing something ?
> > >
> > > Regards,
> > > Tommaso
> > >
> > > [1] : https://issues.apache.org/jira/browse/JOSHUA-252
> > >
> >
> >
> > --
> > *Lewis*
> >
>
--
*Lewis*
Re: tests are not run using latest code
Posted by Tommaso Teofili <to...@gmail.com>.
Il giorno mar 12 apr 2016 alle ore 15:10 Lewis John Mcgibbney <
lewis.mcgibbney@gmail.com> ha scritto:
> So you are building with Macen Tommaso? The Maven build is not functional.
>
I have committed a couple of fixes so that by now running mvn clean install
works (but no tests are run).
> Instead if you build with Ant it does build the tests and then run them.
>
the thing is that the Ant tests execute the bash scripts which are
integration tests in the end, while I was expecting the java unit tests to
be executed (too); I think those should work with Ant too.
Regards,
Tommaso
> Lewis
>
> On Tuesday, April 12, 2016, Tommaso Teofili <to...@gmail.com>
> wrote:
>
> > Hi all,
> >
> > while having a look at [1], I have realized that current tests in Joshua
> do
> > not run against latest source code (I think), in fact the test
> compilation
> > fails (with Maven) if I just set the test directory.
> > I think that, besides the Ant vs Maven thing, it'd be really good if we
> > could use latest code when performing tests.
> > Or am I missing something ?
> >
> > Regards,
> > Tommaso
> >
> > [1] : https://issues.apache.org/jira/browse/JOSHUA-252
> >
>
>
> --
> *Lewis*
>
Re: tests are not run using latest code
Posted by Lewis John Mcgibbney <le...@gmail.com>.
So you are building with Macen Tommaso? The Maven build is not functional.
Instead if you build with Ant it does build the tests and then run them.
Lewis
On Tuesday, April 12, 2016, Tommaso Teofili <to...@gmail.com>
wrote:
> Hi all,
>
> while having a look at [1], I have realized that current tests in Joshua do
> not run against latest source code (I think), in fact the test compilation
> fails (with Maven) if I just set the test directory.
> I think that, besides the Ant vs Maven thing, it'd be really good if we
> could use latest code when performing tests.
> Or am I missing something ?
>
> Regards,
> Tommaso
>
> [1] : https://issues.apache.org/jira/browse/JOSHUA-252
>
--
*Lewis*