[GitHub] [spark] attilapiros commented on a change in pull request #34672: [SPARK-37394][CORE] Skip registering with ESS if a customized shuffle manager is configured

[GitBox <gi...@apache.org>]

attilapiros commented on a change in pull request #34672:
URL: https://github.com/apache/spark/pull/34672#discussion_r759065038



##########
File path: core/src/main/scala/org/apache/spark/shuffle/ShuffleManager.scala
##########
@@ -91,6 +91,15 @@ private[spark] trait ShuffleManager {
    */
   def shuffleBlockResolver: ShuffleBlockResolver
 
+  /**
+   * The flag to indicate if the shuffle manager needs to work with a local shuffle service,
+   * by default it returns true; if the shuffle manager works with a remote shuffle service,

Review comment:
       ```suggestion
      * by default it returns true; if the shuffle manager does not work with a remote shuffle service,
   ```
   please check the line length before accepting




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org