You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ptlrs (via GitHub)" <gi...@apache.org> on 2026/05/10 05:57:40 UTC
[PR] HDDS-3936. Use suggested OM leader information to guide the client failover [ozone]
ptlrs opened a new pull request, #10228:
URL: https://github.com/apache/ozone/pull/10228
## What changes were proposed in this pull request?
When OM client talks to a follower and receives the ServiceException, the OMNotLeaderException sets the suggested leader information to null.
The exception string does preserve the leader information in the message but it needs to be parsed and extracted first.
This PR
* Creates a new string format which contains the suggested leader information so that it can be parsed
* Updates the suggested leader information when converting the exceptions to OMNotLeaderException
* Adds tests
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3936
## How was this patch tested?
CI: https://github.com/ptlrs/ozone/actions/runs/25620947837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-3936. Use suggested OM leader information to guide the client failover [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #10228:
URL: https://github.com/apache/ozone/pull/10228#issuecomment-4657777034
@ptlrs Thanks for the patch. I just skimmed it quickly.
The regex will work, but once it's deployed we need to stick to it. From HDDS-14510, it is better to use the OM ID (instead of OM node ID) to identify a unique OM node (since the client-side and server-side OM node ID configuration can be different). So I think it's better for HDDS-14510 to be addressed first and then we use OM ID for the suggested leader. Please let me know what you think. You can pick up HDDS-14510 if you like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-3936. Use suggested OM leader information to guide the client failover [ozone]
Posted by "ptlrs (via GitHub)" <gi...@apache.org>.
ptlrs commented on PR #10228:
URL: https://github.com/apache/ozone/pull/10228#issuecomment-4594702408
Not stale.
Hi @peterxcli @ivandika3, could you please take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-3936. Use suggested OM leader information to guide the client failover [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #10228: HDDS-3936. Use suggested OM leader information to guide the client failover
URL: https://github.com/apache/ozone/pull/10228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-3936. Use suggested OM leader information to guide the client failover [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10228:
URL: https://github.com/apache/ozone/pull/10228#issuecomment-4930777566
Thank you for your contribution. This PR is being closed due to inactivity. Please contact a maintainer if you would like to reopen it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-3936. Use suggested OM leader information to guide the client failover [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10228:
URL: https://github.com/apache/ozone/pull/10228#issuecomment-4588695708
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org