You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/22 11:00:46 UTC

[GitHub] [flink] rmetzger commented on a change in pull request #13438: [FLINK-19014][e2e] Increase startup timeout

rmetzger commented on a change in pull request #13438:
URL: https://github.com/apache/flink/pull/13438#discussion_r492646461



##########
File path: flink-dist/src/main/flink-bin/bin/flink-daemon.sh
##########
@@ -88,15 +88,6 @@ out="${FLINK_LOG_PREFIX}.out"
 
 log_setting=("-Dlog.file=${log}" "-Dlog4j.configuration=file:${FLINK_CONF_DIR}/log4j.properties" "-Dlog4j.configurationFile=file:${FLINK_CONF_DIR}/log4j.properties" "-Dlogback.configurationFile=file:${FLINK_CONF_DIR}/logback.xml")
 
-JAVA_VERSION=$(${JAVA_RUN} -version 2>&1 | sed 's/.*version "\(.*\)\.\(.*\)\..*"/\1\2/; 1q')

Review comment:
       Damn, I need to work on my `git grep` skills 😄 
   
   I removed it because the java version is used to check if the version is less than 1.8. Since it can never be less than 1.8, we don't need this check (anymore).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org