You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/14 20:18:47 UTC
[GitHub] codecov-io commented on issue #4914: Make MetricsControl the
standard across visualizations
codecov-io commented on issue #4914: Make MetricsControl the standard across visualizations
URL: https://github.com/apache/incubator-superset/pull/4914#issuecomment-388948901
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4914?src=pr&el=h1) Report
> Merging [#4914](https://codecov.io/gh/apache/incubator-superset/pull/4914?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7a4a89b1959b72295abf986bc4cf330059682105?src=pr&el=desc) will **increase** coverage by `0.23%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/4914?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4914 +/- ##
==========================================
+ Coverage 77.1% 77.34% +0.23%
==========================================
Files 44 44
Lines 8644 8664 +20
==========================================
+ Hits 6665 6701 +36
+ Misses 1979 1963 -16
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4914?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4914/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4914/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.48% <96.96%> (+1.19%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4914/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.47% <0%> (-0.08%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/4914/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `98.79% <0%> (-0.06%)` | :arrow_down: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4914/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `53.74% <0%> (+0.87%)` | :arrow_up: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4914/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `75.27% <0%> (+0.95%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4914?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4914?src=pr&el=footer). Last update [7a4a89b...3d35544](https://codecov.io/gh/apache/incubator-superset/pull/4914?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org