Re: [PR] Improve ServiceResourceTransformerTest [maven-shade-plugin]

["elharo (via GitHub)" <gi...@apache.org>]

elharo commented on code in PR #248:
URL: https://github.com/apache/maven-shade-plugin/pull/248#discussion_r3674487060


##########
src/test/java/org/apache/maven/plugins/shade/resource/ServiceResourceTransformerTest.java:
##########
@@ -45,14 +44,23 @@
  */
 public class ServiceResourceTransformerTest {
     private final String NEWLINE = "\n";
+    private File tempJar;
 
-    private List<Relocator> relocators = new ArrayList<Relocator>();
+    @Before
+    public void setup() throws IOException {
+        tempJar = File.createTempFile("shade.", ".jar");

Review Comment:
   no setUo method needed, just initalizae the field



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org