You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Yaswanth-Perumalla (via GitHub)" <gi...@apache.org> on 2023/08/09 09:20:45 UTC
[GitHub] [superset] Yaswanth-Perumalla opened a new pull request, #24927: fixed-indian-map-border
Yaswanth-Perumalla opened a new pull request, #24927:
URL: https://github.com/apache/superset/pull/24927
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Indian Map Changes): fixed-Indian-map-border [superset]
Posted by "PushpenderSaini0 (via GitHub)" <gi...@apache.org>.
PushpenderSaini0 commented on PR #24927:
URL: https://github.com/apache/superset/pull/24927#issuecomment-2159688812
> > The map of India is incorrect after upgrading to version 4.0.1
>
> Eek! If you want to open a PR, feel free, but we'll try to assess/fix ASAP. I even wrote a [blog post](https://preset.io/blog/how-and-when-and-why-to-update-apache-supersets-country-maps/) about how to make such a contribution, and how we're trying to be better about keeping these things current and permanent.
Hi i have raised a PR that restores changes that were made in this PR using the new GeoJson Generator script !
cc @amanmaurya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #24927: fix(Indian Map Changes): fixed-Indian-map-border
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #24927:
URL: https://github.com/apache/superset/pull/24927#issuecomment-1741699190
If you check the failed CI workflow, it appears to complain about a missing newline at the end of the file. If you need help resolving it I can help, but feel free to take a stab at it first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #24927: fix(Indian Map Changes): fixed-Indian-map-border
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24927:
URL: https://github.com/apache/superset/pull/24927#issuecomment-1695850193
@Yaswanth-Perumalla there are a handful of people on Slack very excited to merge this PR. Can you give us an update on the questions above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Indian Map Changes): fixed-Indian-map-border [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24927:
URL: https://github.com/apache/superset/pull/24927#issuecomment-2140412634
> The map of India is incorrect after upgrading to version 4.0.1
Eek! If you want to open a PR, feel free, but we'll try to assess/fix ASAP. I even wrote a [blog post](https://preset.io/blog/how-and-when-and-why-to-update-apache-supersets-country-maps/) about how to make such a contribution, and how we're trying to be better about keeping these things current and permanent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #24927: fix(Indian Map Changes): fixed-Indian-map-border
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #24927:
URL: https://github.com/apache/superset/pull/24927#issuecomment-1690503794
> @Yaswanth-Perumalla it seems that your updated map may include disputed territories. I think @villebro might have worked on a similar issue in the past and likely should weigh in here. In the case of a dispute I believe we allow all disputing territories include the region in their map.
We take the stance that disputed areas can be featured on multiple maps, as long as there is an ISO code to back it up. @Yaswanth-Perumalla would you mind adding a reference to where you obtained the updated polygon data for this PR? Also, if you used the Notebook in this repo, it would be nice if you could also update that as part of this PR so that it's in sync with the current state of the rendered map regions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Yaswanth-Perumalla commented on pull request #24927: fix(Indian Map Changes): fixed-Indian-map-border
Posted by "Yaswanth-Perumalla (via GitHub)" <gi...@apache.org>.
Yaswanth-Perumalla commented on PR #24927:
URL: https://github.com/apache/superset/pull/24927#issuecomment-1738990460
@villebro I have updated the notes. Kindly check and let me know if you need any further changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Indian Map Changes): fixed-Indian-map-border [superset]
Posted by "amanmaurya (via GitHub)" <gi...@apache.org>.
amanmaurya commented on PR #24927:
URL: https://github.com/apache/superset/pull/24927#issuecomment-2139385818
The map of India is incorrect after upgrading to version 4.0.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Yaswanth-Perumalla commented on pull request #24927: fix(Indian Map Changes): fixed-Indian-map-border
Posted by "Yaswanth-Perumalla (via GitHub)" <gi...@apache.org>.
Yaswanth-Perumalla commented on PR #24927:
URL: https://github.com/apache/superset/pull/24927#issuecomment-1702179165
@villebro @rusackas I have not utilized any notebooks in this repository. Can you guide me on where I should make updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #24927: fix(Indian Map Changes): fixed-Indian-map-border
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #24927:
URL: https://github.com/apache/superset/pull/24927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #24927: fix(Indian Map Changes): fixed-Indian-map-border
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #24927:
URL: https://github.com/apache/superset/pull/24927#issuecomment-1741699131
If you check the failed CI workflow, it appears to complain about a missing newline at the end of the file. If you need help resolving it I can help, but feel free to take a stab at it first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #24927: fix(Indian Map Changes): fixed-Indian-map-border
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #24927:
URL: https://github.com/apache/superset/pull/24927#issuecomment-1703301482
@Yaswanth-Perumalla this is the notebook that's been used to generate most (or all) maps: https://github.com/apache/superset/tree/master/superset-frontend/plugins/legacy-plugin-chart-country-map/scripts Can you check if that generates the correct polygons, and if not, maybe add a note to it so someone doesn't overwrite these in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Yaswanth-Perumalla commented on pull request #24927: fix(Indian Map Changes): fixed-Indian-map-border
Posted by "Yaswanth-Perumalla (via GitHub)" <gi...@apache.org>.
Yaswanth-Perumalla commented on PR #24927:
URL: https://github.com/apache/superset/pull/24927#issuecomment-1741694867
@rusackas I've encountered a failed check after making updates to the notes. Can you assist me in understanding the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #24927: fix(Indian Map Changes): fixed-Indian-map-border
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #24927:
URL: https://github.com/apache/superset/pull/24927#issuecomment-1675086141
@Yaswanth-Perumalla it seems that your updated map may include disputed territories. I think @villebro might have worked on a similar issue in the past and likely should weigh in here. In the case of a dispute I believe we allow all disputing territories include the region in their map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #24927: fix(Indian Map Changes): fixed-Indian-map-border
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #24927:
URL: https://github.com/apache/superset/pull/24927#issuecomment-1671808180
Thanks @Yaswanth-Perumalla for the PR. Would you mind including before and after screenshots so reviewers can visualize the difference. Also any additional context you can provide in terms of what was wrong and/or why your proposed solution is correct would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24927: fix(Indian Map Changes): fixed-Indian-map-border
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24927:
URL: https://github.com/apache/superset/pull/24927#issuecomment-1671892458
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24927?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24927](https://app.codecov.io/gh/apache/superset/pull/24927?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (55a7ace) into [master](https://app.codecov.io/gh/apache/superset/commit/ec9e9a46f2f092ce56d3ed5a8a9a3ea0214db88a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ec9e9a4) will **not change** coverage.
> Report is 3 commits behind head on master.
> The diff coverage is `n/a`.
> :exclamation: Current head 55a7ace differs from pull request most recent head 2706530. Consider uploading reports for the commit 2706530 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24927 +/- ##
=======================================
Coverage 69.00% 69.00%
=======================================
Files 1906 1906
Lines 74133 74133
Branches 8208 8208
=======================================
Hits 51153 51153
Misses 20857 20857
Partials 2123 2123
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `55.84% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org