You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2016/11/03 00:31:12 UTC
Review Request 53415: Avoid downloading the Proton C sources when
building the python C extenstion
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53415/
-----------------------------------------------------------
Review request for qpid, Justin Ross and Robbie Gemmell.
Bugs: PROTON-1330
https://issues.apache.org/jira/browse/PROTON-1330
Repository: qpid-proton-git
Description
-------
This change removes the ability to download the Proton C sources from the Apache dist website. Instead, the C sources are included in the Python source distribution and are used to build the C extension if the Proton C devel headers + library are not already installed.
See the PACKAGING.txt file for a description of how to create a python source package.
Diffs
-----
proton-c/bindings/python/CMakeLists.txt fc28417
proton-c/bindings/python/MANIFEST.in a89a962
proton-c/bindings/python/PACKAGING.txt PRE-CREATION
proton-c/bindings/python/README.rst.in PRE-CREATION
proton-c/bindings/python/setup.py 1a74f0f
proton-c/bindings/python/setup.py.in PRE-CREATION
proton-c/bindings/python/setuputils/bundle.py 1bf3450
proton-c/bindings/python/setuputils/misc.py b1864a0
proton-c/tox.ini.in 7a9c8eb
Diff: https://reviews.apache.org/r/53415/diff/
Testing
-------
Thanks,
Kenneth Giusti
Re: Review Request 53415: Avoid downloading the Proton C sources when
building the python C extenstion
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53415/#review154664
-----------------------------------------------------------
proton-c/bindings/python/setup.py.in (line 1)
<https://reviews.apache.org/r/53415/#comment224288>
I moved the setup.py file to setup.py.in, so this file is not completely new. Don't understand why reviewboard thinks this is a new file.
- Kenneth Giusti
On Nov. 3, 2016, 12:31 a.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53415/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2016, 12:31 a.m.)
>
>
> Review request for qpid, Justin Ross and Robbie Gemmell.
>
>
> Bugs: PROTON-1330
> https://issues.apache.org/jira/browse/PROTON-1330
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> This change removes the ability to download the Proton C sources from the Apache dist website. Instead, the C sources are included in the Python source distribution and are used to build the C extension if the Proton C devel headers + library are not already installed.
>
> See the PACKAGING.txt file for a description of how to create a python source package.
>
>
> Diffs
> -----
>
> proton-c/bindings/python/CMakeLists.txt fc28417
> proton-c/bindings/python/MANIFEST.in a89a962
> proton-c/bindings/python/PACKAGING.txt PRE-CREATION
> proton-c/bindings/python/README.rst.in PRE-CREATION
> proton-c/bindings/python/setup.py 1a74f0f
> proton-c/bindings/python/setup.py.in PRE-CREATION
> proton-c/bindings/python/setuputils/bundle.py 1bf3450
> proton-c/bindings/python/setuputils/misc.py b1864a0
> proton-c/tox.ini.in 7a9c8eb
>
> Diff: https://reviews.apache.org/r/53415/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kenneth Giusti
>
>