You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "ZHENG Zhong (JIRA)" <pl...@jakarta.apache.org> on 2005/07/23 18:39:53 UTC

[jira] Created: (PLUTO-139) When calling FactoryManagerService.getFactory(), some arguments passed are not logic.

When calling FactoryManagerService.getFactory(), some arguments passed are not logic.
-------------------------------------------------------------------------------------

         Key: PLUTO-139
         URL: http://issues.apache.org/jira/browse/PLUTO-139
     Project: Pluto
        Type: Improvement
  Components: portlet container  
    Versions: Current CVS    
    Reporter: ZHENG Zhong
    Priority: Minor


The pluto container defines a set of Factory interfaces to create certain classes, such as classes in the "javax.portlet" package. In the FactoryManagerService interface, the following method is defined:

public Factory getFactory(Class theClass);

The method signature seems to mean that: get a factory instance that i can use to create the specified class (theClass). For example, pluto will call FactoryManagerService.getFactory(RenderRequest.class) to get a render request factory instance which may be used to create RenderRequest instances. Thus...

1- In the "org.apache.pluto.util.ObjectIDAccess" class,  to get an ObjectIDFactory instance, which may be used to create ObjectID instances, Pluto should call 'FactoryManagerService.getFactory(ObjectID.class)' instead of 'FactoryManagerService.getFactory(ObjectIDFactory.class)'.

2 - In the "org.apache.pluto.om.ControllerObjectAccess" class, to get a ControllerFactory instance, which may be used to create Controller instances, Pluto should call 'FactoryManagerService.getFactory(Controller.class)' instead of 'FactoryManagerService.getFactory(ControllerFactory.class)'.

Regards.
ZHENG Zhong



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (PLUTO-139) When calling FactoryManagerService.getFactory(), some arguments passed are not logic.

Posted by "ZHENG Zhong (JIRA)" <pl...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/PLUTO-139?page=all ]

ZHENG Zhong updated PLUTO-139:
------------------------------

    Attachment: ObjectIDAccess.diff.txt

Updated 'org.apache.pluto.util.ObjectIDAccess' to pass more logic argument.
(This requires that portal/src/webapp/WEB-INF/config/services/FactoryManagerService.properties is updated accordingly.)


> When calling FactoryManagerService.getFactory(), some arguments passed are not logic.
> -------------------------------------------------------------------------------------
>
>          Key: PLUTO-139
>          URL: http://issues.apache.org/jira/browse/PLUTO-139
>      Project: Pluto
>         Type: Improvement
>   Components: portlet container
>     Versions: Current CVS
>     Reporter: ZHENG Zhong
>     Priority: Minor
>  Attachments: ControllerObjectAccess.diff.txt, FactoryManagerService.diff.txt, ObjectIDAccess.diff.txt
>
> The pluto container defines a set of Factory interfaces to create certain classes, such as classes in the "javax.portlet" package. In the FactoryManagerService interface, the following method is defined:
> public Factory getFactory(Class theClass);
> The method signature seems to mean that: get a factory instance that i can use to create the specified class (theClass). For example, pluto will call FactoryManagerService.getFactory(RenderRequest.class) to get a render request factory instance which may be used to create RenderRequest instances. Thus...
> 1- In the "org.apache.pluto.util.ObjectIDAccess" class,  to get an ObjectIDFactory instance, which may be used to create ObjectID instances, Pluto should call 'FactoryManagerService.getFactory(ObjectID.class)' instead of 'FactoryManagerService.getFactory(ObjectIDFactory.class)'.
> 2 - In the "org.apache.pluto.om.ControllerObjectAccess" class, to get a ControllerFactory instance, which may be used to create Controller instances, Pluto should call 'FactoryManagerService.getFactory(Controller.class)' instead of 'FactoryManagerService.getFactory(ControllerFactory.class)'.
> Regards.
> ZHENG Zhong

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (PLUTO-139) When calling FactoryManagerService.getFactory(), some arguments passed are not logic.

Posted by "David DeWolf (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David DeWolf resolved PLUTO-139.
--------------------------------

    Resolution: Won't Fix

> When calling FactoryManagerService.getFactory(), some arguments passed are not logic.
> -------------------------------------------------------------------------------------
>
>                 Key: PLUTO-139
>                 URL: https://issues.apache.org/jira/browse/PLUTO-139
>             Project: Pluto
>          Issue Type: Improvement
>          Components: portlet container
>    Affects Versions: 1.0.1
>            Reporter: @deprecated ZHENG Zhong
>            Priority: Minor
>             Fix For: 1.0.2
>
>         Attachments: ControllerObjectAccess.diff.txt, FactoryManagerService.diff.txt, ObjectIDAccess.diff.txt
>
>
> The pluto container defines a set of Factory interfaces to create certain classes, such as classes in the "javax.portlet" package. In the FactoryManagerService interface, the following method is defined:
> public Factory getFactory(Class theClass);
> The method signature seems to mean that: get a factory instance that i can use to create the specified class (theClass). For example, pluto will call FactoryManagerService.getFactory(RenderRequest.class) to get a render request factory instance which may be used to create RenderRequest instances. Thus...
> 1- In the "org.apache.pluto.util.ObjectIDAccess" class,  to get an ObjectIDFactory instance, which may be used to create ObjectID instances, Pluto should call 'FactoryManagerService.getFactory(ObjectID.class)' instead of 'FactoryManagerService.getFactory(ObjectIDFactory.class)'.
> 2 - In the "org.apache.pluto.om.ControllerObjectAccess" class, to get a ControllerFactory instance, which may be used to create Controller instances, Pluto should call 'FactoryManagerService.getFactory(Controller.class)' instead of 'FactoryManagerService.getFactory(ControllerFactory.class)'.
> Regards.
> ZHENG Zhong

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PLUTO-139) When calling FactoryManagerService.getFactory(), some arguments passed are not logic.

Posted by "ZHENG Zhong (JIRA)" <pl...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/PLUTO-139?page=all ]

ZHENG Zhong updated PLUTO-139:
------------------------------

    Attachment: ControllerObjectAccess.diff.txt

Updated 'org.apache.pluto.om.ControllerObjectAccess' to pass more logic argument.
(This requires that portal/src/webapp/WEB-INF/config/services/FactoryManagerService.properties is updated accordingly.) 

> When calling FactoryManagerService.getFactory(), some arguments passed are not logic.
> -------------------------------------------------------------------------------------
>
>          Key: PLUTO-139
>          URL: http://issues.apache.org/jira/browse/PLUTO-139
>      Project: Pluto
>         Type: Improvement
>   Components: portlet container
>     Versions: Current CVS
>     Reporter: ZHENG Zhong
>     Priority: Minor
>  Attachments: ControllerObjectAccess.diff.txt, FactoryManagerService.diff.txt, ObjectIDAccess.diff.txt
>
> The pluto container defines a set of Factory interfaces to create certain classes, such as classes in the "javax.portlet" package. In the FactoryManagerService interface, the following method is defined:
> public Factory getFactory(Class theClass);
> The method signature seems to mean that: get a factory instance that i can use to create the specified class (theClass). For example, pluto will call FactoryManagerService.getFactory(RenderRequest.class) to get a render request factory instance which may be used to create RenderRequest instances. Thus...
> 1- In the "org.apache.pluto.util.ObjectIDAccess" class,  to get an ObjectIDFactory instance, which may be used to create ObjectID instances, Pluto should call 'FactoryManagerService.getFactory(ObjectID.class)' instead of 'FactoryManagerService.getFactory(ObjectIDFactory.class)'.
> 2 - In the "org.apache.pluto.om.ControllerObjectAccess" class, to get a ControllerFactory instance, which may be used to create Controller instances, Pluto should call 'FactoryManagerService.getFactory(Controller.class)' instead of 'FactoryManagerService.getFactory(ControllerFactory.class)'.
> Regards.
> ZHENG Zhong

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (PLUTO-139) When calling FactoryManagerService.getFactory(), some arguments passed are not logic.

Posted by "ZHENG Zhong (JIRA)" <pl...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/PLUTO-139?page=all ]

ZHENG Zhong updated PLUTO-139:
------------------------------

    Attachment: FactoryManagerService.diff.txt

Updated 'portal/src/webapp/WEB-INF/config/services/FactoryManagerService.properties' so that the previous two patches will work property.
These three patches are tested under the current pluto source + Tomcat 5.5.9 + JDK 1.4.1.

Regards.
ZHENG Zhong

> When calling FactoryManagerService.getFactory(), some arguments passed are not logic.
> -------------------------------------------------------------------------------------
>
>          Key: PLUTO-139
>          URL: http://issues.apache.org/jira/browse/PLUTO-139
>      Project: Pluto
>         Type: Improvement
>   Components: portlet container
>     Versions: Current CVS
>     Reporter: ZHENG Zhong
>     Priority: Minor
>  Attachments: ControllerObjectAccess.diff.txt, FactoryManagerService.diff.txt, ObjectIDAccess.diff.txt
>
> The pluto container defines a set of Factory interfaces to create certain classes, such as classes in the "javax.portlet" package. In the FactoryManagerService interface, the following method is defined:
> public Factory getFactory(Class theClass);
> The method signature seems to mean that: get a factory instance that i can use to create the specified class (theClass). For example, pluto will call FactoryManagerService.getFactory(RenderRequest.class) to get a render request factory instance which may be used to create RenderRequest instances. Thus...
> 1- In the "org.apache.pluto.util.ObjectIDAccess" class,  to get an ObjectIDFactory instance, which may be used to create ObjectID instances, Pluto should call 'FactoryManagerService.getFactory(ObjectID.class)' instead of 'FactoryManagerService.getFactory(ObjectIDFactory.class)'.
> 2 - In the "org.apache.pluto.om.ControllerObjectAccess" class, to get a ControllerFactory instance, which may be used to create Controller instances, Pluto should call 'FactoryManagerService.getFactory(Controller.class)' instead of 'FactoryManagerService.getFactory(ControllerFactory.class)'.
> Regards.
> ZHENG Zhong

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira