You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Sangjin Lee (JIRA)" <ji...@apache.org> on 2008/02/05 20:47:08 UTC
[jira] Created: (DIRMINA-527) should be able to set connect timeout
in milliseconds
should be able to set connect timeout in milliseconds
-----------------------------------------------------
Key: DIRMINA-527
URL: https://issues.apache.org/jira/browse/DIRMINA-527
Project: MINA
Issue Type: Improvement
Components: Core
Affects Versions: 1.1.5, 1.0.8, 2.0.0-M1
Reporter: Sangjin Lee
Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-527) should be able to set connect
timeout in milliseconds
Posted by "Mark Webb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576850#action_12576850 ]
Mark Webb commented on DIRMINA-527:
-----------------------------------
I have applied the patch associated with this issue. I will go ahead and mark this issue as fixed.
> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
> Key: DIRMINA-527
> URL: https://issues.apache.org/jira/browse/DIRMINA-527
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
> Reporter: Sangjin Lee
> Assignee: Mark Webb
> Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-527) should be able to set connect
timeout in milliseconds
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577286#action_12577286 ]
Trustin Lee commented on DIRMINA-527:
-------------------------------------
Looks very good in its implementation!
However, I think the property name 'minimumConnectTimeout' doesn't represent what it is actually. What do you think about renaming it to connectTimeoutCheckInterval or something similar? Do you have any idea?
> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
> Key: DIRMINA-527
> URL: https://issues.apache.org/jira/browse/DIRMINA-527
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
> Reporter: Sangjin Lee
> Assignee: Mark Webb
> Fix For: 2.0.0-M2
>
> Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-527) should be able to set connect timeout
in milliseconds
Posted by "Sangjin Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sangjin Lee updated DIRMINA-527:
--------------------------------
Attachment: (was: DIRMINA-527.patch)
> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
> Key: DIRMINA-527
> URL: https://issues.apache.org/jira/browse/DIRMINA-527
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
> Reporter: Sangjin Lee
> Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-527) should be able to set connect
timeout in milliseconds
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577025#action_12577025 ]
Trustin Lee commented on DIRMINA-527:
-------------------------------------
For example, we could start from 1000ms selector timeout at the first time. If a user specifies a connect timeout value smaller than 1000ms, we can adjust the 1000ms to the connect timeout value specified (or its half). By doing so, we can minimize unnecessary CPU consumption, because most users will use the timeout value of 60 seconds or something similar to that. If a user wants a millisecond-level timeout (e.g. 9ms), then he will pay for what he or she wants, but it's not the case for most people.
> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
> Key: DIRMINA-527
> URL: https://issues.apache.org/jira/browse/DIRMINA-527
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
> Reporter: Sangjin Lee
> Assignee: Mark Webb
> Fix For: 2.0.0-M2
>
> Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-527) should be able to set connect
timeout in milliseconds
Posted by "Niklas Therning (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566465#action_12566465 ]
Niklas Therning commented on DIRMINA-527:
-----------------------------------------
The API for 1.0/1.1 has been frozen. Since this patch introduces changes in the API it should only go into trunk. Please, anyone, correct me if I'm wrong.
BTW, the patch looks great! One tiny detail, I think the coding conventions we're using in MINA mandates spaces around operators. E.g. 60*1000L => 60 * 1000L. See http://mina.apache.org/developer-guide.html#DeveloperGuide-CodingConvention for more info.
> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
> Key: DIRMINA-527
> URL: https://issues.apache.org/jira/browse/DIRMINA-527
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
> Reporter: Sangjin Lee
> Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-527) should be able to set connect
timeout in milliseconds
Posted by "Mark Webb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577287#action_12577287 ]
Mark Webb commented on DIRMINA-527:
-----------------------------------
Nothing is really jumping out to me on this one so your idea is fine with me.
> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
> Key: DIRMINA-527
> URL: https://issues.apache.org/jira/browse/DIRMINA-527
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
> Reporter: Sangjin Lee
> Assignee: Mark Webb
> Fix For: 2.0.0-M2
>
> Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRMINA-527) should be able to set connect timeout
in milliseconds
Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Vermillard closed DIRMINA-527.
-------------------------------------
> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
> Key: DIRMINA-527
> URL: https://issues.apache.org/jira/browse/DIRMINA-527
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
> Reporter: Sangjin Lee
> Assignee: Mark Webb
> Fix For: 2.0.0-M2
>
> Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-527) should be able to set connect timeout
in milliseconds
Posted by "Sangjin Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sangjin Lee updated DIRMINA-527:
--------------------------------
Attachment: DIRMINA-527.patch
> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
> Key: DIRMINA-527
> URL: https://issues.apache.org/jira/browse/DIRMINA-527
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
> Reporter: Sangjin Lee
> Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-527) should be able to set connect timeout
in milliseconds
Posted by "Sangjin Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sangjin Lee updated DIRMINA-527:
--------------------------------
Attachment: DIRMINA-527.patch
A proposed patch (based on the trunk).
- Introduces IoConnector.setConnectTimeoutMillis(), and deprecates getConnectTimeout()/setConnectTimeout().
- Adjust the select timeout to be the smaller of the connectTimeout() or 1 second.
Please review the changes, and accept them if you guys are OK with it. I'd also like to see the changes propagated to 1.1.x (and 1.0.x too?). Do we need separate JIRA issues for them?
Thanks,
Sangjin
> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
> Key: DIRMINA-527
> URL: https://issues.apache.org/jira/browse/DIRMINA-527
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
> Reporter: Sangjin Lee
> Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DIRMINA-527) should be able to set connect
timeout in milliseconds
Posted by "Mark Webb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Webb reassigned DIRMINA-527:
---------------------------------
Assignee: Mark Webb
> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
> Key: DIRMINA-527
> URL: https://issues.apache.org/jira/browse/DIRMINA-527
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
> Reporter: Sangjin Lee
> Assignee: Mark Webb
> Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-527) should be able to set connect
timeout in milliseconds
Posted by "Mark Webb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577284#action_12577284 ]
Mark Webb commented on DIRMINA-527:
-----------------------------------
I have checked in an update that makes the minimum timeout field configurable.
> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
> Key: DIRMINA-527
> URL: https://issues.apache.org/jira/browse/DIRMINA-527
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
> Reporter: Sangjin Lee
> Assignee: Mark Webb
> Fix For: 2.0.0-M2
>
> Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-527) should be able to set connect
timeout in milliseconds
Posted by "Mark Webb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576998#action_12576998 ]
Mark Webb commented on DIRMINA-527:
-----------------------------------
What is the purpose of the MINIMUM_CONNECT_TIMEOUT field? If it can be changed via a call to setConnectTimeoutMillis(long), then why have it? Trustin mentions in the TODO:
"Make this configurable and automatically adjusted if the timeout a user specified is smaller than the current minimum connect timeout."
So if the minimum connection timeout and connection timeout can both be configured, why not just have one field? The only way this makes sense to me is that if you try and set the connection timeout to be lower than the minimum we should throw an exception.
> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
> Key: DIRMINA-527
> URL: https://issues.apache.org/jira/browse/DIRMINA-527
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
> Reporter: Sangjin Lee
> Assignee: Mark Webb
> Fix For: 2.0.0-M2
>
> Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-527) should be able to set connect
timeout in milliseconds
Posted by "Sangjin Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566926#action_12566926 ]
Sangjin Lee commented on DIRMINA-527:
-------------------------------------
Hmm... Is there any hope for changes in 1.1.x? It would be adding new methods, not removing existing ones, so backward compatibility is there...
> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
> Key: DIRMINA-527
> URL: https://issues.apache.org/jira/browse/DIRMINA-527
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
> Reporter: Sangjin Lee
> Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-527) should be able to set connect
timeout in milliseconds
Posted by "Eero Nevalainen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566948#action_12566948 ]
Eero Nevalainen commented on DIRMINA-527:
-----------------------------------------
The ruling seems to be "no API changes whatsoever in 1.1.x". See https://issues.apache.org/jira/browse/DIRMINA-397?focusedCommentId=12517492#action_12517492 for a precedent :)
> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
> Key: DIRMINA-527
> URL: https://issues.apache.org/jira/browse/DIRMINA-527
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
> Reporter: Sangjin Lee
> Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRMINA-527) should be able to set connect
timeout in milliseconds
Posted by "Mark Webb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Webb resolved DIRMINA-527.
-------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0-M2
I applied the associated patch after reviewing the patch. This only adds to the precision of the timeout. The methods that dealt with getting and setting the connection timeout in seconds have been deprecated and a note in the javadoc says that the millisecond-based methods should be used.
> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
> Key: DIRMINA-527
> URL: https://issues.apache.org/jira/browse/DIRMINA-527
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
> Reporter: Sangjin Lee
> Assignee: Mark Webb
> Fix For: 2.0.0-M2
>
> Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (DIRMINA-527) should be able to set connect
timeout in milliseconds
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Trustin Lee reopened DIRMINA-527:
---------------------------------
We have a little bit more to do :)
http://mina.markmail.org/search/?q=connect%20timeout#query:connect%20timeout+page:1+mid:wp3ewpnfew7msthj+state:results
> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
> Key: DIRMINA-527
> URL: https://issues.apache.org/jira/browse/DIRMINA-527
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
> Reporter: Sangjin Lee
> Assignee: Mark Webb
> Fix For: 2.0.0-M2
>
> Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRMINA-527) should be able to set connect
timeout in milliseconds
Posted by "Mark Webb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Webb resolved DIRMINA-527.
-------------------------------
Resolution: Fixed
checked in an update that makes the minimum connection timeout field configurable
> should be able to set connect timeout in milliseconds
> -----------------------------------------------------
>
> Key: DIRMINA-527
> URL: https://issues.apache.org/jira/browse/DIRMINA-527
> Project: MINA
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.8, 1.1.5, 2.0.0-M1
> Reporter: Sangjin Lee
> Assignee: Mark Webb
> Fix For: 2.0.0-M2
>
> Attachments: DIRMINA-527.patch
>
>
> Currently, IoConnector allows setting connect timeouts only in seconds. The minimum value of allowed connect timeout is 1 second. There are cases where one needs to have a shorter connect timeout than 1 second and will finer granularity than seconds.
> I suggest introducing the ability to set connect timeout in milliseconds and deprecating the getter/setter in seconds in favor of the ms getter/setter.
> See the discussion thread at http://www.nabble.com/connect-timeout-to15281787s16868.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.