You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2017/11/30 14:43:22 UTC

[GitHub] mrutkows commented on a change in pull request #46: Add retry support to every request

mrutkows commented on a change in pull request #46: Add retry support to every request
URL: https://github.com/apache/incubator-openwhisk-client-go/pull/46#discussion_r154093145
 
 

 ##########
 File path: whisk/client.go
 ##########
 @@ -49,6 +50,8 @@ const (
     ExitWithErrorOnTimeout = true
     ExitWithSuccessOnTimeout = false
     DEFAULT_HTTP_TIMEOUT = 30
+    DEFAULT_ATTEMPTS = 5
+    DEFAULT_INTERVAL = 2 * time.Second
 
 Review comment:
   Curious, why you selected 2 secs? I have seen a progressive approach where waiting 1 sec. on first iteration, 2 seconds on 2nd iteration, 4 sec. on 3rd iteration, and so forth. Really, my hope is that the HTTP request turnaround/round-trip time itself allows for success on a subsequent call. Do we really need to wait 2 seconds in addition to that?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services