You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@celeborn.apache.org by "rmcyang (via GitHub)" <gi...@apache.org> on 2023/07/25 22:13:12 UTC

[GitHub] [incubator-celeborn] rmcyang commented on a diff in pull request #1761: [CELEBORN-838] Add custom mvn flag to celeborn

rmcyang commented on code in PR #1761:
URL: https://github.com/apache/incubator-celeborn/pull/1761#discussion_r1274170736


##########
build/make-distribution.sh:
##########
@@ -42,6 +43,10 @@ while (( "$#" )); do
       NAME="bin-$2"
       shift
       ;;
+    --mvn)

Review Comment:
   Would it better to add the usage for this flag to L33, similar to [what Spark does](https://github.com/apache/spark/blob/master/dev/make-distribution.sh#L46)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org