You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/06/07 09:57:16 UTC

[GitHub] [incubator-mxnet] bartekkuncer opened a new pull request, #21058: Differentiate default RNG seed

bartekkuncer opened a new pull request, #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058

   ## Description ##
   Fix fixed seed value for random number generators in MXNet (fixes https://github.com/apache/incubator-mxnet/issues/21053).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #21058: Diversify default RNG seed

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058#issuecomment-1160044768

   @mxnet-bot run ci [windows-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] bgawrych merged pull request #21058: Diversify default RNG seed

Posted by GitBox <gi...@apache.org>.
bgawrych merged PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #21058: Diversify default RNG seed

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058#issuecomment-1156323095

   @mxnet-bot run ci [unix-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #21058: Diversify default RNG seed

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058#issuecomment-1149574390

   @mxnet-bot run ci [unix-cpu, unix-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #21058: Diversify default RNG seed

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058#issuecomment-1156464362

   @mxnet-bot run ci [windows-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21058: Diversify default RNG seed

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058#issuecomment-1156464478

   Jenkins CI successfully triggered : [windows-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21058: Diversify default RNG seed

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058#issuecomment-1156323167

   Jenkins CI successfully triggered : [unix-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] anko-intel commented on pull request #21058: Diversify default RNG seed

Posted by GitBox <gi...@apache.org>.
anko-intel commented on PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058#issuecomment-1149628972

   > In numpy by default "random is random" and to have repeatable results one needs to explicitly set the seed. I believe we should have it in the same way as we are somewhat following numpy's design.
   
   So, we can allign to the NunPy  behaviour and make random seed as default.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21058: Diversify default RNG seed

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058#issuecomment-1149828791

   Jenkins CI successfully triggered : [unix-gpu, unix-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21058: Differentiate default RNG seed

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058#issuecomment-1148455612

   Hey @bartekkuncer , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [edge, clang, unix-cpu, miscellaneous, windows-gpu, windows-cpu, sanity, centos-cpu, unix-gpu, website, centos-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #21058: Diversify default RNG seed

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058#issuecomment-1152065175

   @mxnet-bot run ci [unix-cpu, unix-gpu]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #21058: Diversify default RNG seed

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058#issuecomment-1149572750

   > Someone may want to have repeatable results and I guess it was designed this way. So I am not sure if this change should applied.
   
   In other tools like numpy by default "random is random" and to have repeatable results one needs to explicitly set the seed. I believe we should have it in the same way as we are somewhat following numpy's design.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #21058: Diversify default RNG seed

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058#issuecomment-1149828682

   @mxnet-bot run ci [unix-cpu, unix-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #21058: Diversify default RNG seed

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058#issuecomment-1156052958

   @mxnet-bot run ci [unix-cpu, unix-gpu, windows-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21058: Diversify default RNG seed

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058#issuecomment-1149574452

   Jenkins CI successfully triggered : [unix-cpu, unix-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21058: Diversify default RNG seed

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058#issuecomment-1152065272

   Jenkins CI successfully triggered : [unix-cpu, unix-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21058: Diversify default RNG seed

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058#issuecomment-1160044811

   Jenkins CI successfully triggered : [windows-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21058: Diversify default RNG seed

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21058:
URL: https://github.com/apache/incubator-mxnet/pull/21058#issuecomment-1156053015

   Jenkins CI successfully triggered : [windows-gpu, unix-cpu, unix-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org