You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/13 10:15:16 UTC
[GitHub] [cloudstack] jbampton opened a new pull request, #6897: gha(python): fix `W391` blank line at end of file
jbampton opened a new pull request, #6897:
URL: https://github.com/apache/cloudstack/pull/6897
flake8 --select=W291,W292,W293,W391 .
./test/integration/smoke/test_register_userdata.py:766:1: W391 blank line at end of file
./test/integration/component/test_network_vpc_custom_dns.py:732:1: W391 blank line at end of file
### Description
This PR fixes the `flake8` test
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6897: gha(python): fix `W391` blank line at end of file
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6897:
URL: https://github.com/apache/cloudstack/pull/6897#issuecomment-1312699369
daring to go against principle on this one, only empty lines on end of files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] jbampton commented on pull request #6897: gha(python): fix `W391` blank line at end of file
Posted by GitBox <gi...@apache.org>.
jbampton commented on PR #6897:
URL: https://github.com/apache/cloudstack/pull/6897#issuecomment-1312697237
Yes I run `flake8` locally. But it runs with the GitHub Actions `SuperLinter Check` on modified files only on pull requests:
https://github.com/apache/cloudstack/actions/runs/3454836056/jobs/5766433087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6897: gha(python): fix `W391` blank line at end of file
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6897:
URL: https://github.com/apache/cloudstack/pull/6897#issuecomment-1312696400
@jbampton are you running these tests locally? they are not run in any of the travis jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6897: gha(python): fix `W391` blank line at end of file
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #6897:
URL: https://github.com/apache/cloudstack/pull/6897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] jbampton commented on pull request #6897: gha(python): fix `W391` blank line at end of file
Posted by GitBox <gi...@apache.org>.
jbampton commented on PR #6897:
URL: https://github.com/apache/cloudstack/pull/6897#issuecomment-1312698073
In future we could add `flake8` to `pre-commit` to allow everyone to run the tests locally on `git commit`.
There is another pull request where I was adding the first check with `pre-commit`.
refs #6273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org