[jira] [Commented] (RATIS-39) Avoid using google guava

["Mingliang Liu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924843#comment-15924843 ] 

Mingliang Liu commented on RATIS-39:
------------------------------------

+1 (again). Thanks for updating the patch.

> Avoid using google guava
> ------------------------
>
>                 Key: RATIS-39
>                 URL: https://issues.apache.org/jira/browse/RATIS-39
>             Project: Ratis
>          Issue Type: Improvement
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: r39_20170309.patch, r39_20170310.patch, r39_20170314.patch
>
>
> In order to allow user application using google guava, we should either not using it or shade it.
> Except for ratis-common, we can replace google guava by:
> - Preconditions: add similar methods in our util.  
> - VisibleForTesting: remove it.
> - ThreadFactoryBuilder: use Daemon::new
> - Charsets: use StandardCharsets
> - Lists, ImmutableList: use java collections
> - Throwables; just throw IOException



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)