You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "bvolpato (via GitHub)" <gi...@apache.org> on 2026/08/07 02:20:49 UTC
[PR] [Python] Deflake TextIO footer test [beam]
bvolpato opened a new pull request, #39668:
URL: https://github.com/apache/beam/pull/39668
Fixes #39639.
`TextSinkTest.test_write_pipeline_footer` let the runner choose its output shard count even though its assertions expect one trailing footer. Text sinks add the footer to every shard, so a multi-shard run leaves extra footer lines in the combined output.
Use one output shard for this test, matching the adjacent header test. Per-shard header and footer behavior remains covered by `test_write_max_bytes_per_shard`.
## Reproduction
Setting `num_shards=5` on current `master` reproduces the failure deterministically: four footer lines remain after the assertion removes the final footer.
## Testing
- Python 3.13 Gradle/tox targeted test
- 20 consecutive targeted test runs
- Related footer, header, max-records-per-shard, and max-bytes-per-shard tests
------------------------
- [x] Linked the issue with `Fixes #39639`.
- [x] No `CHANGES.md` entry needed for a test-only change.
- [x] Change is small and does not require an ICLA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Deflake TextIO footer test [beam]
Posted by "claudevdm (via GitHub)" <gi...@apache.org>.
claudevdm merged PR #39668:
URL: https://github.com/apache/beam/pull/39668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Deflake TextIO footer test [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39668:
URL: https://github.com/apache/beam/pull/39668#issuecomment-5212333587
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Deflake TextIO footer test [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39668:
URL: https://github.com/apache/beam/pull/39668#issuecomment-5247590647
Assigning reviewers:
R: @claudevdm for label python.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org