You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2023/12/01 12:18:13 UTC
[PR] GH-38857: [Python] Fix append mode for cython 2 [arrow]
jorisvandenbossche opened a new pull request, #39027:
URL: https://github.com/apache/arrow/pull/39027
### Rationale for this change
Small fixup of the change in https://github.com/apache/arrow/pull/38820 to fix the build failure on cython 2 (nightly crossbow build)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38857: [Python] Fix append mode for cython 2 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39027:
URL: https://github.com/apache/arrow/pull/39027#issuecomment-1837152239
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2bd8e06b4867acea3dc5479e991998672804e8ea.
There was 1 benchmark result indicating a performance regression:
- Commit Run on `ursa-i9-9960x` at [2023-12-01 21:27:52Z](https://conbench.ursa.dev/compare/runs/d538d7252a3346cbb036fc883028f358...d97bbfbce7b04af08272ff990360f6ac/)
- [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-07, scale_factor=1](https://conbench.ursa.dev/compare/benchmarks/0656a3b06ba6738b8000c519dec19048...0656a644b0797d628000d13c8e628e24)
The [full Conbench report](https://github.com/apache/arrow/runs/19247404877) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38857: [Python] Fix append mode for cython 2 [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche merged PR #39027:
URL: https://github.com/apache/arrow/pull/39027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38857: [Python] Fix append mode for cython 2 [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #39027:
URL: https://github.com/apache/arrow/pull/39027#issuecomment-1836029129
@github-actions crossbow submit test-conda-python-3.10-cython2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38857: [Python] Fix append mode for cython 2 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39027:
URL: https://github.com/apache/arrow/pull/39027#issuecomment-1836032501
Revision: 38e8a4eb3cb5c9ddef92dd38e30a1c20a66014d9
Submitted crossbow builds: [ursacomputing/crossbow @ actions-7f496d3260](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7f496d3260)
|Task|Status|
|----|------|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/7059923899/job/19218467899)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38857: [Python] Fix append mode for cython 2 [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #39027:
URL: https://github.com/apache/arrow/pull/39027#issuecomment-1836029055
The question is also whether we actually need to keep this cython 2 compatibility around for longer. I think we can probably also just start requiring cython >= 3 for building pyarrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org