You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by manishgupta88 <gi...@git.apache.org> on 2018/09/26 11:59:13 UTC

[GitHub] carbondata pull request #2758: [CARBONDATA-2972] Debug Logs and function add...

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2758#discussion_r220531471
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoder.java ---
    @@ -78,6 +78,13 @@ public DataType getTargetDataType(ColumnPage inputPage) {
         }
       }
     
    +  public Encoding getTypeOfEncoding() {
    +    if (CarbonUtil.isEncodedWithMeta(getEncodingList())) {
    +      return getEncodingList().get(0);
    --- End diff --
    
    1. `getEncodingList()` is called 2 times. Hold its value in one variable and use at both the places
    2. Change the method name from `getTypeOfEncoding()` to `getEncodingType()`


---