You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "soniagtm (via GitHub)" <gi...@apache.org> on 2023/10/09 01:08:18 UTC
[PR] [WIP] feat: add database and schema names to dataset option [superset]
soniagtm opened a new pull request, #25569:
URL: https://github.com/apache/superset/pull/25569
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR is created for adding database and schema names to the dataset option in the chart creation page and dashboard filter modal as described in Discussion: #25545.
The changes I have made will add database and schema names beneath each dataset name in the drop down list, as well as in the tooltip, so that users can identify the database and schema from which each dataset is created.
For datasets with a null schema name, the schema name in the tooltip label will be displayed as ‘Not defined’ instead.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
#### BEFORE<br>
_Chart creation page_
<br><img width="827" alt="before-chart" src="https://github.com/apache/superset/assets/96282005/5c8b6b88-87ef-47e9-be57-4da953300d7b"><br>
_Dashboard filter modal_
<br><img width="1453" alt="before-dashboard" src="https://github.com/apache/superset/assets/96282005/77fd1f3d-a855-4ae5-a40a-c763e6e7883f">
#### AFTER
_Chart creation page_
<br><img width="825" alt="after-chart" src="https://github.com/apache/superset/assets/96282005/77fbf264-e1e3-4e3c-97d7-ae3f5f84a7f3"><br>
_Dashboard filter modal_
<br><img width="1453" alt="after-dashboard" src="https://github.com/apache/superset/assets/96282005/e1674d5e-1b88-4597-9a35-6048edc28abf">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
To verify the changes made, please follow these steps:
**Chart Creation Page:**
(Assume that there exist some datasets that could be used to create a chart)
1. Go to the Charts tab and click the “+ CHART” button on the top right to navigate to the chart creation page.
2. Try choosing a dataset where you will find the database and schema names displayed below each dataset name.
3. Hover over each option to see the tooltip displaying the dataset name and its corresponding database and schema names.
**Dashboard Filter Modal:**
(Assume that there are some dashboards to which you can apply filters)
1. Go to the Dashboards tab and click on any dashboard to view it.
2. Expand the left panel and click "Add/Edit Filter," which will open the Add and edit filters modal.
3. Try selecting a dataset from the dropdown list, where you will find the database and schema names displayed below each dataset name.
4. Hover over each option to see the tooltip displaying the dataset name and its corresponding database and schema names.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [X] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #25569:
URL: https://github.com/apache/superset/pull/25569#issuecomment-1761784093
@soniagtm I verified that long database and schema names are truncated. Nice.
<img width="320" alt="Screenshot 2023-10-13 at 13 21 53" src="https://github.com/apache/superset/assets/70410625/400f73b5-11d7-45d8-bb5b-de3454440cc2">
We can improve the layout a little bit to use all the available space in some cases.
<img width="321" alt="Screenshot 2023-10-13 at 13 20 49" src="https://github.com/apache/superset/assets/70410625/48b8ae31-42af-4356-a715-dd3ee26e51ab">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #25569:
URL: https://github.com/apache/superset/pull/25569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #25569:
URL: https://github.com/apache/superset/pull/25569#issuecomment-1758157237
Another design option would be to replicate the database/schema UI elements we use in SQL Lab, etc. for consistency reasons, however it might be overkill, and/or a cumbersome UX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #25569:
URL: https://github.com/apache/superset/pull/25569#discussion_r1362621759
##########
superset-frontend/src/features/datasets/DatasetLabel/index.tsx:
##########
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { Tooltip } from 'src/components/Tooltip';
+import { styled, t } from '@superset-ui/core';
+
+type Database = {
+ database_name: string;
+};
+
+type Dataset = {
+ id: number;
+ table_name: string;
+ schema: string;
+ database: Database;
+};
+
+const TooltipContent = styled.div`
+ ${({ theme }) => `
+ .tooltip-header {
+ font-size: ${theme.typography.sizes.m}px;
+ font-weight: ${theme.typography.weights.bold};
+ }
+
+ .tooltip-description {
+ margin-top: ${theme.gridUnit * 2}px;
+ display: -webkit-box;
+ -webkit-line-clamp: 20;
+ -webkit-box-orient: vertical;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ }
+ `}
+`;
+
+const StyledLabelContainer = styled.div`
+ ${({ theme }) => `
+ left: ${theme.gridUnit * 3}px;
+ right: ${theme.gridUnit * 3}px;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ display: block;
+ `}
+`;
+
+const StyledLabel = styled.span`
+ ${({ theme }) => `
+ left: ${theme.gridUnit * 3}px;
+ right: ${theme.gridUnit * 3}px;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ display: block;
+ `}
+`;
+
+const StyledDetailWrapper = styled.div`
+ display: grid;
+ grid-template-columns: auto auto;
+ justify-content: start;
+ width: 100%;
+`;
+
+const StyledLabelDetail = styled.span`
+ ${({
+ theme: {
+ typography: { sizes, weights },
+ },
+ }) => `
+ overflow: hidden;
+ text-overflow: ellipsis;
+ font-size: ${sizes.s}px;
+ font-weight: ${weights.light};
+ line-height: 1.6;
+ `}
+`;
+
+export const DatasetLabel = (item: Dataset | Record<string, any>) => (
Review Comment:
Can you rename this to `DatasetSelectLabel`?
##########
superset-frontend/src/features/datasets/DatasetLabel/index.tsx:
##########
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { Tooltip } from 'src/components/Tooltip';
+import { styled, t } from '@superset-ui/core';
+
+type Database = {
+ database_name: string;
+};
+
+type Dataset = {
+ id: number;
+ table_name: string;
+ schema: string;
+ database: Database;
+};
+
+const TooltipContent = styled.div`
+ ${({ theme }) => `
+ .tooltip-header {
+ font-size: ${theme.typography.sizes.m}px;
+ font-weight: ${theme.typography.weights.bold};
+ }
+
+ .tooltip-description {
+ margin-top: ${theme.gridUnit * 2}px;
+ display: -webkit-box;
+ -webkit-line-clamp: 20;
+ -webkit-box-orient: vertical;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ }
+ `}
+`;
+
+const StyledLabelContainer = styled.div`
+ ${({ theme }) => `
+ left: ${theme.gridUnit * 3}px;
+ right: ${theme.gridUnit * 3}px;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ display: block;
+ `}
+`;
+
+const StyledLabel = styled.span`
+ ${({ theme }) => `
+ left: ${theme.gridUnit * 3}px;
+ right: ${theme.gridUnit * 3}px;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ display: block;
+ `}
+`;
+
+const StyledDetailWrapper = styled.div`
+ display: grid;
+ grid-template-columns: auto auto;
+ justify-content: start;
+ width: 100%;
+`;
+
+const StyledLabelDetail = styled.span`
+ ${({
+ theme: {
+ typography: { sizes, weights },
+ },
+ }) => `
+ overflow: hidden;
+ text-overflow: ellipsis;
+ font-size: ${sizes.s}px;
+ font-weight: ${weights.light};
+ line-height: 1.6;
+ `}
+`;
+
+export const DatasetLabel = (item: Dataset | Record<string, any>) => (
Review Comment:
We shouldn't accept `Record<string,any>`. It's the responsibility of the callers to convert internal structures to `Dataset`.
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/DatasetSelect.tsx:
##########
@@ -16,16 +16,27 @@
* specific language governing permissions and limitations
* under the License.
*/
-import React, { useCallback, useMemo } from 'react';
+import React, { useCallback, useMemo, ReactNode } from 'react';
import rison from 'rison';
-import { t } from '@superset-ui/core';
+import { t, JsonResponse } from '@superset-ui/core';
import { AsyncSelect } from 'src/components';
import {
ClientErrorObject,
getClientErrorObject,
} from 'src/utils/getClientErrorObject';
import { cachedSupersetGet } from 'src/utils/cachedSupersetGet';
-import { datasetToSelectOption } from './utils';
+import { DatasetLabel } from 'src/features/datasets/DatasetLabel';
+
+type Database = {
+ database_name: string;
+};
+
+type Dataset = {
Review Comment:
You can import these definitions from `src/features/datasets/DatasetLabel`.
##########
superset-frontend/src/pages/ChartCreation/index.tsx:
##########
@@ -42,12 +41,18 @@ import VizTypeGallery, {
import { findPermission } from 'src/utils/findPermission';
import { UserWithPermissionsAndRoles } from 'src/types/bootstrapTypes';
import getBootstrapData from 'src/utils/getBootstrapData';
+import { DatasetLabel } from 'src/features/datasets/DatasetLabel';
+
+type Database = {
+ database_name: string;
+};
type Dataset = {
id: number;
table_name: string;
- description: string;
datasource_type: string;
+ schema: string;
Review Comment:
I think you include `datasource_type` in the `Dataset` definition at `src/features/datasets/DatasetLabel` and import that here.
##########
superset-frontend/src/features/datasets/DatasetLabel/index.tsx:
##########
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { Tooltip } from 'src/components/Tooltip';
+import { styled, t } from '@superset-ui/core';
+
+type Database = {
+ database_name: string;
+};
+
+type Dataset = {
+ id: number;
+ table_name: string;
+ schema: string;
+ database: Database;
+};
+
+const TooltipContent = styled.div`
+ ${({ theme }) => `
+ .tooltip-header {
+ font-size: ${theme.typography.sizes.m}px;
+ font-weight: ${theme.typography.weights.bold};
+ }
+
+ .tooltip-description {
+ margin-top: ${theme.gridUnit * 2}px;
+ display: -webkit-box;
+ -webkit-line-clamp: 20;
+ -webkit-box-orient: vertical;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ }
+ `}
+`;
+
+const StyledLabelContainer = styled.div`
+ ${({ theme }) => `
+ left: ${theme.gridUnit * 3}px;
+ right: ${theme.gridUnit * 3}px;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ display: block;
+ `}
+`;
+
+const StyledLabel = styled.span`
+ ${({ theme }) => `
+ left: ${theme.gridUnit * 3}px;
+ right: ${theme.gridUnit * 3}px;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ display: block;
+ `}
+`;
+
+const StyledDetailWrapper = styled.div`
+ display: grid;
+ grid-template-columns: auto auto;
+ justify-content: start;
+ width: 100%;
+`;
+
+const StyledLabelDetail = styled.span`
+ ${({
+ theme: {
+ typography: { sizes, weights },
+ },
+ }) => `
+ overflow: hidden;
+ text-overflow: ellipsis;
+ font-size: ${sizes.s}px;
+ font-weight: ${weights.light};
+ line-height: 1.6;
+ `}
+`;
+
+export const DatasetLabel = (item: Dataset | Record<string, any>) => (
+ <Tooltip
+ mouseEnterDelay={0.2}
+ placement="right"
+ title={
+ <TooltipContent>
+ <div className="tooltip-header">{item.table_name}</div>
+ <div className="tooltip-description">
+ <div>
+ {t('Database')}: {item.database.database_name}
+ </div>
+ <div>
+ {t('Schema')}:{' '}
+ {item.schema &&
+ !['null', 'none'].includes(item.schema.toLowerCase())
Review Comment:
Could extract `['null', 'none'].includes(item.schema.toLowerCase())` to a function such as `hasSchema` and reuse it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "kasiazjc (via GitHub)" <gi...@apache.org>.
kasiazjc commented on PR #25569:
URL: https://github.com/apache/superset/pull/25569#issuecomment-1758018077
amazing @soniagtm and congrats on your first PR!
@soniagtm I have some feedback about the metadata in the dropdown (schema and database) - I think it's 14px, can you change it to 12px? This way it all will be less cluttered and we'll get back a little bit of the precious real estate @rusackas :D
For the context, @rusackas: Details in the dropdown solve a problem of quickly identifying which dataset is the one you're looking for (there are use cases of datasets with the same name, or users are just not familiar with them) or where does it come from, what is the context. That's why the request/solution was to make those details visible at all times. Also, this field is searchable, so it shouldn't be a problem with super long list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #25569:
URL: https://github.com/apache/superset/pull/25569#issuecomment-1771475612
Echoing everyone here, thank you for this submission and all the effort that went into it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #25569:
URL: https://github.com/apache/superset/pull/25569#issuecomment-1761702767
One more UI issue. The labels are displayed partially after you select them.
<img width="664" alt="Screenshot 2023-10-13 at 11 23 45 AM" src="https://github.com/apache/superset/assets/1392866/7c5d5f2f-3fec-497e-aaac-7d1eef585cf6">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on code in PR #25569:
URL: https://github.com/apache/superset/pull/25569#discussion_r1358389296
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/DatasetLabel.tsx:
##########
@@ -0,0 +1,116 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { Tooltip } from 'src/components/Tooltip';
+import { styled } from '@superset-ui/core';
+
+type Database = {
+ database_name: string;
+};
+
+type Dataset = {
+ id: number;
+ table_name: string;
+ schema: string;
+ database: Database;
+};
+
+const TooltipContent = styled.div`
+ ${({ theme }) => `
+ .tooltip-header {
+ font-size: ${theme.typography.sizes.m}px;
+ font-weight: ${theme.typography.weights.bold};
+ }
+
+ .tooltip-description {
+ margin-top: ${theme.gridUnit * 2}px;
+ display: -webkit-box;
+ -webkit-line-clamp: 20;
+ -webkit-box-orient: vertical;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ }
+ `}
+`;
+
+const StyledLabel = styled.span`
+ ${({ theme }) => `
+ left: ${theme.gridUnit * 3}px;
+ right: ${theme.gridUnit * 3}px;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ display: block;
+ `}
+`;
+
+const StyledLabelDetail = styled.span`
+ ${({
+ theme: {
+ typography: { sizes, weights },
+ },
+ }) => `
+ overflow: hidden;
+ display: inline-block;
+ text-overflow: ellipsis;
+ font-size: ${sizes.s}px;
+ font-weight: ${weights.light};
+ max-width: 50%;
+ line-height: 1.4;
+ `}
+`;
+
+const StyledLabelContainer = styled.div`
+ ${({ theme }) => `
+ left: ${theme.gridUnit * 3}px;
+ right: ${theme.gridUnit * 3}px;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ display: block;
+ `}
+`;
+
+export const newLabel = (item: Dataset | Record<string, any>) => (
+ <Tooltip
+ mouseEnterDelay={1}
Review Comment:
1s seems too slow to verify the truncated longer datasource name.
let's reduce < 0.3 for the convenience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "soniagtm (via GitHub)" <gi...@apache.org>.
soniagtm commented on code in PR #25569:
URL: https://github.com/apache/superset/pull/25569#discussion_r1360249602
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/DatasetLabel.tsx:
##########
@@ -0,0 +1,116 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { Tooltip } from 'src/components/Tooltip';
+import { styled } from '@superset-ui/core';
+
+type Database = {
+ database_name: string;
+};
+
+type Dataset = {
+ id: number;
+ table_name: string;
+ schema: string;
+ database: Database;
+};
+
+const TooltipContent = styled.div`
+ ${({ theme }) => `
+ .tooltip-header {
+ font-size: ${theme.typography.sizes.m}px;
+ font-weight: ${theme.typography.weights.bold};
+ }
+
+ .tooltip-description {
+ margin-top: ${theme.gridUnit * 2}px;
+ display: -webkit-box;
+ -webkit-line-clamp: 20;
+ -webkit-box-orient: vertical;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ }
+ `}
+`;
+
+const StyledLabel = styled.span`
+ ${({ theme }) => `
+ left: ${theme.gridUnit * 3}px;
+ right: ${theme.gridUnit * 3}px;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ display: block;
+ `}
+`;
+
+const StyledLabelDetail = styled.span`
+ ${({
+ theme: {
+ typography: { sizes, weights },
+ },
+ }) => `
+ overflow: hidden;
+ display: inline-block;
+ text-overflow: ellipsis;
+ font-size: ${sizes.s}px;
+ font-weight: ${weights.light};
+ max-width: 50%;
+ line-height: 1.4;
+ `}
+`;
+
+const StyledLabelContainer = styled.div`
+ ${({ theme }) => `
+ left: ${theme.gridUnit * 3}px;
+ right: ${theme.gridUnit * 3}px;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ display: block;
+ `}
+`;
+
+export const newLabel = (item: Dataset | Record<string, any>) => (
+ <Tooltip
+ mouseEnterDelay={1}
Review Comment:
Changed to 0.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "kasiazjc (via GitHub)" <gi...@apache.org>.
kasiazjc commented on PR #25569:
URL: https://github.com/apache/superset/pull/25569#issuecomment-1761796511
> One more UI issue. The labels are displayed partially after you select them.
>
> <img alt="Screenshot 2023-10-13 at 11 23 45 AM" width="664" src="https://user-images.githubusercontent.com/1392866/274944161-7c5d5f2f-3fec-497e-aaac-7d1eef585cf6.png">
Oh, good catch, thank you! From what we have defined in the design system - the metadata should not be displayed in the field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "kasiazjc (via GitHub)" <gi...@apache.org>.
kasiazjc commented on PR #25569:
URL: https://github.com/apache/superset/pull/25569#issuecomment-1759614242
> Another design option would be to replicate the database/schema UI elements we use in SQL Lab, etc. for consistency reasons, however it might be overkill, and/or a cumbersome UX.
Yeah, I think it would be too much - we are actually thinking about using this pattern with metadata in the dropdown in other places, so for sure it wouldn't be a one time thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "soniagtm (via GitHub)" <gi...@apache.org>.
soniagtm commented on PR #25569:
URL: https://github.com/apache/superset/pull/25569#issuecomment-1763944743
I've moved the dataset label implementation to src/features/datasets as suggested and also fixed the UI issues found.
#### BEFORE
> One more UI issue. The labels are displayed partially after you select them.
>
> <img alt="Screenshot 2023-10-13 at 11 23 45 AM" width="664" src="https://user-images.githubusercontent.com/1392866/274944161-7c5d5f2f-3fec-497e-aaac-7d1eef585cf6.png">
#### AFTER
<img width="334" alt="Screenshot 2566-10-16 at 10 00 45" src="https://github.com/apache/superset/assets/96282005/019fa16b-6e77-4059-b4cf-75e289a1b881">
<br>
---
#### BEFORE
> @soniagtm I verified that long database and schema names are truncated. Nice.
>
> <img alt="Screenshot 2023-10-13 at 13 21 53" width="320" src="https://user-images.githubusercontent.com/70410625/274957909-400f73b5-11d7-45d8-bb5b-de3454440cc2.png">
> We can improve the layout a little bit to use all the available space in some cases.
>
> <img alt="Screenshot 2023-10-13 at 13 20 49" width="321" src="https://user-images.githubusercontent.com/70410625/274958166-48b8ae31-42af-4356-a715-dd3ee26e51ab.png">
#### AFTER
<img width="562" alt="Screenshot 2566-10-16 at 10 05 38" src="https://github.com/apache/superset/assets/96282005/d6475e3a-fdeb-49a9-b8b6-9ae517a8d70e"><br><br>
Please let me know if there are any issues or if any adjustments are needed.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "kasiazjc (via GitHub)" <gi...@apache.org>.
kasiazjc commented on PR #25569:
URL: https://github.com/apache/superset/pull/25569#issuecomment-1759877715
> Thanks to all of you for your feedback. I've reduced the font size as suggested, and also attached some screenshots to show how it looks now. Please have a look and let me know if there are any further improvements or adjustments needed :)
>
> **_Chart creation page_** <img alt="Screenshot 2566-10-12 at 21 21 17" width="1023" src="https://user-images.githubusercontent.com/96282005/274631311-232c3b5b-051d-4f2e-966b-4058d988efde.png"> **_Dashboard filter modal_** <img alt="Screenshot 2566-10-12 at 21 23 27" width="1630" src="https://user-images.githubusercontent.com/96282005/274631339-d9be8c29-d948-49ad-bef9-0f9dc0f9e34d.png">
This looks good to me! Thank you for all the changes :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "soniagtm (via GitHub)" <gi...@apache.org>.
soniagtm commented on PR #25569:
URL: https://github.com/apache/superset/pull/25569#issuecomment-1759754248
Thanks to all of you for your feedback. I've reduced the font size as suggested, and also attached some screenshots to show how it looks now. Please have a look and let me know if there are any further improvements or adjustments needed :)
**_Chart creation page_**
<img width="1023" alt="Screenshot 2566-10-12 at 21 21 17" src="https://github.com/apache/superset/assets/96282005/232c3b5b-051d-4f2e-966b-4058d988efde">
<br>
**_Dashboard filter modal_**
<img width="1630" alt="Screenshot 2566-10-12 at 21 23 27" src="https://github.com/apache/superset/assets/96282005/d9be8c29-d948-49ad-bef9-0f9dc0f9e34d">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on code in PR #25569:
URL: https://github.com/apache/superset/pull/25569#discussion_r1358282309
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/DatasetLabel.tsx:
##########
@@ -0,0 +1,116 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { Tooltip } from 'src/components/Tooltip';
+import { styled } from '@superset-ui/core';
+
+type Database = {
+ database_name: string;
+};
+
+type Dataset = {
+ id: number;
+ table_name: string;
+ schema: string;
+ database: Database;
+};
+
+const TooltipContent = styled.div`
+ ${({ theme }) => `
+ .tooltip-header {
+ font-size: ${theme.typography.sizes.m}px;
+ font-weight: ${theme.typography.weights.bold};
+ }
+
+ .tooltip-description {
+ margin-top: ${theme.gridUnit * 2}px;
+ display: -webkit-box;
+ -webkit-line-clamp: 20;
+ -webkit-box-orient: vertical;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ }
+ `}
+`;
+
+const StyledLabel = styled.span`
+ ${({ theme }) => `
+ left: ${theme.gridUnit * 3}px;
+ right: ${theme.gridUnit * 3}px;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ display: block;
+ `}
+`;
+
+const StyledLabelDetail = styled.span`
+ ${({
+ theme: {
+ typography: { sizes, weights },
+ },
+ }) => `
+ overflow: hidden;
+ display: inline-block;
+ text-overflow: ellipsis;
+ font-size: ${sizes.s}px;
+ font-weight: ${weights.light};
+ max-width: 50%;
+ line-height: 1.4;
+ `}
+`;
+
+const StyledLabelContainer = styled.div`
+ ${({ theme }) => `
+ left: ${theme.gridUnit * 3}px;
+ right: ${theme.gridUnit * 3}px;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ display: block;
+ `}
+`;
+
+export const newLabel = (item: Dataset | Record<string, any>) => (
+ <Tooltip
+ mouseEnterDelay={1}
+ placement="right"
+ title={
+ <TooltipContent>
+ <div className="tooltip-header">{item.table_name}</div>
+ <div className="tooltip-description">
+ <div>Database: {item.database.database_name}</div>
Review Comment:
```suggestion
<div>{t('Database')}: {item.database.database_name}</div>
```
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/DatasetLabel.tsx:
##########
@@ -0,0 +1,116 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { Tooltip } from 'src/components/Tooltip';
+import { styled } from '@superset-ui/core';
+
+type Database = {
+ database_name: string;
+};
+
+type Dataset = {
+ id: number;
+ table_name: string;
+ schema: string;
+ database: Database;
+};
+
+const TooltipContent = styled.div`
+ ${({ theme }) => `
+ .tooltip-header {
+ font-size: ${theme.typography.sizes.m}px;
+ font-weight: ${theme.typography.weights.bold};
+ }
+
+ .tooltip-description {
+ margin-top: ${theme.gridUnit * 2}px;
+ display: -webkit-box;
+ -webkit-line-clamp: 20;
+ -webkit-box-orient: vertical;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ }
+ `}
+`;
+
+const StyledLabel = styled.span`
+ ${({ theme }) => `
+ left: ${theme.gridUnit * 3}px;
+ right: ${theme.gridUnit * 3}px;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ display: block;
+ `}
+`;
+
+const StyledLabelDetail = styled.span`
+ ${({
+ theme: {
+ typography: { sizes, weights },
+ },
+ }) => `
+ overflow: hidden;
+ display: inline-block;
+ text-overflow: ellipsis;
+ font-size: ${sizes.s}px;
+ font-weight: ${weights.light};
+ max-width: 50%;
+ line-height: 1.4;
+ `}
+`;
+
+const StyledLabelContainer = styled.div`
+ ${({ theme }) => `
+ left: ${theme.gridUnit * 3}px;
+ right: ${theme.gridUnit * 3}px;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ display: block;
+ `}
+`;
+
+export const newLabel = (item: Dataset | Record<string, any>) => (
+ <Tooltip
+ mouseEnterDelay={1}
+ placement="right"
+ title={
+ <TooltipContent>
+ <div className="tooltip-header">{item.table_name}</div>
+ <div className="tooltip-description">
+ <div>Database: {item.database.database_name}</div>
+ <div>
+ Schema:{' '}
+ {item.schema &&
+ !['null', 'none'].includes(item.schema.toLowerCase())
+ ? item.schema
+ : 'Not defined'}
Review Comment:
```suggestion
: t('Not defined')}
```
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/DatasetLabel.tsx:
##########
@@ -0,0 +1,116 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { Tooltip } from 'src/components/Tooltip';
+import { styled } from '@superset-ui/core';
+
+type Database = {
+ database_name: string;
+};
+
+type Dataset = {
+ id: number;
+ table_name: string;
+ schema: string;
+ database: Database;
+};
+
+const TooltipContent = styled.div`
+ ${({ theme }) => `
+ .tooltip-header {
+ font-size: ${theme.typography.sizes.m}px;
+ font-weight: ${theme.typography.weights.bold};
+ }
+
+ .tooltip-description {
+ margin-top: ${theme.gridUnit * 2}px;
+ display: -webkit-box;
+ -webkit-line-clamp: 20;
+ -webkit-box-orient: vertical;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ }
+ `}
+`;
+
+const StyledLabel = styled.span`
+ ${({ theme }) => `
+ left: ${theme.gridUnit * 3}px;
+ right: ${theme.gridUnit * 3}px;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ display: block;
+ `}
+`;
+
+const StyledLabelDetail = styled.span`
+ ${({
+ theme: {
+ typography: { sizes, weights },
+ },
+ }) => `
+ overflow: hidden;
+ display: inline-block;
+ text-overflow: ellipsis;
+ font-size: ${sizes.s}px;
+ font-weight: ${weights.light};
+ max-width: 50%;
+ line-height: 1.4;
+ `}
+`;
+
+const StyledLabelContainer = styled.div`
+ ${({ theme }) => `
+ left: ${theme.gridUnit * 3}px;
+ right: ${theme.gridUnit * 3}px;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ display: block;
+ `}
+`;
+
+export const newLabel = (item: Dataset | Record<string, any>) => (
+ <Tooltip
+ mouseEnterDelay={1}
+ placement="right"
+ title={
+ <TooltipContent>
+ <div className="tooltip-header">{item.table_name}</div>
+ <div className="tooltip-description">
+ <div>Database: {item.database.database_name}</div>
+ <div>
+ Schema:{' '}
Review Comment:
```suggestion
{t('Schema')}:{' '}
```
##########
superset-frontend/src/pages/ChartCreation/index.tsx:
##########
@@ -299,22 +327,44 @@ export class ChartCreation extends React.PureComponent<
mouseEnterDelay={1}
Review Comment:
why don't use `import { newLabel } from 'src/dashboard/components/nativeFilters/DatasetLabel` ?
How about create a separate component for newLabel btw?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #25569:
URL: https://github.com/apache/superset/pull/25569#issuecomment-1761807267
> Oh, good catch, thank you! From what we have defined in the design system - the metadata should not be displayed in the field
We'll need to augment the `Select` component to support this as currently there's no distinction between the label that is displayed in the dropdown and the label that is displayed in the input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "soniagtm (via GitHub)" <gi...@apache.org>.
soniagtm commented on PR #25569:
URL: https://github.com/apache/superset/pull/25569#issuecomment-1771474210
Thank you for your kind words and for helping me with my first PR! I'm really grateful for all the suggestions :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #25569:
URL: https://github.com/apache/superset/pull/25569#discussion_r1362619245
##########
superset-frontend/src/pages/ChartCreation/index.tsx:
##########
@@ -42,12 +41,18 @@ import VizTypeGallery, {
import { findPermission } from 'src/utils/findPermission';
import { UserWithPermissionsAndRoles } from 'src/types/bootstrapTypes';
import getBootstrapData from 'src/utils/getBootstrapData';
+import { DatasetLabel } from 'src/features/datasets/DatasetLabel';
+
+type Database = {
+ database_name: string;
+};
type Dataset = {
id: number;
table_name: string;
- description: string;
datasource_type: string;
+ schema: string;
Review Comment:
I think you can include `datasource_type` in the `Dataset` definition at `src/features/datasets/DatasetLabel` and import that here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: add database and schema names to dataset option [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #25569:
URL: https://github.com/apache/superset/pull/25569#issuecomment-1756210294
Thanks for the PR! I'm curious what others (especially @kasiazjc) think about this. In particular, I'm wondering about users that have a whole lot of datasets. Adding the table/schema in the tooltip is AMAZING and (I think) uncontroversial. What I'm not sure about is if the table and schema are needed in the menu option listings, since they take up more vertical real estate, and will require more scrolling if the list is long. The tooltip seems sufficient to me, but I'm not sure ¯\_(ツ)_/¯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org