You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by je...@ci.trafficserver.apache.org on 2017/05/11 17:53:19 UTC

Build failed in Jenkins: clang-format-master #1505

See <https://ci.trafficserver.apache.org/job/clang-format-master/1505/display/redirect?page=changes>

Changes:

[vijayabhaskar_mamidi] coverity 1021720,1021721,1254795,1021722: ESI plugin

[vijayabhaskar_mamidi] Coverity 1216302,1022033,1022032,1022031: State While Revalidate

[Bryan Call] coverity 1356981: Uninitialized scalar field

[Bryan Call] Coverity 1021694: Uninitialized pointer field

[Bryan Call] coverity 1022121 : remove check

[Phil Sorber] Fix slow leak in traffic_manager caused by un-freed capabilities.

------------------------------------------
[...truncated 57.66 KB...]
./proxy/Show.h
./proxy/logstats.cc
./proxy/StatPages.h
./proxy/TimeTrace.h
./proxy/TestPreProc.cc
./proxy/Crash.cc
./proxy/PluginVC.h
./proxy/shared/DiagsConfig.h
./proxy/shared/UglyLogStubs.cc
./proxy/shared/DiagsConfig.cc
./proxy/IPAllow.h
./proxy/InkAPITest.cc
./proxy/InkAPIInternal.h
./proxy/ParentRoundRobin.h
./proxy/UnixCompletionUtil.h
./proxy/ProtocolProbeSessionAccept.cc
./proxy/ReverseProxy.cc
./proxy/TransformInternal.h
./proxy/RegressionSM.h
./proxy/UDPAPITest.cc
./proxy/EventName.cc
./proxy/SocksProxy.cc
./proxy/api/ts/remap.h
./proxy/api/ts/experimental.h
./proxy/api/ts/InkAPIPrivateIOCore.h
./proxy/api/ts/ts.h
./proxy/api/ts/TsException.h
./proxy/EventName.h
./proxy/Plugin.cc
./proxy/StufferUdpReceiver.cc
./proxy/TestPreProc.h
./proxy/Main.h
./proxy/TestSimpleProxy.cc
./proxy/logcat.cc
./proxy/InkAPITestTool.cc
./proxy/PluginVC.cc
./proxy/ControlMatcher.cc
./proxy/CacheControl.cc
./proxy/TestDNS.cc
./proxy/logging/LogHost.cc
./proxy/logging/LogFormat.cc
./proxy/logging/LogAccessHttp.h
./proxy/logging/LogObject.cc
./proxy/logging/LogHost.h
./proxy/logging/LogStandalone.cc
./proxy/logging/LogBindings.h
./proxy/logging/test_LogUtils.cc
./proxy/logging/LogCollationBase.h
./proxy/logging/LogBuffer.h
./proxy/logging/LogUtils.h
./proxy/logging/LogFilter.h
./proxy/logging/LogAccessHttp.cc
./proxy/logging/LogFilter.cc
./proxy/logging/LogCollationClientSM.cc
./proxy/logging/Log.cc
./proxy/logging/LogLimits.h
./proxy/logging/LogCollationHostSM.cc
./proxy/logging/LogBuffer.cc
./proxy/logging/LogBindings.cc
./proxy/logging/LogUtils.cc
./proxy/logging/LogAccess.cc
./proxy/logging/LogAccessTest.cc
./proxy/logging/LogCollationClientSM.h
./proxy/logging/LogObject.h
./proxy/logging/LogCollationHostSM.h
./proxy/logging/LogConfig.cc
./proxy/logging/LogSock.h
./proxy/logging/LogFieldAliasMap.h
./proxy/logging/LogFieldAliasMap.cc
./proxy/logging/LogCollationAccept.h
./proxy/logging/LogFile.h
./proxy/logging/LogCollationAccept.cc
./proxy/logging/LogAccess.h
./proxy/logging/LogFile.cc
./proxy/logging/LogConfig.h
./proxy/logging/Log.h
./proxy/logging/LogFormat.h
./proxy/logging/LogBufferSink.h
./proxy/logging/LogField.h
./proxy/logging/LogField.cc
./proxy/logging/LogAccessTest.h
./proxy/logging/LogSock.cc
./proxy/ParentRoundRobin.cc
./proxy/Transform.cc
./proxy/Prefetch.h
./proxy/ParentConsistentHash.cc
./proxy/InkAPI.cc
./proxy/TestClock.cc
./proxy/congest/CongestionStats.cc
./proxy/congest/CongestionStats.h
./proxy/congest/CongestionDB.cc
./proxy/congest/CongestionTest.cc
./proxy/congest/Congestion.cc
./proxy/congest/CongestionDB.h
./proxy/congest/MT_hashtable.h
./proxy/congest/Congestion.h
./proxy/CoreUtils.h
./proxy/CacheControl.h
./proxy/InkIOCoreAPI.cc
./proxy/FetchSM.cc
./proxy/CoreUtils.cc
./proxy/ControlBase.h
./proxy/CompletionUtil.h
./proxy/hdrs/HdrToken.h
./proxy/hdrs/HdrHeap.h
./proxy/hdrs/HdrToken.cc
./proxy/hdrs/HttpCompat.cc
./proxy/hdrs/HdrTest.cc
./proxy/hdrs/HdrUtils.h
./proxy/hdrs/HttpCompat.h
./proxy/hdrs/test_urlhash.cc
./proxy/hdrs/HdrTSOnly.cc
./proxy/hdrs/load_http_hdr.cc
./proxy/hdrs/HdrHeap.cc
./proxy/hdrs/HTTP.h
./proxy/hdrs/HdrUtils.cc
./proxy/hdrs/HdrTest.h
./proxy/hdrs/MIME.cc
./proxy/hdrs/HTTP.cc
./proxy/hdrs/URL.cc
./proxy/hdrs/test_mime.cc
./proxy/hdrs/URL.h
./proxy/hdrs/MIME.h
./proxy/ProxyClientTransaction.h
./proxy/Transform.h
./proxy/http/HttpCacheSM.h
./proxy/http/Http1ClientTransaction.cc
./proxy/http/HttpProxyServerMain.cc
./proxy/http/HttpTransactHeaders.h
./proxy/http/HttpTunnel.h
./proxy/http/HttpDebugNames.cc
./proxy/http/HttpSessionManager.cc
./proxy/http/HttpProxyAPIEnums.h
./proxy/http/HttpCacheSM.cc
./proxy/http/HttpConfig.h
./proxy/http/HttpDebugNames.h
./proxy/http/HttpSessionAccept.cc
./proxy/http/HttpSessionAccept.h
./proxy/http/HttpSessionManager.h
./proxy/http/Http1ClientSession.cc
./proxy/http/HttpConnectionCount.h
./proxy/http/HttpUpdateTester.cc
./proxy/http/remap/UrlMappingPathIndex.cc
./proxy/http/remap/RemapPlugins.cc
./proxy/http/remap/UrlMapping.cc
./proxy/http/remap/RemapProcessor.h
./proxy/http/remap/AclFiltering.cc
./proxy/http/remap/UrlRewrite.h
./proxy/http/remap/RemapPluginInfo.cc
./proxy/http/remap/RemapConfig.cc
./proxy/http/remap/RemapConfig.h
./proxy/http/remap/AclFiltering.h
./proxy/http/remap/RemapPlugins.h
./proxy/http/remap/UrlMapping.h
./proxy/http/remap/UrlRewrite.cc
./proxy/http/remap/UrlMappingPathIndex.h
./proxy/http/remap/RemapProcessor.cc
./proxy/http/remap/RemapPluginInfo.h
./proxy/http/HttpTransact.h
./proxy/http/HttpUpdateSM.cc
./proxy/http/HttpUpdateSM.h
./proxy/http/HttpProxyServerMain.h
./proxy/http/HttpTransact.cc
./proxy/http/HttpTransactHeaders.cc
./proxy/http/HttpTransactCache.h
./proxy/http/testheaders.cc
./proxy/http/HttpSM.h
./proxy/http/HttpConnectionCount.cc
./proxy/http/HttpConfig.cc
./proxy/http/TestUrl.cc
./proxy/http/HttpTransactCache.cc
./proxy/http/HttpBodyFactory.cc
./proxy/http/HttpPages.h
./proxy/http/HttpSM.cc
./proxy/http/Http1ClientSession.h
./proxy/http/HttpServerSession.h
./proxy/http/HttpTunnel.cc
./proxy/http/HttpPages.cc
./proxy/http/Http1ClientTransaction.h
./proxy/http/test_socket_close.cc
./proxy/http/HttpServerSession.cc
./proxy/http/RegressionHttpTransact.cc
./proxy/http/HttpBodyFactory.h
./proxy/ProxyClientSession.h
./proxy/ProxyClientTransaction.cc
./proxy/ReverseProxy.h
./proxy/Milestones.h
./proxy/Plugin.h
./proxy/Prefetch.cc
./proxy/FetchSM.h
./proxy/http2/RegressionHPACK.cc
./proxy/http2/HTTP2.h
./proxy/http2/Http2ConnectionState.cc
./proxy/http2/HPACK.h
./proxy/http2/Http2ClientSession.cc
./proxy/http2/HuffmanCodec.h
./proxy/http2/HTTP2.cc
./proxy/http2/Http2DebugNames.h
./proxy/http2/Http2Stream.h
./proxy/http2/Http2DependencyTree.h
./proxy/http2/Http2DebugNames.cc
./proxy/http2/test_Http2DependencyTree.cc
./proxy/http2/Http2ConnectionState.h
./proxy/http2/HPACK.cc
./proxy/http2/Http2SessionAccept.h
./proxy/http2/Http2Stream.cc
./proxy/http2/test_Huffmancode.cc
./proxy/http2/HuffmanCodec.cc
./proxy/http2/test_HPACK.cc
./proxy/http2/Http2SessionAccept.cc
./proxy/http2/Http2ClientSession.h
./tools/http_load/port.h
./tools/http_load/timers.c
./tools/http_load/http_load.c
./tools/http_load/timers.h
./tools/jtest/jtest.cc
diff --git a/plugins/experimental/stale_while_revalidate/stale_while_revalidate.c b/plugins/experimental/stale_while_revalidate/stale_while_revalidate.c
index 05301dd..2e6783e 100644
--- a/plugins/experimental/stale_while_revalidate/stale_while_revalidate.c
+++ b/plugins/experimental/stale_while_revalidate/stale_while_revalidate.c
@@ -381,7 +381,7 @@ consume_resource(TSCont cont, TSEvent event ATS_UNUSED, void *edata ATS_UNUSED)
           TSHttpTxnNewCacheLookupDo(state->txn, state->req_info->buf, url_loc);
           TSHandleMLocRelease(state->req_info->buf, state->req_info->http_hdr_loc, url_loc);
         } else {
-          TSError("[%s] Error getting the URL from the transaction",PLUGIN_NAME);
+          TSError("[%s] Error getting the URL from the transaction", PLUGIN_NAME);
         }
         // TODO add txn translation hook and pass result along, maybe inside continuation?
         // TSHttpTxnHookAdd(state->txn, TS_HTTP_RESPONSE_TRANSFORM_HOOK, TSTransformCreate(replace_transform, state->txn));
@@ -399,7 +399,7 @@ consume_resource(TSCont cont, TSEvent event ATS_UNUSED, void *edata ATS_UNUSED)
     TSContDestroy(cont);
     break;
   default:
-    TSError("[%s] Unknown event %d.", PLUGIN_NAME,event);
+    TSError("[%s] Unknown event %d.", PLUGIN_NAME, event);
     break;
   }
 
@@ -749,7 +749,7 @@ TSPluginInit(int argc, const char *argv[])
     if (plugin_config->log_info.all || plugin_config->log_info.stale_while_revalidate || plugin_config->log_info.stale_if_error) {
       if (TSTextLogObjectCreate(plugin_config->log_info.filename, TS_LOG_MODE_ADD_TIMESTAMP, &(plugin_config->log_info.object)) !=
           TS_SUCCESS) {
-        TSError("[%s] Error getting the URL from the transaction",PLUGIN_NAME);
+        TSError("[%s] Error getting the URL from the transaction", PLUGIN_NAME);
         return;
       }
     }
Build step 'Execute shell' marked build as failure
Not sending mail to unregistered user vijayabhaskar_mamidi@yahoo.com

Jenkins build is back to normal : clang-format-master #1507

Posted by je...@ci.trafficserver.apache.org.
See <https://ci.trafficserver.apache.org/job/clang-format-master/1507/display/redirect?page=changes>


Build failed in Jenkins: clang-format-master #1506

Posted by je...@ci.trafficserver.apache.org.
See <https://ci.trafficserver.apache.org/job/clang-format-master/1506/display/redirect>

------------------------------------------
[...truncated 57.64 KB...]
./proxy/Show.h
./proxy/logstats.cc
./proxy/StatPages.h
./proxy/TimeTrace.h
./proxy/TestPreProc.cc
./proxy/Crash.cc
./proxy/PluginVC.h
./proxy/shared/DiagsConfig.h
./proxy/shared/UglyLogStubs.cc
./proxy/shared/DiagsConfig.cc
./proxy/IPAllow.h
./proxy/InkAPITest.cc
./proxy/InkAPIInternal.h
./proxy/ParentRoundRobin.h
./proxy/UnixCompletionUtil.h
./proxy/ProtocolProbeSessionAccept.cc
./proxy/ReverseProxy.cc
./proxy/TransformInternal.h
./proxy/RegressionSM.h
./proxy/UDPAPITest.cc
./proxy/EventName.cc
./proxy/SocksProxy.cc
./proxy/api/ts/remap.h
./proxy/api/ts/experimental.h
./proxy/api/ts/InkAPIPrivateIOCore.h
./proxy/api/ts/ts.h
./proxy/api/ts/TsException.h
./proxy/EventName.h
./proxy/Plugin.cc
./proxy/StufferUdpReceiver.cc
./proxy/TestPreProc.h
./proxy/Main.h
./proxy/TestSimpleProxy.cc
./proxy/logcat.cc
./proxy/InkAPITestTool.cc
./proxy/PluginVC.cc
./proxy/ControlMatcher.cc
./proxy/CacheControl.cc
./proxy/TestDNS.cc
./proxy/logging/LogHost.cc
./proxy/logging/LogFormat.cc
./proxy/logging/LogAccessHttp.h
./proxy/logging/LogObject.cc
./proxy/logging/LogHost.h
./proxy/logging/LogStandalone.cc
./proxy/logging/LogBindings.h
./proxy/logging/test_LogUtils.cc
./proxy/logging/LogCollationBase.h
./proxy/logging/LogBuffer.h
./proxy/logging/LogUtils.h
./proxy/logging/LogFilter.h
./proxy/logging/LogAccessHttp.cc
./proxy/logging/LogFilter.cc
./proxy/logging/LogCollationClientSM.cc
./proxy/logging/Log.cc
./proxy/logging/LogLimits.h
./proxy/logging/LogCollationHostSM.cc
./proxy/logging/LogBuffer.cc
./proxy/logging/LogBindings.cc
./proxy/logging/LogUtils.cc
./proxy/logging/LogAccess.cc
./proxy/logging/LogAccessTest.cc
./proxy/logging/LogCollationClientSM.h
./proxy/logging/LogObject.h
./proxy/logging/LogCollationHostSM.h
./proxy/logging/LogConfig.cc
./proxy/logging/LogSock.h
./proxy/logging/LogFieldAliasMap.h
./proxy/logging/LogFieldAliasMap.cc
./proxy/logging/LogCollationAccept.h
./proxy/logging/LogFile.h
./proxy/logging/LogCollationAccept.cc
./proxy/logging/LogAccess.h
./proxy/logging/LogFile.cc
./proxy/logging/LogConfig.h
./proxy/logging/Log.h
./proxy/logging/LogFormat.h
./proxy/logging/LogBufferSink.h
./proxy/logging/LogField.h
./proxy/logging/LogField.cc
./proxy/logging/LogAccessTest.h
./proxy/logging/LogSock.cc
./proxy/ParentRoundRobin.cc
./proxy/Transform.cc
./proxy/Prefetch.h
./proxy/ParentConsistentHash.cc
./proxy/InkAPI.cc
./proxy/TestClock.cc
./proxy/congest/CongestionStats.cc
./proxy/congest/CongestionStats.h
./proxy/congest/CongestionDB.cc
./proxy/congest/CongestionTest.cc
./proxy/congest/Congestion.cc
./proxy/congest/CongestionDB.h
./proxy/congest/MT_hashtable.h
./proxy/congest/Congestion.h
./proxy/CoreUtils.h
./proxy/CacheControl.h
./proxy/InkIOCoreAPI.cc
./proxy/FetchSM.cc
./proxy/CoreUtils.cc
./proxy/ControlBase.h
./proxy/CompletionUtil.h
./proxy/hdrs/HdrToken.h
./proxy/hdrs/HdrHeap.h
./proxy/hdrs/HdrToken.cc
./proxy/hdrs/HttpCompat.cc
./proxy/hdrs/HdrTest.cc
./proxy/hdrs/HdrUtils.h
./proxy/hdrs/HttpCompat.h
./proxy/hdrs/test_urlhash.cc
./proxy/hdrs/HdrTSOnly.cc
./proxy/hdrs/load_http_hdr.cc
./proxy/hdrs/HdrHeap.cc
./proxy/hdrs/HTTP.h
./proxy/hdrs/HdrUtils.cc
./proxy/hdrs/HdrTest.h
./proxy/hdrs/MIME.cc
./proxy/hdrs/HTTP.cc
./proxy/hdrs/URL.cc
./proxy/hdrs/test_mime.cc
./proxy/hdrs/URL.h
./proxy/hdrs/MIME.h
./proxy/ProxyClientTransaction.h
./proxy/Transform.h
./proxy/http/HttpCacheSM.h
./proxy/http/Http1ClientTransaction.cc
./proxy/http/HttpProxyServerMain.cc
./proxy/http/HttpTransactHeaders.h
./proxy/http/HttpTunnel.h
./proxy/http/HttpDebugNames.cc
./proxy/http/HttpSessionManager.cc
./proxy/http/HttpProxyAPIEnums.h
./proxy/http/HttpCacheSM.cc
./proxy/http/HttpConfig.h
./proxy/http/HttpDebugNames.h
./proxy/http/HttpSessionAccept.cc
./proxy/http/HttpSessionAccept.h
./proxy/http/HttpSessionManager.h
./proxy/http/Http1ClientSession.cc
./proxy/http/HttpConnectionCount.h
./proxy/http/HttpUpdateTester.cc
./proxy/http/remap/UrlMappingPathIndex.cc
./proxy/http/remap/RemapPlugins.cc
./proxy/http/remap/UrlMapping.cc
./proxy/http/remap/RemapProcessor.h
./proxy/http/remap/AclFiltering.cc
./proxy/http/remap/UrlRewrite.h
./proxy/http/remap/RemapPluginInfo.cc
./proxy/http/remap/RemapConfig.cc
./proxy/http/remap/RemapConfig.h
./proxy/http/remap/AclFiltering.h
./proxy/http/remap/RemapPlugins.h
./proxy/http/remap/UrlMapping.h
./proxy/http/remap/UrlRewrite.cc
./proxy/http/remap/UrlMappingPathIndex.h
./proxy/http/remap/RemapProcessor.cc
./proxy/http/remap/RemapPluginInfo.h
./proxy/http/HttpTransact.h
./proxy/http/HttpUpdateSM.cc
./proxy/http/HttpUpdateSM.h
./proxy/http/HttpProxyServerMain.h
./proxy/http/HttpTransact.cc
./proxy/http/HttpTransactHeaders.cc
./proxy/http/HttpTransactCache.h
./proxy/http/testheaders.cc
./proxy/http/HttpSM.h
./proxy/http/HttpConnectionCount.cc
./proxy/http/HttpConfig.cc
./proxy/http/TestUrl.cc
./proxy/http/HttpTransactCache.cc
./proxy/http/HttpBodyFactory.cc
./proxy/http/HttpPages.h
./proxy/http/HttpSM.cc
./proxy/http/Http1ClientSession.h
./proxy/http/HttpServerSession.h
./proxy/http/HttpTunnel.cc
./proxy/http/HttpPages.cc
./proxy/http/Http1ClientTransaction.h
./proxy/http/test_socket_close.cc
./proxy/http/HttpServerSession.cc
./proxy/http/RegressionHttpTransact.cc
./proxy/http/HttpBodyFactory.h
./proxy/ProxyClientSession.h
./proxy/ProxyClientTransaction.cc
./proxy/ReverseProxy.h
./proxy/Milestones.h
./proxy/Plugin.h
./proxy/Prefetch.cc
./proxy/FetchSM.h
./proxy/http2/RegressionHPACK.cc
./proxy/http2/HTTP2.h
./proxy/http2/Http2ConnectionState.cc
./proxy/http2/HPACK.h
./proxy/http2/Http2ClientSession.cc
./proxy/http2/HuffmanCodec.h
./proxy/http2/HTTP2.cc
./proxy/http2/Http2DebugNames.h
./proxy/http2/Http2Stream.h
./proxy/http2/Http2DependencyTree.h
./proxy/http2/Http2DebugNames.cc
./proxy/http2/test_Http2DependencyTree.cc
./proxy/http2/Http2ConnectionState.h
./proxy/http2/HPACK.cc
./proxy/http2/Http2SessionAccept.h
./proxy/http2/Http2Stream.cc
./proxy/http2/test_Huffmancode.cc
./proxy/http2/HuffmanCodec.cc
./proxy/http2/test_HPACK.cc
./proxy/http2/Http2SessionAccept.cc
./proxy/http2/Http2ClientSession.h
./tools/http_load/port.h
./tools/http_load/timers.c
./tools/http_load/http_load.c
./tools/http_load/timers.h
./tools/jtest/jtest.cc
diff --git a/plugins/experimental/stale_while_revalidate/stale_while_revalidate.c b/plugins/experimental/stale_while_revalidate/stale_while_revalidate.c
index 05301dd..2e6783e 100644
--- a/plugins/experimental/stale_while_revalidate/stale_while_revalidate.c
+++ b/plugins/experimental/stale_while_revalidate/stale_while_revalidate.c
@@ -381,7 +381,7 @@ consume_resource(TSCont cont, TSEvent event ATS_UNUSED, void *edata ATS_UNUSED)
           TSHttpTxnNewCacheLookupDo(state->txn, state->req_info->buf, url_loc);
           TSHandleMLocRelease(state->req_info->buf, state->req_info->http_hdr_loc, url_loc);
         } else {
-          TSError("[%s] Error getting the URL from the transaction",PLUGIN_NAME);
+          TSError("[%s] Error getting the URL from the transaction", PLUGIN_NAME);
         }
         // TODO add txn translation hook and pass result along, maybe inside continuation?
         // TSHttpTxnHookAdd(state->txn, TS_HTTP_RESPONSE_TRANSFORM_HOOK, TSTransformCreate(replace_transform, state->txn));
@@ -399,7 +399,7 @@ consume_resource(TSCont cont, TSEvent event ATS_UNUSED, void *edata ATS_UNUSED)
     TSContDestroy(cont);
     break;
   default:
-    TSError("[%s] Unknown event %d.", PLUGIN_NAME,event);
+    TSError("[%s] Unknown event %d.", PLUGIN_NAME, event);
     break;
   }
 
@@ -749,7 +749,7 @@ TSPluginInit(int argc, const char *argv[])
     if (plugin_config->log_info.all || plugin_config->log_info.stale_while_revalidate || plugin_config->log_info.stale_if_error) {
       if (TSTextLogObjectCreate(plugin_config->log_info.filename, TS_LOG_MODE_ADD_TIMESTAMP, &(plugin_config->log_info.object)) !=
           TS_SUCCESS) {
-        TSError("[%s] Error getting the URL from the transaction",PLUGIN_NAME);
+        TSError("[%s] Error getting the URL from the transaction", PLUGIN_NAME);
         return;
       }
     }
Build step 'Execute shell' marked build as failure
Not sending mail to unregistered user vijayabhaskar_mamidi@yahoo.com