You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/17 20:38:46 UTC
[GitHub] [airflow] potiuk opened a new pull request, #28433: Fix output buffering for `breeze testing test`
potiuk opened a new pull request, #28433:
URL: https://github.com/apache/airflow/pull/28433
Since we disabled warnings and redirected them to the output file, we lost continuous output of the progress of tests when they were run as `breeze testing tests` command. The whole summary of the tests appeared only at the end of tests.
This turned out to be Python output buffering in "filter_out_warning" class. It is fixed by flushing sys.stdout after every printed line now.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28433: Fix output buffering for `breeze testing test`
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28433:
URL: https://github.com/apache/airflow/pull/28433#issuecomment-1356833772
Static checks passed. Merging/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28433: Fix output buffering for `breeze testing test`
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28433:
URL: https://github.com/apache/airflow/pull/28433#issuecomment-1356830183
Rebased to account for static check fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28433: Fix output buffering for `breeze testing test`
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28433:
URL: https://github.com/apache/airflow/pull/28433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org