You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "ptupitsyn (via GitHub)" <gi...@apache.org> on 2025/05/02 07:53:21 UTC
[PR] IGNITE-25115 .NET: Implement platform job executor [ignite-3]
ptupitsyn opened a new pull request, #5736:
URL: https://github.com/apache/ignite-3/pull/5736
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25115 .NET: Implement platform job executor [ignite-3]
Posted by "isapego (via GitHub)" <gi...@apache.org>.
isapego commented on code in PR #5736:
URL: https://github.com/apache/ignite-3/pull/5736#discussion_r2071267292
##########
modules/platforms/dotnet/Apache.Ignite.Internal.ComputeExecutor/SystemInfoJob.cs:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Internal.ComputeExecutor;
+
+using System.Diagnostics;
+using Ignite.Compute;
+
+/// <summary>
+/// A built-in compute job that provides system information about the executor.
+/// Useful for .NET executor troubleshooting.
+/// </summary>
+public sealed class SystemInfoJob : IComputeJob<object?, string>
Review Comment:
Would this job pose a vulnerability in production? Maybe we should disable it by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25115 .NET: Implement platform job executor [ignite-3]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn commented on code in PR #5736:
URL: https://github.com/apache/ignite-3/pull/5736#discussion_r2071280418
##########
modules/platforms/dotnet/Apache.Ignite.Internal.ComputeExecutor/SystemInfoJob.cs:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Internal.ComputeExecutor;
+
+using System.Diagnostics;
+using Ignite.Compute;
+
+/// <summary>
+/// A built-in compute job that provides system information about the executor.
+/// Useful for .NET executor troubleshooting.
+/// </summary>
+public sealed class SystemInfoJob : IComputeJob<object?, string>
Review Comment:
We do not do anything sensitive here - do you see any potential problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25115 .NET: Implement platform job executor [ignite-3]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn merged PR #5736:
URL: https://github.com/apache/ignite-3/pull/5736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25115 .NET: Implement platform job executor [ignite-3]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn commented on code in PR #5736:
URL: https://github.com/apache/ignite-3/pull/5736#discussion_r2071394402
##########
modules/platforms/dotnet/Apache.Ignite.Internal.ComputeExecutor/SystemInfoJob.cs:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Internal.ComputeExecutor;
+
+using System.Diagnostics;
+using Ignite.Compute;
+
+/// <summary>
+/// A built-in compute job that provides system information about the executor.
+/// Useful for .NET executor troubleshooting.
+/// </summary>
+public sealed class SystemInfoJob : IComputeJob<object?, string>
Review Comment:
Removed this job to be on the safe side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25115 .NET: Implement platform job executor [ignite-3]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #5736:
URL: https://github.com/apache/ignite-3/pull/5736#discussion_r2071240328
##########
modules/compute/src/main/java/org/apache/ignite/internal/compute/executor/ComputeExecutorImpl.java:
##########
@@ -133,7 +133,7 @@ private Callable<CompletableFuture<ComputeJobDataHolder>> getJobCallable(
// TODO IGNITE-25116: Remove.
if (jobClassName.startsWith("TEST_ONLY_DOTNET_JOB:") && dotNetExec0 != null) {
- return dotNetExec0.getJobCallable(getDeploymentUnitPaths(classLoader), jobClassName, input, context);
+ return dotNetExec0.getJobCallable(getDeploymentUnitPaths(classLoader), jobClassName.substring(21), input, context);
Review Comment:
The use of a hard-coded index '21' for removing the job prefix may be fragile. Consider defining a constant for the prefix length or the prefix string to improve clarity and maintainability.
##########
modules/platforms/dotnet/Apache.Ignite/Compute/IComputeJob.cs:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Compute;
+
+using System.Threading;
+using System.Threading.Tasks;
+using Marshalling;
+
+/// <summary>
+/// Ignite compute job interface.
+/// <para />
+/// To define a compute job, implement this interface and deploy the binaries to the cluster with the Deployemnt API.
Review Comment:
The word 'Deployemnt' appears to be a typo. Consider correcting it to 'Deployment'.
```suggestion
/// To define a compute job, implement this interface and deploy the binaries to the cluster with the Deployment API.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org