You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/07/23 03:41:19 UTC
[GitHub] [zookeeper] maoling commented on a change in pull request #1019:
ZOOKEEPER-3464:enfore checkstyle in the zookeeper-server module and clean
the package:admin and client
maoling commented on a change in pull request #1019: ZOOKEEPER-3464:enfore checkstyle in the zookeeper-server module and clean the package:admin and client
URL: https://github.com/apache/zookeeper/pull/1019#discussion_r306117372
##########
File path: pom.xml
##########
@@ -582,19 +582,20 @@
<version>${checkstyle.version}</version>
</dependency>
</dependencies>
- <configuration>
- <configLocation>checkstyle.xml</configLocation>
- <suppressionsLocation>checkstyleSuppressions.xml</suppressionsLocation>
- <encoding>UTF-8</encoding>
- <consoleOutput>true</consoleOutput>
- <failOnViolation>true</failOnViolation>
- <includeResources>false</includeResources>
- <includeTestSourceDirectory>true</includeTestSourceDirectory>
- </configuration>
<executions>
<execution>
<id>checkstyle</id>
<phase>validate</phase>
+ <configuration>
+ <configLocation>checkstyle.xml</configLocation>
Review comment:
@eolivelli
- Done.use the separate `checkstyle-strict.xml` for the `zookeeper-server` module.
- I check that our code base doesn't have the **'@author'** tag
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services