You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Akanksha-kedia (via GitHub)" <gi...@apache.org> on 2025/10/24 16:19:13 UTC
[PR] Improved Error Handling and Logging [pinot]
Akanksha-kedia opened a new pull request, #17071:
URL: https://github.com/apache/pinot/pull/17071
- Added a _stopReasonPrinted volatile flag to track if the stop reason has already been printed
- Modified the endCriteriaReached() method to check this flag before logging the stop reason
- Implemented support for a "stopOnDecodeError" configuration parameter in the StreamConfig
- When enabled, consumption will stop with an error if a decode error occurs
- When disabled (default), errors are logged and the row is silently dropped
- These changes prevent redundant logging and provide flexible error handling options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Improved Error Handling and Logging [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on PR #17071:
URL: https://github.com/apache/pinot/pull/17071#issuecomment-3726644803
@swaminathanmanish @KKcorps Please help review the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Improved Error Handling and Logging [pinot]
Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia commented on PR #17071:
URL: https://github.com/apache/pinot/pull/17071#issuecomment-3449625057
@yashmayya @mneedham @olamy @gom @sullis @yashrsharma44 @ykeremy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Improved Error Handling and Logging [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #17071:
URL: https://github.com/apache/pinot/pull/17071#discussion_r2644843429
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -630,13 +634,22 @@ private boolean processStreamEvents(MessageBatch messageBatch, long idlePipeSlee
StreamPartitionMsgOffset nextOffset = metadata.getNextOffset();
int rowSizeInBytes = metadata.getRecordSerializedSize();
if (decodedRow.getException() != null) {
- // TODO: based on a config, decide whether the record should be silently dropped or stop further consumption on
- // decode error
- realtimeRowsDroppedMeter =
- _serverMetrics.addMeteredTableValue(_clientId, ServerMeter.INVALID_REALTIME_ROWS_DROPPED, 1,
- realtimeRowsDroppedMeter);
- _numRowsErrored++;
- _numBytesDropped += rowSizeInBytes;
+ boolean stopOnDecodeError = _streamConfig.getStreamConfigsMap()
Review Comment:
make this a class member variable to avoid the check everytime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Improved Error Handling and Logging [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #17071:
URL: https://github.com/apache/pinot/pull/17071#issuecomment-4202088507
Documentation PR created: https://github.com/pinot-contrib/pinot-docs/pull/724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Improved Error Handling and Logging [pinot]
Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia commented on PR #17071:
URL: https://github.com/apache/pinot/pull/17071#issuecomment-3478790960
@xiangfu0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Improved Error Handling and Logging [pinot]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #17071:
URL: https://github.com/apache/pinot/pull/17071#discussion_r2644832249
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -630,13 +634,22 @@ private boolean processStreamEvents(MessageBatch messageBatch, long idlePipeSlee
StreamPartitionMsgOffset nextOffset = metadata.getNextOffset();
int rowSizeInBytes = metadata.getRecordSerializedSize();
if (decodedRow.getException() != null) {
- // TODO: based on a config, decide whether the record should be silently dropped or stop further consumption on
- // decode error
- realtimeRowsDroppedMeter =
- _serverMetrics.addMeteredTableValue(_clientId, ServerMeter.INVALID_REALTIME_ROWS_DROPPED, 1,
- realtimeRowsDroppedMeter);
- _numRowsErrored++;
- _numBytesDropped += rowSizeInBytes;
+ boolean stopOnDecodeError = _streamConfig.getStreamConfigsMap()
+ .getOrDefault("stopOnDecodeError", "false").equalsIgnoreCase("true");
Review Comment:
The configuration parameter 'stopOnDecodeError' is accessed directly as a string from the stream config map. This approach lacks input validation and type safety. Consider defining this as a named constant and using a dedicated configuration property with proper documentation, or add validation to ensure the value is a valid boolean string.
```suggestion
String stopOnDecodeErrorConfig =
_streamConfig.getStreamConfigsMap().get("stopOnDecodeError");
boolean stopOnDecodeError;
if (stopOnDecodeErrorConfig == null) {
// Default behavior when config is not provided: do not stop on decode error.
stopOnDecodeError = false;
} else if ("true".equalsIgnoreCase(stopOnDecodeErrorConfig)) {
stopOnDecodeError = true;
} else if ("false".equalsIgnoreCase(stopOnDecodeErrorConfig)) {
stopOnDecodeError = false;
} else {
// Invalid value; log and fall back to default to avoid silent misconfiguration.
_segmentLogger.warn("Invalid value '{}' for configuration 'stopOnDecodeError'; "
+ "expected 'true' or 'false'. Defaulting to 'false'.", stopOnDecodeErrorConfig);
stopOnDecodeError = false;
}
```
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -630,13 +634,22 @@ private boolean processStreamEvents(MessageBatch messageBatch, long idlePipeSlee
StreamPartitionMsgOffset nextOffset = metadata.getNextOffset();
int rowSizeInBytes = metadata.getRecordSerializedSize();
if (decodedRow.getException() != null) {
- // TODO: based on a config, decide whether the record should be silently dropped or stop further consumption on
- // decode error
- realtimeRowsDroppedMeter =
- _serverMetrics.addMeteredTableValue(_clientId, ServerMeter.INVALID_REALTIME_ROWS_DROPPED, 1,
- realtimeRowsDroppedMeter);
- _numRowsErrored++;
- _numBytesDropped += rowSizeInBytes;
+ boolean stopOnDecodeError = _streamConfig.getStreamConfigsMap()
+ .getOrDefault("stopOnDecodeError", "false").equalsIgnoreCase("true");
+ if (stopOnDecodeError) {
+ String errorMessage = "Stopping consumption due to decode error at offset: " + offset;
+ _segmentLogger.error(errorMessage, decodedRow.getException());
+ _realtimeTableDataManager.addSegmentError(_segmentNameStr,
+ new SegmentErrorInfo(now(), errorMessage, decodedRow.getException()));
+ throw new RuntimeException("Stopping consumption due to decode error", decodedRow.getException());
Review Comment:
The error message is duplicated in three places: the log statement, the SegmentErrorInfo, and the RuntimeException. Consider extracting this to a single constant or variable to ensure consistency and easier maintenance.
```suggestion
throw new RuntimeException(errorMessage, decodedRow.getException());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Improved Error Handling and Logging [pinot]
Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia commented on code in PR #17071:
URL: https://github.com/apache/pinot/pull/17071#discussion_r2471712118
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -627,13 +631,22 @@ private boolean processStreamEvents(MessageBatch messageBatch, long idlePipeSlee
StreamPartitionMsgOffset nextOffset = metadata.getNextOffset();
int rowSizeInBytes = metadata.getRecordSerializedSize();
if (decodedRow.getException() != null) {
- // TODO: based on a config, decide whether the record should be silently dropped or stop further consumption on
- // decode error
- realtimeRowsDroppedMeter =
- _serverMetrics.addMeteredTableValue(_clientId, ServerMeter.INVALID_REALTIME_ROWS_DROPPED, 1,
- realtimeRowsDroppedMeter);
- _numRowsErrored++;
- _numBytesDropped += rowSizeInBytes;
+ boolean stopOnDecodeError = _streamConfig.getStreamConfigsMap()
+ .getOrDefault("stopOnDecodeError", "false").equalsIgnoreCase("true");
+ if (stopOnDecodeError) {
+ String errorMessage = "Stopping consumption due to decode error at offset: " + offset;
+ _segmentLogger.error(errorMessage, decodedRow.getException());
Review Comment:
logger.error(String message, Throwable throwable), it should automatically log the full stack trace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Improved Error Handling and Logging [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #17071:
URL: https://github.com/apache/pinot/pull/17071#discussion_r2644846903
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -630,13 +634,22 @@ private boolean processStreamEvents(MessageBatch messageBatch, long idlePipeSlee
StreamPartitionMsgOffset nextOffset = metadata.getNextOffset();
int rowSizeInBytes = metadata.getRecordSerializedSize();
if (decodedRow.getException() != null) {
- // TODO: based on a config, decide whether the record should be silently dropped or stop further consumption on
- // decode error
- realtimeRowsDroppedMeter =
- _serverMetrics.addMeteredTableValue(_clientId, ServerMeter.INVALID_REALTIME_ROWS_DROPPED, 1,
- realtimeRowsDroppedMeter);
- _numRowsErrored++;
- _numBytesDropped += rowSizeInBytes;
+ boolean stopOnDecodeError = _streamConfig.getStreamConfigsMap()
+ .getOrDefault("stopOnDecodeError", "false").equalsIgnoreCase("true");
+ if (stopOnDecodeError) {
+ String errorMessage = "Stopping consumption due to decode error at offset: " + offset;
+ _segmentLogger.error(errorMessage, decodedRow.getException());
+ _realtimeTableDataManager.addSegmentError(_segmentNameStr,
+ new SegmentErrorInfo(now(), errorMessage, decodedRow.getException()));
+ throw new RuntimeException("Stopping consumption due to decode error", decodedRow.getException());
+ } else {
+ // Silently drop the row with error
Review Comment:
I would prefer to print one line of error then swallow all the errors after.
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -630,13 +634,22 @@ private boolean processStreamEvents(MessageBatch messageBatch, long idlePipeSlee
StreamPartitionMsgOffset nextOffset = metadata.getNextOffset();
int rowSizeInBytes = metadata.getRecordSerializedSize();
if (decodedRow.getException() != null) {
- // TODO: based on a config, decide whether the record should be silently dropped or stop further consumption on
- // decode error
- realtimeRowsDroppedMeter =
- _serverMetrics.addMeteredTableValue(_clientId, ServerMeter.INVALID_REALTIME_ROWS_DROPPED, 1,
- realtimeRowsDroppedMeter);
- _numRowsErrored++;
- _numBytesDropped += rowSizeInBytes;
+ boolean stopOnDecodeError = _streamConfig.getStreamConfigsMap()
+ .getOrDefault("stopOnDecodeError", "false").equalsIgnoreCase("true");
+ if (stopOnDecodeError) {
+ String errorMessage = "Stopping consumption due to decode error at offset: " + offset;
+ _segmentLogger.error(errorMessage, decodedRow.getException());
+ _realtimeTableDataManager.addSegmentError(_segmentNameStr,
+ new SegmentErrorInfo(now(), errorMessage, decodedRow.getException()));
+ throw new RuntimeException("Stopping consumption due to decode error", decodedRow.getException());
+ } else {
+ // Silently drop the row with error
Review Comment:
I would prefer to print the first error then swallow all the errors after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Improved Error Handling and Logging [pinot]
Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia commented on PR #17071:
URL: https://github.com/apache/pinot/pull/17071#issuecomment-3454411477
@xiangfu0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Improved Error Handling and Logging [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #17071:
URL: https://github.com/apache/pinot/pull/17071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Improved Error Handling and Logging [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #17071:
URL: https://github.com/apache/pinot/pull/17071#issuecomment-4208996188
Documentation PR opened: https://github.com/pinot-contrib/pinot-docs/pull/726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Improved Error Handling and Logging [pinot]
Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia commented on PR #17071:
URL: https://github.com/apache/pinot/pull/17071#issuecomment-3940988484
@swaminathanmanish @KKcorps Please help review the change
@xiangfu0 please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Improved Error Handling and Logging [pinot]
Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia commented on PR #17071:
URL: https://github.com/apache/pinot/pull/17071#issuecomment-3678553074
@xiangfu0 please review and help to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Improved Error Handling and Logging [pinot]
Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia commented on PR #17071:
URL: https://github.com/apache/pinot/pull/17071#issuecomment-3443967497
@mcvsubbu please review
@Jackie-Jiang
I m new to the project and trying to contribute starting with todo list and den further contribution would be done.
@yashmayya do help to review and help to add required tag as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Improved Error Handling and Logging [pinot]
Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia commented on PR #17071:
URL: https://github.com/apache/pinot/pull/17071#issuecomment-3459603059
> overall lgtm
help to review and merge @xiangfu0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Improved Error Handling and Logging [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #17071:
URL: https://github.com/apache/pinot/pull/17071#discussion_r2470801050
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -627,13 +631,22 @@ private boolean processStreamEvents(MessageBatch messageBatch, long idlePipeSlee
StreamPartitionMsgOffset nextOffset = metadata.getNextOffset();
int rowSizeInBytes = metadata.getRecordSerializedSize();
if (decodedRow.getException() != null) {
- // TODO: based on a config, decide whether the record should be silently dropped or stop further consumption on
- // decode error
- realtimeRowsDroppedMeter =
- _serverMetrics.addMeteredTableValue(_clientId, ServerMeter.INVALID_REALTIME_ROWS_DROPPED, 1,
- realtimeRowsDroppedMeter);
- _numRowsErrored++;
- _numBytesDropped += rowSizeInBytes;
+ boolean stopOnDecodeError = _streamConfig.getStreamConfigsMap()
+ .getOrDefault("stopOnDecodeError", "false").equalsIgnoreCase("true");
+ if (stopOnDecodeError) {
+ String errorMessage = "Stopping consumption due to decode error at offset: " + offset;
+ _segmentLogger.error(errorMessage, decodedRow.getException());
Review Comment:
Here prefer the full stacktrace for debuggability instead of just the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Improved Error Handling and Logging [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17071:
URL: https://github.com/apache/pinot/pull/17071#issuecomment-3459699856
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/17071?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `27.77778%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 56.19%. Comparing base ([`bffd1e9`](https://app.codecov.io/gh/apache/pinot/commit/bffd1e9692d5c893a40339cf52ab57f375bd298b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`dd7aa77`](https://app.codecov.io/gh/apache/pinot/commit/dd7aa772f501f353995bdafc29625b25330670d2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/17071?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...a/manager/realtime/RealtimeSegmentDataManager.java](https://app.codecov.io/gh/apache/pinot/pull/17071?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fdata%2Fmanager%2Frealtime%2FRealtimeSegmentDataManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | 27.77% | [12 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pinot/pull/17071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (bffd1e9) and HEAD (dd7aa77). Click for more details.
>
> <details><summary>HEAD has 32 uploads less than BASE</summary>
>
>| Flag | BASE (bffd1e9) | HEAD (dd7aa77) |
>|------|------|------|
>|java-21|5|1|
>|unittests1|2|1|
>|unittests|3|1|
>|temurin|9|1|
>|java-11|4|0|
>|unittests2|1|0|
>|integration|6|0|
>|integration2|2|0|
>|integration1|2|0|
>|custom-integration1|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17071 +/- ##
============================================
- Coverage 63.22% 56.19% -7.04%
+ Complexity 1429 701 -728
============================================
Files 3104 2420 -684
Lines 183356 135368 -47988
Branches 28097 21627 -6470
============================================
- Hits 115930 76071 -39859
+ Misses 58465 52906 -5559
+ Partials 8961 6391 -2570
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/17071/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/17071/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/17071/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/17071/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/17071/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/17071/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/17071/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.19% <27.77%> (-7.01%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/17071/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.19% <27.77%> (-7.04%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/17071/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.19% <27.77%> (-7.03%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/17071/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.19% <27.77%> (-0.06%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/17071/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/17071?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org