You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/05/30 06:52:55 UTC
[GitHub] [pulsar] lhotari opened a new pull request, #20437: [fix][test] Replace usage of org.testcontainers.shaded.* classes in tests
lhotari opened a new pull request, #20437:
URL: https://github.com/apache/pulsar/pull/20437
### Motivation
`org.testcontainers.shaded.*` classes shouldn't be used.
### Modifications
- replace usage of org.testcontainers.shaded.* classes in tests with the correct imports.
- organize imports
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #20437: [fix][test] Replace usage of org.testcontainers.shaded.* classes in tests
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #20437:
URL: https://github.com/apache/pulsar/pull/20437#issuecomment-1567964162
@nicoloboschi The checkstyle rule is now active and will prevent importing org.testcontainers.shaded.* classes in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #20437: [fix][test] Replace usage of org.testcontainers.shaded.* classes in tests
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #20437:
URL: https://github.com/apache/pulsar/pull/20437#issuecomment-1567941334
> What about adding a new checkstyle rule to avoid the import of
>
> org.testcontainers.shaded ?
@nicoloboschi We have already #18113 and I also tried https://github.com/lhotari/pulsar/commit/03624d2a since there was a comment somewhere that IllegalImport check doesn't apply to class imports.
It appears that we don't run checkstyle for tests so that's why it doesn't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #20437: [fix][test] Replace usage of org.testcontainers.shaded.* classes in tests
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #20437:
URL: https://github.com/apache/pulsar/pull/20437#issuecomment-1568007845
thought - I'd actually prefer to use some technologies that can automatically format code like spotless (see [FLINK-20651](https://issues.apache.org/jira/browse/FLINK-20651)), but it can introduce a big diff and the maven plugin cannot cover "forbid import pattern" pattern (while the Gralde one can, I suppose it's technically possible upstream to support for maven plugin also).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #20437: [fix][test] Replace usage of org.testcontainers.shaded.* classes in tests
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #20437:
URL: https://github.com/apache/pulsar/pull/20437#issuecomment-1567949931
Found it. Most checks are disabled for tests: https://github.com/apache/pulsar/blob/82237d3684fe506bcb6426b3b23f413422e6e4fb/buildtools/src/main/resources/pulsar/suppressions.xml#L41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #20437: [fix][test] Replace usage of org.testcontainers.shaded.* classes in tests
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #20437:
URL: https://github.com/apache/pulsar/pull/20437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org