You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David Summers <ds...@digital-realms.com> on 2001/10/30 16:23:21 UTC
Problem with install-sh???
Does this patch need to be applied? I tried compiling this morning and
ran into an "unexpected EOF" shell error which I assume is caused by this:
Index: ./install-sh
===================================================================
--- ./.svn/text-base/install-sh Thu Oct 25 14:31:40 2001
+++ ./install-sh Tue Oct 30 10:16:38 2001
@@ -245,7 +245,7 @@
$doit $rmcmd -f $dstdir/$dstfile &&
$doit $mvcmd $dsttmp $dstdir/$dstfile
-fi &&
+fi
exit 0
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Problem with install-sh???
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
David Summers <ds...@digital-realms.com> writes:
> Does this patch need to be applied? I tried compiling this morning and
> ran into an "unexpected EOF" shell error which I assume is caused by this:
Hmm. I'm not sure:
There are a lot of similar "&&"s in that script. They're all suspect
to me -- I thought you couldn't have a dangling "&&", that is, one not
followed by another command on the same line. But a lot of them are
followed by a newline, then a new command. If their purpose is to
stop the script on an error, I don't know if they achieve that purpose
or not.
But in any case, the "&&" in your patch is like a lot of those others:
it is followed by a command ("exit 0") on a new line. So either
they're all correct, or they all need to be fixed.
-K
> Index: ./install-sh
> ===================================================================
> --- ./.svn/text-base/install-sh Thu Oct 25 14:31:40 2001
> +++ ./install-sh Tue Oct 30 10:16:38 2001
> @@ -245,7 +245,7 @@
> $doit $rmcmd -f $dstdir/$dstfile &&
> $doit $mvcmd $dsttmp $dstdir/$dstfile
>
> -fi &&
> +fi
>
>
> exit 0
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org