You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/12/04 15:56:37 UTC

[GitHub] [buildstream-plugins] abderrahim commented on a diff in pull request #41: Make usage of ninja implementation detail

abderrahim commented on code in PR #41:
URL: https://github.com/apache/buildstream-plugins/pull/41#discussion_r1038992656


##########
src/buildstream_plugins/elements/meson.yaml:
##########
@@ -39,11 +39,11 @@ variables:
 
   meson: meson setup %{conf-root} %{build-dir} %{meson-args}
 
-  ninja: |
+  meson-build: |
     ninja -j ${NINJAJOBS} -C %{build-dir}

Review Comment:
   maybe rename NINJAJOBS as well? cmake uses JOBS iirc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org