You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Siying Dong (JIRA)" <ji...@apache.org> on 2011/09/16 01:50:09 UTC
[jira] [Created] (HIVE-2451) TABLESAMBLE(BUCKET xxx) sometimes
doesn't trigger input pruning as regression of HIVE-1538
TABLESAMBLE(BUCKET xxx) sometimes doesn't trigger input pruning as regression of HIVE-1538
------------------------------------------------------------------------------------------
Key: HIVE-2451
URL: https://issues.apache.org/jira/browse/HIVE-2451
Project: Hive
Issue Type: Bug
Reporter: Siying Dong
Assignee: Siying Dong
Example:
select count(1) from <bucket_table> TABLESAMPLE(BUCKET xxx out of yyy) where <partition_column> = 'xxx'
will not trigger input pruning.
The reason is that we assume sample filtering operator only happens as the second filter after table scan, which is broken by HIVE-1538, even if the feature doesn't turn on.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2451) TABLESAMBLE(BUCKET xxx) sometimes
doesn't trigger input pruning as regression of HIVE-1538
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2451:
------------------------------
Status: Open (was: Patch Available)
There's a bug.
> TABLESAMBLE(BUCKET xxx) sometimes doesn't trigger input pruning as regression of HIVE-1538
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-2451
> URL: https://issues.apache.org/jira/browse/HIVE-2451
> Project: Hive
> Issue Type: Bug
> Reporter: Siying Dong
> Assignee: Siying Dong
> Attachments: HIVE-2451.1.patch
>
>
> Example:
> select count(1) from <bucket_table> TABLESAMPLE(BUCKET xxx out of yyy) where <partition_column> = 'xxx'
> will not trigger input pruning.
> The reason is that we assume sample filtering operator only happens as the second filter after table scan, which is broken by HIVE-1538, even if the feature doesn't turn on.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2451) TABLESAMBLE(BUCKET xxx) sometimes
doesn't trigger input pruning as regression of HIVE-1538
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2451:
------------------------------
Attachment: HIVE-2451.3.patch
Reran all test suites and fixed another several wrong test results.
> TABLESAMBLE(BUCKET xxx) sometimes doesn't trigger input pruning as regression of HIVE-1538
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-2451
> URL: https://issues.apache.org/jira/browse/HIVE-2451
> Project: Hive
> Issue Type: Bug
> Reporter: Siying Dong
> Assignee: Siying Dong
> Attachments: HIVE-2451.1.patch, HIVE-2451.2.patch, HIVE-2451.3.patch
>
>
> Example:
> select count(1) from <bucket_table> TABLESAMPLE(BUCKET xxx out of yyy) where <partition_column> = 'xxx'
> will not trigger input pruning.
> The reason is that we assume sample filtering operator only happens as the second filter after table scan, which is broken by HIVE-1538, even if the feature doesn't turn on.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2451) TABLESAMBLE(BUCKET xxx) sometimes
doesn't trigger input pruning as regression of HIVE-1538
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2451:
------------------------------
Status: Patch Available (was: Open)
> TABLESAMBLE(BUCKET xxx) sometimes doesn't trigger input pruning as regression of HIVE-1538
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-2451
> URL: https://issues.apache.org/jira/browse/HIVE-2451
> Project: Hive
> Issue Type: Bug
> Reporter: Siying Dong
> Assignee: Siying Dong
> Attachments: HIVE-2451.1.patch
>
>
> Example:
> select count(1) from <bucket_table> TABLESAMPLE(BUCKET xxx out of yyy) where <partition_column> = 'xxx'
> will not trigger input pruning.
> The reason is that we assume sample filtering operator only happens as the second filter after table scan, which is broken by HIVE-1538, even if the feature doesn't turn on.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2451) TABLESAMBLE(BUCKET xxx) sometimes
doesn't trigger input pruning as regression of HIVE-1538
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108358#comment-13108358 ]
Hudson commented on HIVE-2451:
------------------------------
Integrated in Hive-trunk-h0.21 #965 (See [https://builds.apache.org/job/Hive-trunk-h0.21/965/])
HIVE-2451: TABLESAMBLE(BUCKET xxx) sometimes doesn't trigger input pruning (Siying Dong via He Yongqiang)
heyongqiang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1172891
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/SamplePruner.java
* /hive/trunk/ql/src/test/results/clientpositive/sample10.q.out
* /hive/trunk/ql/src/test/results/clientpositive/sample2.q.out
* /hive/trunk/ql/src/test/results/clientpositive/sample4.q.out
* /hive/trunk/ql/src/test/results/clientpositive/sample6.q.out
* /hive/trunk/ql/src/test/results/clientpositive/sample9.q.out
* /hive/trunk/ql/src/test/results/compiler/plan/sample2.q.xml
* /hive/trunk/ql/src/test/results/compiler/plan/sample4.q.xml
* /hive/trunk/ql/src/test/results/compiler/plan/sample6.q.xml
> TABLESAMBLE(BUCKET xxx) sometimes doesn't trigger input pruning as regression of HIVE-1538
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-2451
> URL: https://issues.apache.org/jira/browse/HIVE-2451
> Project: Hive
> Issue Type: Bug
> Reporter: Siying Dong
> Assignee: Siying Dong
> Attachments: HIVE-2451.1.patch, HIVE-2451.2.patch, HIVE-2451.3.patch
>
>
> Example:
> select count(1) from <bucket_table> TABLESAMPLE(BUCKET xxx out of yyy) where <partition_column> = 'xxx'
> will not trigger input pruning.
> The reason is that we assume sample filtering operator only happens as the second filter after table scan, which is broken by HIVE-1538, even if the feature doesn't turn on.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2451) TABLESAMBLE(BUCKET xxx) sometimes
doesn't trigger input pruning as regression of HIVE-1538
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2451:
------------------------------
Attachment: HIVE-2451.2.patch
Changed an assert issue and recover the some test result files which were changed incorrectly by HIVE-1538.
> TABLESAMBLE(BUCKET xxx) sometimes doesn't trigger input pruning as regression of HIVE-1538
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-2451
> URL: https://issues.apache.org/jira/browse/HIVE-2451
> Project: Hive
> Issue Type: Bug
> Reporter: Siying Dong
> Assignee: Siying Dong
> Attachments: HIVE-2451.1.patch, HIVE-2451.2.patch
>
>
> Example:
> select count(1) from <bucket_table> TABLESAMPLE(BUCKET xxx out of yyy) where <partition_column> = 'xxx'
> will not trigger input pruning.
> The reason is that we assume sample filtering operator only happens as the second filter after table scan, which is broken by HIVE-1538, even if the feature doesn't turn on.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2451) TABLESAMBLE(BUCKET xxx) sometimes
doesn't trigger input pruning as regression of HIVE-1538
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105782#comment-13105782 ]
He Yongqiang commented on HIVE-2451:
------------------------------------
+1, will commit after tests pass
> TABLESAMBLE(BUCKET xxx) sometimes doesn't trigger input pruning as regression of HIVE-1538
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-2451
> URL: https://issues.apache.org/jira/browse/HIVE-2451
> Project: Hive
> Issue Type: Bug
> Reporter: Siying Dong
> Assignee: Siying Dong
> Attachments: HIVE-2451.1.patch
>
>
> Example:
> select count(1) from <bucket_table> TABLESAMPLE(BUCKET xxx out of yyy) where <partition_column> = 'xxx'
> will not trigger input pruning.
> The reason is that we assume sample filtering operator only happens as the second filter after table scan, which is broken by HIVE-1538, even if the feature doesn't turn on.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2451) TABLESAMBLE(BUCKET xxx) sometimes
doesn't trigger input pruning as regression of HIVE-1538
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2451:
------------------------------
Attachment: HIVE-2451.1.patch
Fix the problem by considering sample filter operator can be the first filter operator after table scan.
> TABLESAMBLE(BUCKET xxx) sometimes doesn't trigger input pruning as regression of HIVE-1538
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-2451
> URL: https://issues.apache.org/jira/browse/HIVE-2451
> Project: Hive
> Issue Type: Bug
> Reporter: Siying Dong
> Assignee: Siying Dong
> Attachments: HIVE-2451.1.patch
>
>
> Example:
> select count(1) from <bucket_table> TABLESAMPLE(BUCKET xxx out of yyy) where <partition_column> = 'xxx'
> will not trigger input pruning.
> The reason is that we assume sample filtering operator only happens as the second filter after table scan, which is broken by HIVE-1538, even if the feature doesn't turn on.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2451) TABLESAMBLE(BUCKET xxx) sometimes
doesn't trigger input pruning as regression of HIVE-1538
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2451:
------------------------------
Status: Patch Available (was: Open)
> TABLESAMBLE(BUCKET xxx) sometimes doesn't trigger input pruning as regression of HIVE-1538
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-2451
> URL: https://issues.apache.org/jira/browse/HIVE-2451
> Project: Hive
> Issue Type: Bug
> Reporter: Siying Dong
> Assignee: Siying Dong
> Attachments: HIVE-2451.1.patch, HIVE-2451.2.patch, HIVE-2451.3.patch
>
>
> Example:
> select count(1) from <bucket_table> TABLESAMPLE(BUCKET xxx out of yyy) where <partition_column> = 'xxx'
> will not trigger input pruning.
> The reason is that we assume sample filtering operator only happens as the second filter after table scan, which is broken by HIVE-1538, even if the feature doesn't turn on.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2451) TABLESAMBLE(BUCKET xxx) sometimes
doesn't trigger input pruning as regression of HIVE-1538
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
He Yongqiang updated HIVE-2451:
-------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
committed, thanks Siying!
> TABLESAMBLE(BUCKET xxx) sometimes doesn't trigger input pruning as regression of HIVE-1538
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-2451
> URL: https://issues.apache.org/jira/browse/HIVE-2451
> Project: Hive
> Issue Type: Bug
> Reporter: Siying Dong
> Assignee: Siying Dong
> Attachments: HIVE-2451.1.patch, HIVE-2451.2.patch, HIVE-2451.3.patch
>
>
> Example:
> select count(1) from <bucket_table> TABLESAMPLE(BUCKET xxx out of yyy) where <partition_column> = 'xxx'
> will not trigger input pruning.
> The reason is that we assume sample filtering operator only happens as the second filter after table scan, which is broken by HIVE-1538, even if the feature doesn't turn on.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira