You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/29 11:25:44 UTC
[GitHub] [arrow] milesgranger opened a new issue, #14766: [Python] Fix PytestUnraisableExceptionWarning in substrait test
milesgranger opened a new issue, #14766:
URL: https://github.com/apache/arrow/issues/14766
### Describe the bug, including details regarding any error messages, version, and platform.
[`test_named_table_invalid_table_name` ](https://github.com/apache/arrow/blob/63f013cdb36d05f6f96a145aff3c6232470f2d02/python/pyarrow/tests/test_substrait.py#L229) generates a `PytestUnraisableExceptionWarning` in the tests. The exception itself is:
> Traceback (most recent call last):
File "/home/joris/scipy/repos/arrow/python/pyarrow/tests/test_substrait.py", line 238, in table_provider
raise Exception("Unrecognized table name")
Exception: Unrecognized table name
The exception ought to be raised properly instead of 'hidden' as a warning.
### Component(s)
Python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on issue #14766: [Python] Fix PytestUnraisableExceptionWarning in substrait test
Posted by GitBox <gi...@apache.org>.
vibhatha commented on issue #14766:
URL: https://github.com/apache/arrow/issues/14766#issuecomment-1333165558
Okay, I will take a look at this. @pitrou or @jorisvandenbossche could you assign this to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Python] Fix PytestUnraisableExceptionWarning in substrait test [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on issue #14766:
URL: https://github.com/apache/arrow/issues/14766#issuecomment-2144061064
I am removing my assignment, since I am mostly maintaining Arrow Java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] milesgranger commented on issue #14766: [Python] Fix PytestUnraisableExceptionWarning in substrait test
Posted by GitBox <gi...@apache.org>.
milesgranger commented on issue #14766:
URL: https://github.com/apache/arrow/issues/14766#issuecomment-1330702735
To expand, it appears the exception to the `table_provider` is raised in [executor->Init](https://github.com/apache/arrow/blob/ccb68afedf00a064c280220f480f3a639cce28f6/cpp/src/arrow/engine/substrait/util.cc#L131) then further down into [engine::substrait::serde::DeserializePlans](https://github.com/apache/arrow/blob/ccb68afedf00a064c280220f480f3a639cce28f6/cpp/src/arrow/engine/substrait/serde.h#L73).
But while it seems to raise the `ArrowInvalid` properly, somewhere it should probably clear the Python exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on issue #14766: [Python] Fix PytestUnraisableExceptionWarning in substrait test
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on issue #14766:
URL: https://github.com/apache/arrow/issues/14766#issuecomment-1333362727
My first guess would be that the `_create_named_table_provider` is missing an ` except *:` (to indicate to cython that this function can raise errors, and thus that it should check if any error is raised). See https://cython.readthedocs.io/en/latest/src/userguide/language_basics.html#error-return-values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on issue #14766: [Python] Fix PytestUnraisableExceptionWarning in substrait test
Posted by GitBox <gi...@apache.org>.
vibhatha commented on issue #14766:
URL: https://github.com/apache/arrow/issues/14766#issuecomment-1333348105
Thank you @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] milesgranger commented on issue #14766: [Python] Fix PytestUnraisableExceptionWarning in substrait test
Posted by GitBox <gi...@apache.org>.
milesgranger commented on issue #14766:
URL: https://github.com/apache/arrow/issues/14766#issuecomment-1333133442
Great! Not planning on it, at least not in the near feature. :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on issue #14766: [Python] Fix PytestUnraisableExceptionWarning in substrait test
Posted by GitBox <gi...@apache.org>.
vibhatha commented on issue #14766:
URL: https://github.com/apache/arrow/issues/14766#issuecomment-1333059217
@milesgranger this has been bothering me too. I wasn't quite sure the best way to resolve this at that time. Thanks for raising this. I will look into this. Are you planning to work on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on issue #14766: [Python] Fix PytestUnraisableExceptionWarning in substrait test
Posted by GitBox <gi...@apache.org>.
vibhatha commented on issue #14766:
URL: https://github.com/apache/arrow/issues/14766#issuecomment-1333423720
@jorisvandenbossche thanks for the idea. I will check this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #14766: [Python] Fix PytestUnraisableExceptionWarning in substrait test
Posted by GitBox <gi...@apache.org>.
kou commented on issue #14766:
URL: https://github.com/apache/arrow/issues/14766#issuecomment-1333343952
Assigned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org