You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/29 02:43:41 UTC

[GitHub] [beam] boyuanzz commented on a change in pull request #12806: [BEAM-10869] Make WriteToPubsub output serialized PubsubMessage proto bytes when using runner v2

boyuanzz commented on a change in pull request #12806:
URL: https://github.com/apache/beam/pull/12806#discussion_r513895196



##########
File path: sdks/python/apache_beam/io/gcp/pubsub.py
##########
@@ -418,10 +439,11 @@ def __init__(self,
                id_label,  # type: Optional[str]
                with_attributes,  # type: bool
                timestamp_attribute  # type: Optional[str]
-              ):
+               ):
     self.coder = coders.BytesCoder()
     self.full_topic = topic
     self.id_label = id_label
+    #TODO(BEAM-10869): Remove with_attributes since we will never look at it.

Review comment:
       We can remove `with_attributes` from `PubSubSink` in the cleanup PR. @chamikaramj 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org