You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Andras Gyori (Jira)" <ji...@apache.org> on 2020/03/09 12:33:00 UTC
[jira] [Updated] (YARN-9997) Code cleanup in ZKConfigurationStore
[ https://issues.apache.org/jira/browse/YARN-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andras Gyori updated YARN-9997:
-------------------------------
Attachment: YARN-9997.002.patch
> Code cleanup in ZKConfigurationStore
> ------------------------------------
>
> Key: YARN-9997
> URL: https://issues.apache.org/jira/browse/YARN-9997
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Andras Gyori
> Priority: Minor
> Attachments: YARN-9997.001.patch, YARN-9997.002.patch
>
>
> Many thins can be improved:
> * znodeParentPath could be a local variable
> * zkManager could be private, VisibleForTesting annotation is not needed anymore
> * Do something with unchecked casts
> * zkManager.safeSetData calls are almost having the same set of parameters: Simplify this
> * Extract zkManager calls to their own methods: They are repeated
> * Remove TODOs
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org