You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "gruuya (via GitHub)" <gi...@apache.org> on 2026/01/06 11:57:14 UTC

[PR] feat: relax type compatility check in parquet ArrowWriter [arrow-rs]

gruuya opened a new pull request, #9099:
URL: https://github.com/apache/arrow-rs/pull/9099

   # Which issue does this PR close?
   - Closes #9098.
   
   # Rationale for this change
   Don't require strict equality for nested fields (including inner field name/metadata), just require that nested data types are logically equivalent.
   
   # What changes are included in this PR?
   Use `a.equals_datatype(b)` instead of `a == b` at the start of `LevelInfoBuilder::types_compatible`.
   
   # Are these changes tested?
   Yes.
   
   # Are there any user-facing changes?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: relax type compatility check in parquet ArrowWriter [arrow-rs]

Posted by "gruuya (via GitHub)" <gi...@apache.org>.
gruuya commented on PR #9099:
URL: https://github.com/apache/arrow-rs/pull/9099#issuecomment-3714519092

   cc @albertlockett this overlaps/extends some of your recent work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(parquet): relax type compatility check in parquet ArrowWriter [arrow-rs]

Posted by "gruuya (via GitHub)" <gi...@apache.org>.
gruuya commented on PR #9099:
URL: https://github.com/apache/arrow-rs/pull/9099#issuecomment-3714738931

   > I don't think it does, but can you confirm this doesn't conflict with #9077
   
   I think it doesn't. To confirm i checked out your `cleanup-casting` branch, applied my changes from this PR on top of it, and `arrow_writer_test_type_compatibility` still passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(parquet): relax type compatility check in parquet ArrowWriter [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #9099:
URL: https://github.com/apache/arrow-rs/pull/9099


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(parquet): relax type compatility check in parquet ArrowWriter [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #9099:
URL: https://github.com/apache/arrow-rs/pull/9099#issuecomment-3714599905

   I don't think it does, but can you confirm this doesn't conflict with https://github.com/apache/arrow-rs/pull/9077


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(parquet): relax type compatility check in parquet ArrowWriter [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #9099:
URL: https://github.com/apache/arrow-rs/pull/9099#issuecomment-3719451362

   Thanks again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org