You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Jacques Le Roux (Jira)" <ji...@apache.org> on 2021/07/12 10:45:00 UTC
[jira] [Closed] (OFBIZ-12279) Macro renderLink default height and
width not retrieved on menus
[ https://issues.apache.org/jira/browse/OFBIZ-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-12279.
-----------------------------------
Fix Version/s: Upcoming Branch
Resolution: Implemented
Finally I changed my mind, it's hard to backport, so it's an improvement :). And actually there is no real bug you can increase the size of the (small) window.
> Macro renderLink default height and width not retrieved on menus
> ----------------------------------------------------------------
>
> Key: OFBIZ-12279
> URL: https://issues.apache.org/jira/browse/OFBIZ-12279
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
> Affects Versions: Trunk
> Reporter: Leila Mekika
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12279.patch
>
>
> Menus link defaut parameters for height and width are not considered when the link is generated
> The problem seems to be that when parameter with empty value is passed to the macro, macro default values are not retrieved.
> *To reproduce*
> you can create a "layered-modal" type link in a menu and click on the link (without height nor width):
> this will generate the link with parameters "data-dialog-height" and "data-dialog-width" empty
> *Patch provided*
> When applied, the MacroMenuRenderer.renderLink will not send empty values to the macro so that default value will be retrieved (what is actually done on MacroFormRenderer.renderLookup)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)