You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "cchung100m (via GitHub)" <gi...@apache.org> on 2023/05/08 12:31:13 UTC
[GitHub] [incubator-uniffle] cchung100m opened a new pull request, #853: [#774][MINOR] docs: fix the metadata.annotations: Too long in `install.md`
cchung100m opened a new pull request, #853:
URL: https://github.com/apache/incubator-uniffle/pull/853
### What changes were proposed in this pull request?
Fix the metadata.annotations: Too long in `install.md`
### Why are the changes needed?
Solve the error message encountered below when using `kubectl apply -f`
`The CustomResourceDefinition "remoteshuffleservices.uniffle.apache.org" is invalid: metadata.annotations: Too long: must have at most 262144 bytes
`
Fix: #774
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] cchung100m commented on pull request #853: [#774] docs: Fix the metadata.annotations: Too long in `install.md`
Posted by "cchung100m (via GitHub)" <gi...@apache.org>.
cchung100m commented on PR #853:
URL: https://github.com/apache/incubator-uniffle/pull/853#issuecomment-1540042396
> Thanks for your contribution. I noticed similar error.
>
> However, I believe a better solution would be,
>
> ```
> # create, cannot use apply here, see https://github.com/apache/incubator-uniffle/issues/774
> kubectl create -f ${crd-yaml-file}
>
> # update, make sure the crd-yaml-file is a complete CRD file.
> kubectl replace -f ${crd-yaml-file}
> ```
>
> `kubect replace` would replaces the CRD, which doesn't throw an exception if the CRD is already installed.
>
> Refs:
>
> 1. https://medium.com/pareture/kubectl-install-crd-failed-annotations-too-long-2ebc91b40c7d
> 2. https://www.pcbaecker.com/posts/kubernetes-crd-annotation-too-long-fix/
Hi @advancedxy Thank you for the prompt reply and the detailed suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #853: [#774] docs: fix the metadata.annotations: Too long in `install.md`
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #853:
URL: https://github.com/apache/incubator-uniffle/pull/853#issuecomment-1539503573
> It seems better that we use `create` when we need to create operator and we use `apply` when we need to update. https://blog.csdn.net/daiqinge/article/details/103249260 @advancedxy @wangao1236 WDYT?
We cannot apply with the whole CRD file even if we are just updating as the CRD file is too large. See my previous comments for solutions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #853: [#774] docs: fix the metadata.annotations: Too long in `install.md`
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #853:
URL: https://github.com/apache/incubator-uniffle/pull/853#issuecomment-1538605917
It seems better that we use `create` when we need to create operator and we use `apply` when we need to update. https://blog.csdn.net/daiqinge/article/details/103249260
@advancedxy @wangao1236 WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #853: [#774] docs: Fix the metadata.annotations: Too long in `install.md`
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #853:
URL: https://github.com/apache/incubator-uniffle/pull/853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #853: [#774] docs: fix the metadata.annotations: Too long in `install.md`
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #853:
URL: https://github.com/apache/incubator-uniffle/pull/853#issuecomment-1539499760
Thanks for your contribution. I noticed similar error.
However, I believe a better solution would be,
```
# create, cannot use apply here, see https://github.com/apache/incubator-uniffle/issues/774
kubectl create -f ${crd-yaml-file}
# update, make sure the crd-yaml-file is a complete CRD file.
kubectl replace -f ${crd-yaml-file}
```
`kubect replace` would replaces the CRD, which doesn't throw an exception if the CRD is already installed.
Refs:
1. https://medium.com/pareture/kubectl-install-crd-failed-annotations-too-long-2ebc91b40c7d
2. https://www.pcbaecker.com/posts/kubernetes-crd-annotation-too-long-fix/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] cchung100m commented on pull request #853: [#774][MINOR] docs: fix the metadata.annotations: Too long in `install.md`
Posted by "cchung100m (via GitHub)" <gi...@apache.org>.
cchung100m commented on PR #853:
URL: https://github.com/apache/incubator-uniffle/pull/853#issuecomment-1538291578
Hi @xianjingfeng
Following issue #774, I would appreciate that if you can help to review this PR, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #853: [#774] docs: fix the metadata.annotations: Too long in `install.md`
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #853:
URL: https://github.com/apache/incubator-uniffle/pull/853#issuecomment-1538593341
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/853?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#853](https://app.codecov.io/gh/apache/incubator-uniffle/pull/853?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8388709) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/6bd8d1335b0de389defe836d550812d1d31bcd1f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6bd8d13) will **increase** coverage by `2.10%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #853 +/- ##
============================================
+ Coverage 56.58% 58.68% +2.10%
Complexity 2174 2174
============================================
Files 327 307 -20
Lines 15977 13617 -2360
Branches 1262 1262
============================================
- Hits 9040 7991 -1049
+ Misses 6429 5189 -1240
+ Partials 508 437 -71
```
[see 21 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/853/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #853: [#774] docs: Fix the metadata.annotations: Too long in `install.md`
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #853:
URL: https://github.com/apache/incubator-uniffle/pull/853#issuecomment-1542208847
Merged to master. Thanks all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org