You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/04/10 14:46:04 UTC

[GitHub] [incubator-yunikorn-k8shim] HuangTing-Yao opened a new pull request #252: [YUNIKORN-628]Publish a pod event to indicate the task is being gang scheduling

HuangTing-Yao opened a new pull request #252:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/252


   ### What is this PR for?
   Publish the pod level event message to pods, which will be gang scheduled.
   Indicate user those pods will be gang scheduled.
   
   ### What type of PR is it?
   * [ ] - Bug Fix
   * [ ] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/YUNIKORN-628
   
   ### How should this be tested?
   Unit test had been added to test the the `GetRecorder()` and `Eventf()` called time. 
   ### Screenshots (if appropriate)
   ![628](https://user-images.githubusercontent.com/61864060/114273850-55a5fc00-9a4e-11eb-8526-b487619e4a13.png)
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #252: [YUNIKORN-628]Publish a pod event to indicate the task is being gang scheduling

Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #252:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/252#discussion_r611136707



##########
File path: pkg/cache/task.go
##########
@@ -265,6 +265,12 @@ func (task *Task) handleSubmitTaskEvent(event *fsm.Event) {
 
 	events.GetRecorder().Eventf(task.pod, v1.EventTypeNormal, "Scheduling",
 		"%s is queued and waiting for allocation", task.alias)
+	// if this task is belong to the gang member, then post a message to indicate the pod will being scheduled as gang member

Review comment:
       Suggest changing the text to the following:
   
   ```
   // if this task belongs to a task group, that means the app has gang scheduling enabled
   // in this case, post an event to indicate the task is being gang scheduled
   ```

##########
File path: pkg/cache/task_test.go
##########
@@ -28,13 +29,21 @@ import (
 	"k8s.io/apimachinery/pkg/api/resource"
 	apis "k8s.io/apimachinery/pkg/apis/meta/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/client-go/tools/record"
 
 	"github.com/apache/incubator-yunikorn-core/pkg/common"
 	"github.com/apache/incubator-yunikorn-k8shim/pkg/client"
+	"github.com/apache/incubator-yunikorn-k8shim/pkg/common/constants"
 	"github.com/apache/incubator-yunikorn-k8shim/pkg/common/events"
+	"github.com/apache/incubator-yunikorn-k8shim/pkg/conf"
 	"github.com/apache/incubator-yunikorn-scheduler-interface/lib/go/si"
 )
 
+// type recorderTime struct {
+// 	time int64
+// 	lock *sync.RWMutex
+// }
+

Review comment:
       if this is not used, pls remove them

##########
File path: pkg/cache/task.go
##########
@@ -265,6 +265,12 @@ func (task *Task) handleSubmitTaskEvent(event *fsm.Event) {
 
 	events.GetRecorder().Eventf(task.pod, v1.EventTypeNormal, "Scheduling",
 		"%s is queued and waiting for allocation", task.alias)
+	// if this task is belong to the gang member, then post a message to indicate the pod will being scheduled as gang member
+	if !task.placeholder && task.taskGroupName != "" {
+		events.GetRecorder().Eventf(task.pod,
+			v1.EventTypeNormal, "GangScheduling",
+			"Pod belongs to the taskGroup %s, it will being scheduled as a gang member", task.taskGroupName)

Review comment:
       Suggest changing the message to:
   
   "Pod belongs to the taskGroup %s, it will be scheduled as a gang member"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] HuangTing-Yao commented on pull request #252: [YUNIKORN-628]Publish a pod event to indicate the task is being gang scheduling

Posted by GitBox <gi...@apache.org>.
HuangTing-Yao commented on pull request #252:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/252#issuecomment-817265758


   When testing I found that data race happened, it caused by `GetRecorder()` and `SetRecorderForTest()`, so add lock for them.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #252: [YUNIKORN-628]Publish a pod event to indicate the task is being gang scheduling

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #252:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/252#issuecomment-817148674


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=h1) Report
   > Merging [#252](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=desc) (3487a2f) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **increase** coverage by `0.31%`.
   > The diff coverage is `62.11%`.
   
   > :exclamation: Current head 3487a2f differs from pull request most recent head 0079e22. Consider uploading reports for the commit 0079e22 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #252      +/-   ##
   ==========================================
   + Coverage   59.75%   60.06%   +0.31%     
   ==========================================
     Files          35       36       +1     
     Lines        3133     3260     +127     
   ==========================================
   + Hits         1872     1958      +86     
   - Misses       1180     1221      +41     
     Partials       81       81              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/appmgmt/appmgmt\_recovery.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvYXBwbWdtdF9yZWNvdmVyeS5nbw==) | `67.50% <0.00%> (-8.18%)` | :arrow_down: |
   | [pkg/cache/amprotocol\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FtcHJvdG9jb2xfbW9jay5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/events/recorder.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvcmVjb3JkZXIuZ28=) | `27.27% <0.00%> (-2.73%)` | :arrow_down: |
   | [pkg/common/events/recorder\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvcmVjb3JkZXJfbW9jay5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/resource.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9yZXNvdXJjZS5nbw==) | `90.72% <0.00%> (-9.28%)` | :arrow_down: |
   | [pkg/common/utils/gang\_utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy9nYW5nX3V0aWxzLmdv) | `65.43% <0.00%> (-16.11%)` | :arrow_down: |
   | [pkg/controller/application/app\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NvbnRyb2xsZXIvYXBwbGljYXRpb24vYXBwX2NvbnRyb2xsZXIuZ28=) | `71.05% <ø> (-0.26%)` | :arrow_down: |
   | [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
   | [pkg/cache/application\_events.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uX2V2ZW50cy5nbw==) | `55.55% <31.25%> (+2.49%)` | :arrow_up: |
   | [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `73.83% <65.55%> (-2.92%)` | :arrow_down: |
   | ... and [13 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=footer). Last update [81c0b1c...0079e22](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] HuangTing-Yao commented on a change in pull request #252: [YUNIKORN-628]Publish a pod event to indicate the task is being gang scheduling

Posted by GitBox <gi...@apache.org>.
HuangTing-Yao commented on a change in pull request #252:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/252#discussion_r611147361



##########
File path: pkg/cache/task.go
##########
@@ -265,6 +265,12 @@ func (task *Task) handleSubmitTaskEvent(event *fsm.Event) {
 
 	events.GetRecorder().Eventf(task.pod, v1.EventTypeNormal, "Scheduling",
 		"%s is queued and waiting for allocation", task.alias)
+	// if this task is belong to the gang member, then post a message to indicate the pod will being scheduled as gang member
+	if !task.placeholder && task.taskGroupName != "" {
+		events.GetRecorder().Eventf(task.pod,
+			v1.EventTypeNormal, "GangScheduling",
+			"Pod belongs to the taskGroup %s, it will being scheduled as a gang member", task.taskGroupName)

Review comment:
       Sure.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] HuangTing-Yao commented on a change in pull request #252: [YUNIKORN-628]Publish a pod event to indicate the task is being gang scheduling

Posted by GitBox <gi...@apache.org>.
HuangTing-Yao commented on a change in pull request #252:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/252#discussion_r611147332



##########
File path: pkg/cache/task.go
##########
@@ -265,6 +265,12 @@ func (task *Task) handleSubmitTaskEvent(event *fsm.Event) {
 
 	events.GetRecorder().Eventf(task.pod, v1.EventTypeNormal, "Scheduling",
 		"%s is queued and waiting for allocation", task.alias)
+	// if this task is belong to the gang member, then post a message to indicate the pod will being scheduled as gang member

Review comment:
       OK,Sure

##########
File path: pkg/cache/task_test.go
##########
@@ -28,13 +29,21 @@ import (
 	"k8s.io/apimachinery/pkg/api/resource"
 	apis "k8s.io/apimachinery/pkg/apis/meta/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/client-go/tools/record"
 
 	"github.com/apache/incubator-yunikorn-core/pkg/common"
 	"github.com/apache/incubator-yunikorn-k8shim/pkg/client"
+	"github.com/apache/incubator-yunikorn-k8shim/pkg/common/constants"
 	"github.com/apache/incubator-yunikorn-k8shim/pkg/common/events"
+	"github.com/apache/incubator-yunikorn-k8shim/pkg/conf"
 	"github.com/apache/incubator-yunikorn-scheduler-interface/lib/go/si"
 )
 
+// type recorderTime struct {
+// 	time int64
+// 	lock *sync.RWMutex
+// }
+

Review comment:
       OK.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #252: [YUNIKORN-628]Publish a pod event to indicate the task is being gang scheduling

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #252:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/252#issuecomment-817148674


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=h1) Report
   > Merging [#252](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=desc) (0079e22) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **increase** coverage by `0.29%`.
   > The diff coverage is `61.90%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #252      +/-   ##
   ==========================================
   + Coverage   59.75%   60.04%   +0.29%     
   ==========================================
     Files          35       36       +1     
     Lines        3133     3264     +131     
   ==========================================
   + Hits         1872     1960      +88     
   - Misses       1180     1223      +43     
     Partials       81       81              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/appmgmt/appmgmt\_recovery.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvYXBwbWdtdF9yZWNvdmVyeS5nbw==) | `67.50% <0.00%> (-8.18%)` | :arrow_down: |
   | [pkg/cache/amprotocol\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FtcHJvdG9jb2xfbW9jay5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/events/recorder\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvcmVjb3JkZXJfbW9jay5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/resource.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9yZXNvdXJjZS5nbw==) | `90.72% <0.00%> (-9.28%)` | :arrow_down: |
   | [pkg/common/utils/gang\_utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy9nYW5nX3V0aWxzLmdv) | `65.43% <0.00%> (-16.11%)` | :arrow_down: |
   | [pkg/controller/application/app\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NvbnRyb2xsZXIvYXBwbGljYXRpb24vYXBwX2NvbnRyb2xsZXIuZ28=) | `71.05% <ø> (-0.26%)` | :arrow_down: |
   | [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
   | [pkg/cache/application\_events.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uX2V2ZW50cy5nbw==) | `55.55% <31.25%> (+2.49%)` | :arrow_up: |
   | [pkg/common/events/recorder.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvcmVjb3JkZXIuZ28=) | `33.33% <40.00%> (+3.33%)` | :arrow_up: |
   | [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `73.83% <65.55%> (-2.92%)` | :arrow_down: |
   | ... and [13 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=footer). Last update [81c0b1c...0079e22](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] yangwwei merged pull request #252: [YUNIKORN-628]Publish a pod event to indicate the task is being gang scheduling

Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #252:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/252


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #252: [YUNIKORN-628]Publish a pod event to indicate the task is being gang scheduling

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #252:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/252#issuecomment-817148674


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=h1) Report
   > Merging [#252](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=desc) (3487a2f) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **increase** coverage by `0.31%`.
   > The diff coverage is `62.11%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #252      +/-   ##
   ==========================================
   + Coverage   59.75%   60.06%   +0.31%     
   ==========================================
     Files          35       36       +1     
     Lines        3133     3260     +127     
   ==========================================
   + Hits         1872     1958      +86     
   - Misses       1180     1221      +41     
     Partials       81       81              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/appmgmt/appmgmt\_recovery.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvYXBwbWdtdF9yZWNvdmVyeS5nbw==) | `67.50% <0.00%> (-8.18%)` | :arrow_down: |
   | [pkg/cache/amprotocol\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FtcHJvdG9jb2xfbW9jay5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/events/recorder.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvcmVjb3JkZXIuZ28=) | `27.27% <0.00%> (-2.73%)` | :arrow_down: |
   | [pkg/common/events/recorder\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvcmVjb3JkZXJfbW9jay5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/resource.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9yZXNvdXJjZS5nbw==) | `90.72% <0.00%> (-9.28%)` | :arrow_down: |
   | [pkg/common/utils/gang\_utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy9nYW5nX3V0aWxzLmdv) | `65.43% <0.00%> (-16.11%)` | :arrow_down: |
   | [pkg/controller/application/app\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NvbnRyb2xsZXIvYXBwbGljYXRpb24vYXBwX2NvbnRyb2xsZXIuZ28=) | `71.05% <ø> (-0.26%)` | :arrow_down: |
   | [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
   | [pkg/cache/application\_events.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uX2V2ZW50cy5nbw==) | `55.55% <31.25%> (+2.49%)` | :arrow_up: |
   | [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `73.83% <65.55%> (-2.92%)` | :arrow_down: |
   | ... and [13 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=footer). Last update [81c0b1c...3487a2f](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/252?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org