[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #7843: DNS: Fix lack of nameserver failover in low use circumstances.

[GitBox <gi...@apache.org>]

SolidWallOfCode commented on a change in pull request #7843:
URL: https://github.com/apache/trafficserver/pull/7843#discussion_r643184758



##########
File path: iocore/dns/DNS.cc
##########
@@ -524,12 +524,12 @@ DNSHandler::open_con(sockaddr const *target, bool failed, int icon, bool over_tc
     }
     return false;
   } else {
-    ns_down[icon] = 0;
     if (cur_con.eio.start(pd, &cur_con, EVENTIO_READ) < 0) {
       Error("[iocore_dns] open_con: Failed to add %d server to epoll list\n", icon);
     } else {
-      cur_con.num = icon;
-      Debug("dns", "opening connection %s SUCCEEDED for %d", ip_text, icon);
+      cur_con.num   = icon;
+      ns_down[icon] = 0;

Review comment:
       Note - don't clear the down flag if this nameserver connection isn't in the `epoll`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org