You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Renjith Kamath <re...@gmail.com> on 2016/11/30 09:46:05 UTC
Re: Review Request 54031: Remove Zeppelin View from Ambari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54031/
-----------------------------------------------------------
(Updated Nov. 30, 2016, 9:46 a.m.)
Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
Changes
-------
required DML updates for Zeppelin view removal.
Bugs: AMBARI-18975
https://issues.apache.org/jira/browse/AMBARI-18975
Repository: ambari
Description
-------
details in the jira ticket
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java 52de784
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 4135919
contrib/views/pom.xml ca5aef4
contrib/views/zeppelin/pom.xml 6a7f585
contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServiceCheck.java 8f94260
contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java ab61a3d
contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml 6b2d156
contrib/views/zeppelin/src/main/resources/view.log4j.properties 15d264e
contrib/views/zeppelin/src/main/resources/view.xml 323e09a
Diff: https://reviews.apache.org/r/54031/diff/
Testing
-------
manually tested
Thanks,
Renjith Kamath
Re: Review Request 54031: Remove Zeppelin View from Ambari
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54031/#review157614
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Dec. 1, 2016, 10:54 a.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54031/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2016, 10:54 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-18975
> https://issues.apache.org/jira/browse/AMBARI-18975
>
>
> Repository: ambari
>
>
> Description
> -------
>
> details in the jira ticket
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java 52de784
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java ce0b387
> contrib/views/pom.xml ca5aef4
> contrib/views/zeppelin/pom.xml 6a7f585
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServiceCheck.java 8f94260
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java ab61a3d
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml 6b2d156
> contrib/views/zeppelin/src/main/resources/view.log4j.properties 15d264e
> contrib/views/zeppelin/src/main/resources/view.xml 323e09a
>
> Diff: https://reviews.apache.org/r/54031/diff/
>
>
> Testing
> -------
>
> manually tested
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 54031: Remove Zeppelin View from Ambari
Posted by Renjith Kamath <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54031/
-----------------------------------------------------------
(Updated Dec. 1, 2016, 10:54 a.m.)
Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
Bugs: AMBARI-18975
https://issues.apache.org/jira/browse/AMBARI-18975
Repository: ambari
Description
-------
details in the jira ticket
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java 52de784
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java ce0b387
contrib/views/pom.xml ca5aef4
contrib/views/zeppelin/pom.xml 6a7f585
contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServiceCheck.java 8f94260
contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java ab61a3d
contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml 6b2d156
contrib/views/zeppelin/src/main/resources/view.log4j.properties 15d264e
contrib/views/zeppelin/src/main/resources/view.xml 323e09a
Diff: https://reviews.apache.org/r/54031/diff/
Testing
-------
manually tested
Thanks,
Renjith Kamath
Re: Review Request 54031: Remove Zeppelin View from Ambari
Posted by Renjith Kamath <re...@gmail.com>.
> On Nov. 30, 2016, 7:18 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, line 183
> > <https://reviews.apache.org/r/54031/diff/2/?file=1572968#file1572968line183>
> >
> > Do these tables also need to delete the record?
> >
> > viewinstancedata, viewinstanceproperty, viewparameter, viewresource, viewentity
>
> Renjith Kamath wrote:
> Found an entry in viewparameter. No more zeppelin view records in other tables.
Also fixed the merge conflict.
- Renjith
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54031/#review157443
-----------------------------------------------------------
On Dec. 1, 2016, 10:54 a.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54031/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2016, 10:54 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-18975
> https://issues.apache.org/jira/browse/AMBARI-18975
>
>
> Repository: ambari
>
>
> Description
> -------
>
> details in the jira ticket
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java 52de784
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java ce0b387
> contrib/views/pom.xml ca5aef4
> contrib/views/zeppelin/pom.xml 6a7f585
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServiceCheck.java 8f94260
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java ab61a3d
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml 6b2d156
> contrib/views/zeppelin/src/main/resources/view.log4j.properties 15d264e
> contrib/views/zeppelin/src/main/resources/view.xml 323e09a
>
> Diff: https://reviews.apache.org/r/54031/diff/
>
>
> Testing
> -------
>
> manually tested
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 54031: Remove Zeppelin View from Ambari
Posted by Renjith Kamath <re...@gmail.com>.
> On Nov. 30, 2016, 7:18 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, line 183
> > <https://reviews.apache.org/r/54031/diff/2/?file=1572968#file1572968line183>
> >
> > Do these tables also need to delete the record?
> >
> > viewinstancedata, viewinstanceproperty, viewparameter, viewresource, viewentity
Found an entry in viewparameter. No more zeppelin view records in other tables.
- Renjith
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54031/#review157443
-----------------------------------------------------------
On Dec. 1, 2016, 10:54 a.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54031/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2016, 10:54 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-18975
> https://issues.apache.org/jira/browse/AMBARI-18975
>
>
> Repository: ambari
>
>
> Description
> -------
>
> details in the jira ticket
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java 52de784
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java ce0b387
> contrib/views/pom.xml ca5aef4
> contrib/views/zeppelin/pom.xml 6a7f585
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServiceCheck.java 8f94260
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java ab61a3d
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml 6b2d156
> contrib/views/zeppelin/src/main/resources/view.log4j.properties 15d264e
> contrib/views/zeppelin/src/main/resources/view.xml 323e09a
>
> Diff: https://reviews.apache.org/r/54031/diff/
>
>
> Testing
> -------
>
> manually tested
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 54031: Remove Zeppelin View from Ambari
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54031/#review157443
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java (line 183)
<https://reviews.apache.org/r/54031/#comment228044>
Do these tables also need to delete the record?
viewinstancedata, viewinstanceproperty, viewparameter, viewresource, viewentity
- Alejandro Fernandez
On Nov. 30, 2016, 9:46 a.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54031/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 9:46 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-18975
> https://issues.apache.org/jira/browse/AMBARI-18975
>
>
> Repository: ambari
>
>
> Description
> -------
>
> details in the jira ticket
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java 52de784
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 4135919
> contrib/views/pom.xml ca5aef4
> contrib/views/zeppelin/pom.xml 6a7f585
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServiceCheck.java 8f94260
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java ab61a3d
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml 6b2d156
> contrib/views/zeppelin/src/main/resources/view.log4j.properties 15d264e
> contrib/views/zeppelin/src/main/resources/view.xml 323e09a
>
> Diff: https://reviews.apache.org/r/54031/diff/
>
>
> Testing
> -------
>
> manually tested
>
>
> Thanks,
>
> Renjith Kamath
>
>