You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/01/07 03:15:00 UTC
[GitHub] [druid] clintropolis opened a new pull request #9135: fix web
console data loader dimension types
clintropolis opened a new pull request #9135: fix web console data loader dimension types
URL: https://github.com/apache/druid/pull/9135
### Description
This PR fixes an issue with the web console data loader wizard, which is using all-caps types 'STRING', 'LONG', 'DOUBLE' when converting something it thinks is a metric into a dimension, which don't get correctly recognized by the dimension schema json deserialization, resulting in the column types defaulting to 'string'.
Additionally, the types presented in the type dropdown once converted to a dimension differ from the types available to convert a metric to ('string', 'long', 'float' vs 'STRING', 'LONG', 'DOUBLE').
These have been standardized to use 'string', 'long', 'float', 'double' in all the places.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on issue #9135: fix web console data
loader dimension types
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on issue #9135: fix web console data loader dimension types
URL: https://github.com/apache/druid/pull/9135#issuecomment-571434146
thank you for this fix 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky merged pull request #9135: fix web console data
loader dimension types
Posted by GitBox <gi...@apache.org>.
vogievetsky merged pull request #9135: fix web console data loader dimension types
URL: https://github.com/apache/druid/pull/9135
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org