You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sgilmore10 (via GitHub)" <gi...@apache.org> on 2023/06/23 15:40:03 UTC

[GitHub] [arrow] sgilmore10 opened a new pull request, #36270: GH-36251: [MATLAB] Add `Type` property to `arrow.array.Array`

sgilmore10 opened a new pull request, #36270:
URL: https://github.com/apache/arrow/pull/36270

   > **Warning** This PR is dependent on #36114. Once that one is merged, I'll rebase the changes and mark it as ready for review.
   
   ### Rationale for this change
   
   Now that we've added the `arrow.type.Type` class hierarchy to the interface, we should add a property named `Type` to the base `arrow.array.Array` class.
   
   ### What changes are included in this PR?
   
   All concrete subclasses of the `arrow.array.Array` define a property named `Type`:
   
   ```matlab
   >> a = arrow.array.Float64Array([1 2 3 4])
   
   a = 
   
   [
     1,
     2,
     3,
     4
   ]
   >> a.Type
   
   ans = 
   
     Float64Type with properties:
   
               ID: Float64
         BitWidth: 64
        NumFields: 0
       NumBuffers: 2
   ```
   
   
   ### Are these changes tested?
   Yes, we added test cases in `hNumeric.m` and `tBooleanArray.m`.
   
   ### Are there any user-facing changes?
   
   Yes.
   
   ### Note
   
   1. I noticed that the `tInt16Array.m` test class did not define the `NullSubstitutionValue` property. This meant the test class was abstract, so its tests were not running. That was my mistake. We'll think about ways to verify all the appropriate tests are running in CI.
   2. As @kou mentioned, we think it may be worth creating "Type" C++ proxy classes, especially when we start implementing nested array types. For now, we'll leave them as MATLAB-only classes, but will probably change their implementation soon. 
   3. Thank you to @kevingurney for the help!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36270: GH-36251: [MATLAB] Add `Type` property to `arrow.array.Array`

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36270:
URL: https://github.com/apache/arrow/pull/36270#issuecomment-1609335699

   Conbench analyzed the 6 benchmark runs on commit `6fc44889`.
   
   There was 1 benchmark result indicating a performance regression:
   
   - Commit Run on `arm64-m6g-linux-compute` at [2023-06-24 17:49:31Z](http://conbench.ursa.dev/compare/runs/b85f159e50c94ad8a42bad2c74305fc0...749245f6c2ee41409e912d93fcb4f85a/)
     - [params=<SMALL_VECTOR(std::string)>, source=cpp-micro, suite=arrow-small-vector-benchmark](http://conbench.ursa.dev/compare/benchmarks/064970f12f397aa58000a687923c5ff5...064972cec26b77548000d9d65e386fc4)
   
   The [full Conbench report](https://github.com/apache/arrow/runs/14587556760) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou merged pull request #36270: GH-36251: [MATLAB] Add `Type` property to `arrow.array.Array`

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #36270:
URL: https://github.com/apache/arrow/pull/36270


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org