You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by si...@apache.org on 2018/06/04 22:03:58 UTC

[bookkeeper] 04/09: Include stream modules in bookkeeper distributions only when `-Dstream` is specified

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch branch-4.7
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git

commit 308cf1e196136f6fb714d47f540e50c7aaa38bce
Author: Sijie Guo <si...@apache.org>
AuthorDate: Sun May 27 22:57:22 2018 -0700

    Include stream modules in bookkeeper distributions only when `-Dstream` is specified
    
    Descriptions of the changes in this PR:
    
    *Motivation*
    
    stream modules are only built when `-Dstream` is specified. so if we want to include
    binary distribution, `-Dstream` is needed. This updates those modules with profiles
    that enabled when `-Dstream` is specified.
    
    Author: Sijie Guo <si...@apache.org>
    
    Reviewers: Enrico Olivelli <eo...@gmail.com>
    
    This closes #1447 from sijie/fix_stream_module
---
 bookkeeper-dist/all/pom.xml    | 25 ++++++++++++++++++-------
 bookkeeper-dist/server/pom.xml | 25 ++++++++++++++++++-------
 tests/integration/pom.xml      | 15 ++++++++++++++-
 3 files changed, 50 insertions(+), 15 deletions(-)

diff --git a/bookkeeper-dist/all/pom.xml b/bookkeeper-dist/all/pom.xml
index d1f5b25..ae36e20 100644
--- a/bookkeeper-dist/all/pom.xml
+++ b/bookkeeper-dist/all/pom.xml
@@ -92,13 +92,6 @@
       <version>${project.version}</version>
     </dependency>
 
-    <!-- stream.storage -->
-    <dependency>
-      <groupId>org.apache.bookkeeper</groupId>
-      <artifactId>stream-storage-server</artifactId>
-      <version>${project.version}</version>
-    </dependency>
-
     <!-- bookkeeper benchmark -->
     <dependency>
       <groupId>org.apache.bookkeeper</groupId>
@@ -152,4 +145,22 @@
       </plugin>
     </plugins>
   </build>
+  <profiles>
+    <profile>
+      <id>stream</id>
+      <activation>
+        <property>
+          <name>stream</name>
+        </property>
+      </activation>
+      <dependencies>
+        <!-- stream.storage -->
+        <dependency>
+          <groupId>org.apache.bookkeeper</groupId>
+          <artifactId>stream-storage-server</artifactId>
+          <version>${project.version}</version>
+        </dependency>
+      </dependencies>
+    </profile>
+  </profiles>
 </project>
diff --git a/bookkeeper-dist/server/pom.xml b/bookkeeper-dist/server/pom.xml
index abcd0ef..9021352 100644
--- a/bookkeeper-dist/server/pom.xml
+++ b/bookkeeper-dist/server/pom.xml
@@ -76,13 +76,6 @@
       <version>${project.version}</version>
     </dependency>
 
-    <!-- stream.storage -->
-    <dependency>
-      <groupId>org.apache.bookkeeper</groupId>
-      <artifactId>stream-storage-server</artifactId>
-      <version>${project.version}</version>
-    </dependency>
-
     <!-- slf4j binding -->
     <dependency>
       <groupId>org.slf4j</groupId>
@@ -130,4 +123,22 @@
 
     </plugins>
   </build>
+  <profiles>
+    <profile>
+      <id>stream</id>
+      <activation>
+        <property>
+          <name>stream</name>
+        </property>
+      </activation>
+      <dependencies>
+        <!-- stream.storage -->
+        <dependency>
+          <groupId>org.apache.bookkeeper</groupId>
+          <artifactId>stream-storage-server</artifactId>
+          <version>${project.version}</version>
+        </dependency>
+      </dependencies>
+    </profile>
+  </profiles>
 </project>
diff --git a/tests/integration/pom.xml b/tests/integration/pom.xml
index bcf3622..20d301c 100644
--- a/tests/integration/pom.xml
+++ b/tests/integration/pom.xml
@@ -30,7 +30,6 @@
   <modules>
     <module>smoke</module>
     <module>standalone</module>
-    <module>cluster</module>
   </modules>
 
   <build>
@@ -70,5 +69,19 @@
         </plugins>
       </build>
     </profile>
+
+    <!-- enable building table service related tests only when -Dstream is provided -->
+    <profile>
+      <id>stream</id>
+      <activation>
+        <property>
+          <name>stream</name>
+        </property>
+      </activation>
+      <modules>
+        <!-- enable cluster testing -->
+        <module>cluster</module>
+      </modules>
+    </profile>
   </profiles>
 </project>

-- 
To stop receiving notification emails like this one, please contact
sijie@apache.org.