You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2023/02/05 19:01:14 UTC
[GitHub] [airflow] eladkal opened a new pull request, #29379: Prepare docs for Feb 2023 wave of Providers
eladkal opened a new pull request, #29379:
URL: https://github.com/apache/airflow/pull/29379
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29379: Prepare docs for Feb 2023 wave of Providers
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29379:
URL: https://github.com/apache/airflow/pull/29379#issuecomment-1421576178
Seems that it works now (except static checks solved in #29411 and #29412 ) just merged - so it was likely a temporary blip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29379: Prepare docs for Feb 2023 wave of Providers
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29379:
URL: https://github.com/apache/airflow/pull/29379#issuecomment-1419325736
@eladkal - I think if you rebase to latest main and regenerate the docs, the build should work now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #29379: Prepare docs for Feb 2023 wave of Providers
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #29379:
URL: https://github.com/apache/airflow/pull/29379#discussion_r1097399079
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,42 @@
Changelog
---------
+7.2.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add option to wait for completion on the EmrCreateJobFlowOperator (#28827)``
+* ``Add transfer operator S3 to (generic) SQL (#29085)``
+* ``add retries to stop_pipeline on conflict (#29077)``
+* ``Add log for AWS Glue Job Console URL (#28925)``
+* ``Enable individual trigger logging (#27758)``
+
+Bug Fixes
+~~~~~~~~~
+
+* ``fix: 'num_of_dpus' typehints- GlueJobHook/Operator (#29176)``
+* ``Fix false-positive spellcheck failure (#29190)``
Review Comment:
#29190 I guess it fix only our internal CI process. I think it could be classified as Misc or even we could exclude deom changelog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a diff in pull request #29379: Prepare docs for Feb 2023 wave of Providers
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on code in PR #29379:
URL: https://github.com/apache/airflow/pull/29379#discussion_r1096800267
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,46 @@
Changelog
---------
+7.2.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+
+Features
+~~~~~~~~
+
+* ``Add option to wait for completion on the EmrCreateJobFlowOperator (#28827)``
+* ``Add transfer operator S3 to (generic) SQL (#29085)``
+* ``add retries to stop_pipeline on conflict (#29077)``
+* ``Add log for AWS Glue Job Console URL (#28925)``
+* ``Enable individual trigger logging (#27758)``
Review Comment:
Oh you are saying, are these changes compatible with airflow < 2.6 -- yes, that is the intention. And I can help test this in the coming week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #29379: Prepare docs for Feb 2023 wave of Providers
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #29379:
URL: https://github.com/apache/airflow/pull/29379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29379: Prepare docs for Feb 2023 wave of Providers
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29379:
URL: https://github.com/apache/airflow/pull/29379#issuecomment-1422206924
Cool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #29379: Prepare docs for Feb 2023 wave of Providers
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #29379:
URL: https://github.com/apache/airflow/pull/29379#discussion_r1096791231
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,46 @@
Changelog
---------
+7.2.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+
+Features
+~~~~~~~~
+
+* ``Add option to wait for completion on the EmrCreateJobFlowOperator (#28827)``
+* ``Add transfer operator S3 to (generic) SQL (#29085)``
+* ``add retries to stop_pipeline on conflict (#29077)``
+* ``Add log for AWS Glue Job Console URL (#28925)``
+* ``Enable individual trigger logging (#27758)``
Review Comment:
@dstandish this entry is in several provider releases. This feature is suppose to be released in airflow 2.6.0 however in providers we don't cherry pick we release everything that is merged. Is that OK for this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #29379: Prepare docs for Feb 2023 wave of Providers
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #29379:
URL: https://github.com/apache/airflow/pull/29379#discussion_r1096806903
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,46 @@
Changelog
---------
+7.2.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+
+Features
+~~~~~~~~
+
+* ``Add option to wait for completion on the EmrCreateJobFlowOperator (#28827)``
+* ``Add transfer operator S3 to (generic) SQL (#29085)``
+* ``add retries to stop_pipeline on conflict (#29077)``
+* ``Add log for AWS Glue Job Console URL (#28925)``
+* ``Enable individual trigger logging (#27758)``
Review Comment:
Cool! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a diff in pull request #29379: Prepare docs for Feb 2023 wave of Providers
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on code in PR #29379:
URL: https://github.com/apache/airflow/pull/29379#discussion_r1096799985
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,46 @@
Changelog
---------
+7.2.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+
+Features
+~~~~~~~~
+
+* ``Add option to wait for completion on the EmrCreateJobFlowOperator (#28827)``
+* ``Add transfer operator S3 to (generic) SQL (#29085)``
+* ``add retries to stop_pipeline on conflict (#29077)``
+* ``Add log for AWS Glue Job Console URL (#28925)``
+* ``Enable individual trigger logging (#27758)``
Review Comment:
Hi @eladkal
> however in providers we don't cherry pick we release everything that is merged. Is that OK for this case?
Can you clarify what you mean? I.e. what's the "that" that you are wondering if it is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a diff in pull request #29379: Prepare docs for Feb 2023 wave of Providers
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on code in PR #29379:
URL: https://github.com/apache/airflow/pull/29379#discussion_r1096959950
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,46 @@
Changelog
---------
+7.2.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+
+Features
+~~~~~~~~
+
+* ``Add option to wait for completion on the EmrCreateJobFlowOperator (#28827)``
+* ``Add transfer operator S3 to (generic) SQL (#29085)``
+* ``add retries to stop_pipeline on conflict (#29077)``
+* ``Add log for AWS Glue Job Console URL (#28925)``
+* ``Enable individual trigger logging (#27758)``
Review Comment:
OK i built the provider packages from main which have task log handlers, and i tested the handler functionality with 2.5.1 and did not observe any issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29379: Prepare docs for Feb 2023 wave of Providers
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29379:
URL: https://github.com/apache/airflow/pull/29379#discussion_r1097264986
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,46 @@
Changelog
---------
+7.2.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+
+Features
+~~~~~~~~
+
+* ``Add option to wait for completion on the EmrCreateJobFlowOperator (#28827)``
+* ``Add transfer operator S3 to (generic) SQL (#29085)``
+* ``add retries to stop_pipeline on conflict (#29077)``
+* ``Add log for AWS Glue Job Console URL (#28925)``
+* ``Enable individual trigger logging (#27758)``
Review Comment:
Good call @eladkal ! Thanks for checking Daniel. We have so far very rudimentary "import" checks for back-compat, but this one has indeed higher probablity of breaking compat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #29379: Prepare docs for Feb 2023 wave of Providers
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #29379:
URL: https://github.com/apache/airflow/pull/29379#discussion_r1097399079
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,42 @@
Changelog
---------
+7.2.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add option to wait for completion on the EmrCreateJobFlowOperator (#28827)``
+* ``Add transfer operator S3 to (generic) SQL (#29085)``
+* ``add retries to stop_pipeline on conflict (#29077)``
+* ``Add log for AWS Glue Job Console URL (#28925)``
+* ``Enable individual trigger logging (#27758)``
+
+Bug Fixes
+~~~~~~~~~
+
+* ``fix: 'num_of_dpus' typehints- GlueJobHook/Operator (#29176)``
+* ``Fix false-positive spellcheck failure (#29190)``
Review Comment:
#29190 I guess it fix only our internal CI process. I guess I could be classified as Misc or even could exclude in changelog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #29379: Prepare docs for Feb 2023 wave of Providers
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #29379:
URL: https://github.com/apache/airflow/pull/29379#discussion_r1096823960
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,46 @@
Changelog
---------
+7.2.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+
Review Comment:
```suggestion
```
##########
airflow/providers/ftp/CHANGELOG.rst:
##########
@@ -24,6 +24,25 @@
Changelog
---------
+3.3.1
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+
+Features
+~~~~~~~~
+
+
+Bug Fixes
+~~~~~~~~~
+
+
+.. Below changes are excluded from the changelog. Move them to
+ appropriate section above if needed. Do not delete the lines(!):
+ * ``FTP operator has logic in __init__ (#29073)``
Review Comment:
Should this be moved into bugfix?
##########
airflow/providers/cncf/kubernetes/CHANGELOG.rst:
##########
@@ -24,6 +24,16 @@
Changelog
---------
+5.2.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add deferrable mode to ''KubernetesPodOperator'' (#29017)``
+* ``Patch only single label when marking KPO checked (#29279)``
Review Comment:
This is a bugfix.
##########
airflow/providers/elasticsearch/CHANGELOG.rst:
##########
@@ -24,22 +24,30 @@
Changelog
---------
+4.4.0
+.....
+
+
Review Comment:
```suggestion
```
Nit: extra newline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org