You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/01/08 13:08:44 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #2118: Align Kotlin and SmallRye Reactive Messaging Camel with Quarkus
jamesnetherton opened a new pull request #2118:
URL: https://github.com/apache/camel-quarkus/pull/2118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2118: Align Kotlin and SmallRye Reactive Messaging Camel with Quarkus
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2118:
URL: https://github.com/apache/camel-quarkus/pull/2118#discussion_r553986433
##########
File path: pom.xml
##########
@@ -93,7 +93,7 @@
<protobuf.version>${protobuf-version}</protobuf.version>
<retrofit.version>2.5.0</retrofit.version>
<scala-2.11.version>2.11.12</scala-2.11.version><!-- Spark -->
- <smallrye.reactive.messaging.camel.version>2.7.0</smallrye.reactive.messaging.camel.version>
+ <smallrye.reactive.messaging.camel.version>2.7.1</smallrye.reactive.messaging.camel.version> <!-- keep in sync with Quarkus SmallRye Reactive Messaging -->
Review comment:
🕱 tab !?!?!
```suggestion
<smallrye.reactive.messaging.camel.version>2.7.1</smallrye.reactive.messaging.camel.version> <!-- keep in sync with Quarkus SmallRye Reactive Messaging -->
```
##########
File path: integration-tests/avro-rpc/pom.xml
##########
@@ -127,6 +127,7 @@
<plugin>
<groupId>org.apache.avro</groupId>
<artifactId>avro-maven-plugin</artifactId>
+ <version>${avro-version}</version>
Review comment:
I thought we have agreed to wrap Camel version props into our own `.version` properties in the top pom, so that we keep an overview in a single place which props we inherit from Camel. Maybe I am wrong remembering or interpreting what we agreed on :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #2118: Align Kotlin and SmallRye Reactive Messaging Camel with Quarkus
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #2118:
URL: https://github.com/apache/camel-quarkus/pull/2118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #2118: Align Kotlin and SmallRye Reactive Messaging Camel with Quarkus
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #2118:
URL: https://github.com/apache/camel-quarkus/pull/2118#discussion_r553989548
##########
File path: integration-tests/avro-rpc/pom.xml
##########
@@ -127,6 +127,7 @@
<plugin>
<groupId>org.apache.avro</groupId>
<artifactId>avro-maven-plugin</artifactId>
+ <version>${avro-version}</version>
Review comment:
Yes, you're right. I'll fix that.
##########
File path: pom.xml
##########
@@ -93,7 +93,7 @@
<protobuf.version>${protobuf-version}</protobuf.version>
<retrofit.version>2.5.0</retrofit.version>
<scala-2.11.version>2.11.12</scala-2.11.version><!-- Spark -->
- <smallrye.reactive.messaging.camel.version>2.7.0</smallrye.reactive.messaging.camel.version>
+ <smallrye.reactive.messaging.camel.version>2.7.1</smallrye.reactive.messaging.camel.version> <!-- keep in sync with Quarkus SmallRye Reactive Messaging -->
Review comment:
Guess I deserved that for making a last moment edit using vim :stuck_out_tongue:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2118: Align Kotlin and SmallRye Reactive Messaging Camel with Quarkus
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2118:
URL: https://github.com/apache/camel-quarkus/pull/2118#discussion_r553986433
##########
File path: pom.xml
##########
@@ -93,7 +93,7 @@
<protobuf.version>${protobuf-version}</protobuf.version>
<retrofit.version>2.5.0</retrofit.version>
<scala-2.11.version>2.11.12</scala-2.11.version><!-- Spark -->
- <smallrye.reactive.messaging.camel.version>2.7.0</smallrye.reactive.messaging.camel.version>
+ <smallrye.reactive.messaging.camel.version>2.7.1</smallrye.reactive.messaging.camel.version> <!-- keep in sync with Quarkus SmallRye Reactive Messaging -->
Review comment:
🕱 tab !?!?!
```suggestion
<smallrye.reactive.messaging.camel.version>2.7.1</smallrye.reactive.messaging.camel.version> <!-- keep in sync with Quarkus SmallRye Reactive Messaging -->
```
##########
File path: integration-tests/avro-rpc/pom.xml
##########
@@ -127,6 +127,7 @@
<plugin>
<groupId>org.apache.avro</groupId>
<artifactId>avro-maven-plugin</artifactId>
+ <version>${avro-version}</version>
Review comment:
I thought we have agreed to wrap Camel version props into our own `.version` properties in the top pom, so that we keep an overview in a single place which props we inherit from Camel. Maybe I am wrong remembering or interpreting what we agreed on :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #2118: Align Kotlin and SmallRye Reactive Messaging Camel with Quarkus
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #2118:
URL: https://github.com/apache/camel-quarkus/pull/2118#discussion_r553989548
##########
File path: integration-tests/avro-rpc/pom.xml
##########
@@ -127,6 +127,7 @@
<plugin>
<groupId>org.apache.avro</groupId>
<artifactId>avro-maven-plugin</artifactId>
+ <version>${avro-version}</version>
Review comment:
Yes, you're right. I'll fix that.
##########
File path: pom.xml
##########
@@ -93,7 +93,7 @@
<protobuf.version>${protobuf-version}</protobuf.version>
<retrofit.version>2.5.0</retrofit.version>
<scala-2.11.version>2.11.12</scala-2.11.version><!-- Spark -->
- <smallrye.reactive.messaging.camel.version>2.7.0</smallrye.reactive.messaging.camel.version>
+ <smallrye.reactive.messaging.camel.version>2.7.1</smallrye.reactive.messaging.camel.version> <!-- keep in sync with Quarkus SmallRye Reactive Messaging -->
Review comment:
Guess I deserved that for making a last moment edit using vim :stuck_out_tongue:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #2118: Align Kotlin and SmallRye Reactive Messaging Camel with Quarkus
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #2118:
URL: https://github.com/apache/camel-quarkus/pull/2118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org